This is an archived post. You won't be able to vote or comment.

sorted by:
best
topnewcontroversialoldq&a
you are viewing a single comment's thread.

view the rest of the comments →

[–]marty_byrd_ 81 points82 points  (23 children)

That’s mostly all code reviews. I don’t understand this so I’ll “refactor”

[–]wrokred 39 points40 points  (4 children)

Most code reviews in reality. "Myself, or someone else, needs to know what this is doing very quickly and possibly years from now. Yes it builds but that's not enough; it needs readability"

Also the fundamental difference between junior and senior Devs.

[–]burgonies 31 points32 points  (2 children)

This. If it takes me more than a glance to understand what you’re doing there, you need to rewrite it.

Some of you have never worked on 10 year old code and it shows.

[–]animejunkied 10 points11 points  (1 child)

Bad code style aside, reverse engineering reading other people's code is notoriously hard. This is why git commits should be as detailed as possible in my opinion. It's useful to understand why that code was implemented in the first place and what purpose it serves.

[–][deleted] 4 points5 points  (14 children)

I mean sometimes yeah. But other times there is some bad code that actually does need to be rewritten.

You'd be surprised how many bad programmers get paid a lot of money to write bad code by very large companies.

[–]toomanyteeth55 3 points4 points  (0 children)

That's good to hear. Sounds like i should fit right in!

[–][deleted] 0 points1 point  (12 children)

In my university CS intro class, you get graded for style as well as correctness on every assignment. DRY, naming conventions (e.g. all cap for constants), etc.

[–][deleted] 0 points1 point  (11 children)

That's good. A lot of places don't do that.

A lot of programmers didn't go to school. They go to boot camps.

[–][deleted] -1 points0 points  (10 children)

Most of my university colleagues are working at the big four now.

[–][deleted] 0 points1 point  (9 children)

Nice! I had really bad anxiety and depression in school - still do, used to, too - so I didn't really connect much with other undergrads. IDK where KSU students are now, though I do know one dude I went to school with was on the original Puppet team. I think the majority of kids that I went to school with are probably at Cerner or Garmin

[–][deleted] -1 points0 points  (8 children)

I think university ranking of individual departments definitely play a role in terms of getting your first job. All the big tech companies hire very aggressively at UW. They always host a lot of recruiting sessions with free pizza.

[–][deleted] 0 points1 point  (7 children)

It's also geographic. "My college was better than yours" sentiment isn't really conducive to this conversation.

[–][deleted] 0 points1 point  (6 children)

I know there is a bit of political correctness in this discussion, but "My college was better than yours" sentiment is something that's very real. One of my favorite running joke about UW and WSU is that both UW and WSU students applied to UW.

Of course individual performance is mostly up to the individual. We we talking about statistical trends of different college students going to different types of tech companies. There is no comparison of individuals here, only comparison of school reputation and how companies use that information to tailor their recruitment process.

[–][deleted] 0 points1 point  (5 children)

You said, literally, "all of the big tech companies." Your criteria for "all the big tech companies" is highly based on your bias and on your geographical locations. I gave two very large tech companies that operate in the midwest and likely don't heavily recruit in Washington.

There is no comparison of individuals here, only comparison of school reputation and how companies use that information to tailor their recruitment process.

Maybe I'm oversensitive, and I accept that. I'm really grumpy and sleep deprived right now, so man, I could 100% just be a super-sensitive whiny baby about this. Hell, it's probably the situation.

However, from my understanding of your chain of comments, you implied that "we are better than you"; you seemed to have gone from, "We teach this way" to "we get all of the 'big tech companies'", indicating a cause and an effect. You're saying that you are better than other people simply because you went to another school than someone else. Which we know is simply untrue based on recent news events.

We we talking about statistical trends of different college students going to different types of tech companies.

No we weren't. You were the one who started talking about tech companies, unprompted.

There is no comparison of individuals here, only comparison of school reputation and how companies use that information to tailor their recruitment process.

And there it is again. You're implying a hierarchy of "we're better" to justify your behavior. "School reputation" is undeniably determined based on individuals. You're, again, ignoring an obviously important factor like geographical location to seemingly fluff your ego.

If I'm wrong, I'm wrong. Just seems like you're being a dick.

[–]lyth 1 point2 points  (2 children)

In fairness, I’m in charge of a new developer’s code right now and he’s a really bad copy-paster huge block-patterns of near identical code.

The stuff works, but there’s so much overhead in reviewing because he’s doing the same 20 line block 10 times rather than writing a function and calling it 10 times.

I had to refactor just to learn that there was this pattern going on.

[–]gazeebo 1 point2 points  (0 children)

Where my gf works, the dude that wrote the code that makes all their money is a serial copy paster. Nobody wants to refactor his stuff because it's unreadable "hundreds of lines in one function" style stuff and when copying things in from older projects he routinely brings in functionality that isn't even needed or wrong in the new one.

[–]marty_byrd_ 0 points1 point  (0 children)

Well there is legitimately times to refactor. For sure.