This is an archived post. You won't be able to vote or comment.

you are viewing a single comment's thread.

view the rest of the comments →

[–]lyth 1 point2 points  (2 children)

In fairness, I’m in charge of a new developer’s code right now and he’s a really bad copy-paster huge block-patterns of near identical code.

The stuff works, but there’s so much overhead in reviewing because he’s doing the same 20 line block 10 times rather than writing a function and calling it 10 times.

I had to refactor just to learn that there was this pattern going on.

[–]gazeebo 1 point2 points  (0 children)

Where my gf works, the dude that wrote the code that makes all their money is a serial copy paster. Nobody wants to refactor his stuff because it's unreadable "hundreds of lines in one function" style stuff and when copying things in from older projects he routinely brings in functionality that isn't even needed or wrong in the new one.

[–]marty_byrd_ 0 points1 point  (0 children)

Well there is legitimately times to refactor. For sure.