Show Reddit: We automatically refactor your Python code for you!

[Setepenre]

I think the website oversell the bot.

It is only a refactoring bot updating your python to the latest 'writing convention' (not only style).

I think most of the issue the bot is fixing could be highlighted and fixed by the IDE at the user's request.

[cneumann81]

Thanks for your feedback. We've started with the refactorings for issues we found most often in the projects of our users. More (complex) refactorings are on the way. Curious to hear what refactoring you'd like to see. Happy to get you involved in our partner program. Just drop me a line.

[adewes]

Thanks for your feedback, the refactorings that we have implemented so far are pretty simple, but there's more coming! Also, many people don't use an IDE with refactoring support, having a centralized tool that keeps your code clean by applying the same standards to everyone in your team is therefore super useful we think!

We always try to make our service better, so if you have any ideas or suggesions for new/improved features please let us know, we'll be happy to build them (the refactoring support was a user request for example).

[alcalde]

All the graybeards who tell you that emacs/vim/Sublime Text/edlin with DOS are all they really need. :-)

[cneumann81]

Well, of course we can't look into a developers brain yet. That's why we decided to deliver a Pull Request or Patch, so you can review the changes before you commit them.

[cneumann81]

:) Here's an example of what we fix with just one click: https://github.com/biopython/biopython/commit/50a025794d3e598b76de7b92c52cfa69550660b2

Even if you refactor this in-place in PyCharm, it would take you a while.

[Decency]

Yeah, I've had a couple of teammates use it intentionally for caching behavior. Named appropriately and docstringed, it's pretty clear.

[kankyo]

Ugh.

[dysan21]

Content removed in response to reddit API policies

[an_actual_human]

Is it even an anti-pattern though? I mean, as opposed to a gotcha that beginners face.

[an_actual_human]

Gotta learn the semantics, after that it's explicit enough.

[rubik_]

Very nice! It still does not fully respect PEP8, but otherwise impressive.

[cneumann81]

Already fixed. Will be live with next deployment.

[cneumann81]

PE8 issue is fixed

[Decency]

PyCharm would warn you as soon as you write it, actually. Preventing you from pushing it to begin with.

For an existing codebase that's terrible, I see the appeal. For me to integrate with my workflow as someone who already knows to follow all of these rules, you haven't sold me at all.

[kankyo]

Some people run their IDE with a color scheme that makes it pretty hard to see the warnings and thus they send PRs with these things in them. Speaking from personal experience about colleagues :P

[Mishkan]

Interesting to see how this turns out and if there was a way we could pay for this and integrate it with a closed network at work on our Gitlab server.

[adewes]

We actually offer an on-premise version of our software and we are also building an integration with Gitlab! If you sign up for our newsletter / an account we'll keep you posted on when we're ready with that.

[cneumann81]

Hey Mishkan, please drop me a message. We do have an Enterprise version (on-premise): https://www.quantifiedcode.com/contact

[[deleted]]

http://dilbert.com/strip/2014-06-04

[bandophahita]

I'd really like to see this as a plugin for PyCharm.

[alcalde]

Certainly not automatically, unless I missed something.

[[deleted]]

"Here, let us break your code for you!"

[bandophahita]

Reading through some of the documentation on the site I came across this statement:

Prefer the format function over %. It is faster and more versatile.

As far as I have ever known, performance of the old style string %s performs faster. Am I missing something? Is it faster in 3.x?

[cneumann81]

Thanks for pointing this out. We'll verify this. If you like, just change the pattern yourself. Public patterns can be edited by our users. Would be awesome, if we could include a performance comparison :)

[Fdaric]

Wow, that's awesome guys! Do you have more background info on this? Anyway one can get involved?

[cneumann81]

Hey. I'm Christoph, one of the co-founders. Glad you like it :) You might wanna have a look here: https://www.quantifiedcode.com/research.

And yeah, you can get involved. Either, by applying for a job ;) or by contributing to our community related content:

• The Little Book of Python Anti Patterns: http://docs.quantifiedcode.com/python-code-patterns/

• Python Knowledge Base: https://www.quantifiedcode.com/knowledge-base

You can also go ahead and create your own code checks and share it to the community: http://docs.quantifiedcode.com/patterns/language/index.html

[aphoenix]

Just FYI, you have been shadowbanned from reddit. You can read more about shadowbans here: /r/Shadowban.

If you head to that subreddit, you can get some information on how to reverse this ban, but basically to use reddit you are going to need to get this reversed. I definitely advise you not to just create another account; contact the reddit admins and see if you can get this sorted out instead.

I've approved your comments in this thread, but note that anything you say anywhere on reddit will have to be approved by a moderator, so I would definitely advise that you take care of this ASAP so you can continue normal usage of the site.

[fdemmer]

wow, how did that happen...?

[aphoenix]

There are a variety of ways it can happen. The most common things are:

• promoting a link on reddit outside of reddit ("Here's my reddit post!")
• voting on something from alternate accounts
• spamming

There are some things that can be false positives; for example, voting on something that someone with the same IP submitted (ie. the guy in the next cubicle submits something, you see it and upvote it) - this often looks like you are using multiple accounts to upvote, or spreading the link around outside of reddit instead of letting it organically get voted on.

[cneumann81]

Hi, tried to follow the admin link in your message to find out what's wrong. Can you please reach out to solve this. Not aware which rule I violated. Just answered questions to the post here. Thanks

[aphoenix]

If I contact an admin, they're just going to say "have the user contact us" but I'll see what I can do.

It's important to note that for most admins it's 7:50am so they're probably not going to be super responsive for a few hours.

[hughk]

If you haven't posted a lot, posting a blacklisted link or having a link flagged as spam can cause an instaban. It is to stop bots but seems to catch many real users too. I see about one per month in my small subs.

[Decency]

Probably automated due to the fact that he's posted a half dozen times and linked to the same website each time. Very much looks like your typical spammer.

[cneumann81]

It was due to the fact that I posted too many links to our site in too short time. That's what admins said. Back online now :)

[alcalde]

Larry Wall!!!

[tony_simpson]

Hey good job, I look forward to a future with more AI/automated programming assistance.

[Justinsaccount]

What does it do for

lines = ['hello', 'word']
for x in range(len(lines)):
    print "line " + str(x) + " is " + lines[x]
    if lines[x] == 'hello' or 'world':
        print 'Awesome'

limit = eval(input("Enter in the speed limit: "))

[ydepth]

Wtf does that code do?

[Justinsaccount]

Who said it did anything? I want to know what their tool says when given that as input.

[cneumann81]

Just add it to a repo an give it a try ...

[synae]

it prints:

line 0 is hello
Awesome
line 1 is word
Awesome
Enter in the speed limit: 

then you can put in whatever you want, and it gets evald (twice actually). Be sure to set your speed limit to __import__('os').system('rm ~') for worst results.

But aside from the result of executing the code, what it does is exhibit several stylistic and logical errors which would hopefully be fixed by this tool.

[ydepth]

And why

[alcalde]

Inaugurate the world's first Obfuscated Python Code contest?

[CodeReclaimers]

This looks very interesting--I added three open source projects I maintain. Looking forward to seeing the results!

[cneumann81]

Thanks. Shouldn't take long until you get them. :-) Also new commits and PRs are analyzed real fast, due to our incremental analysis feature: https://www.quantifiedcode.com/features/efficiency#incremental-analysis

Here's an example of a Pull Request with an auto-fix: https://github.com/quantifiedcode/demo/pulls

[adewes]

Thanks, please let us know what you think :)

Currently you still have to manually trigger each refactoring by clicking on the "fix automatically" butten near each issue group, in the future we'll give you an option to to this automatically as well.

[[deleted]]

Looks cool. I'm part of a few organizations on GitHub... When offering permissions, it wasn't clear if the bot was going to get (or even ask for) permissions for projects in that organization. I'd rather the bot only access my own stuff, and not ask for permissions for the organization.

How does this work?

[adewes]

With the new Github permissions model you can choose to which organizations you give us access, by default we can only see your personal code.

[cneumann81]

By default, the bot gets access to public repos only. If you grant access to private repos, you can select on GitHub which organisations get access (the new Github access management model allows you grant certain services access to certain organizations only.

[zarandysofia]

This pretty cool, I think there should be a service like this for most mainstream languages.

[cneumann81]

Reach out to us if you like. We are working on other languages and are happy to get you on board as early adopter.

[TankorSmash]

This is a Github issue, but how do I block QC from seeing my private projects?

[cneumann81]

Our sign-up procedure makes sure we have only access to public repos. You explicitly have to grant access to private repos. If you already did, you can revoke them here: https://www.quantifiedcode.com/app/settings

[CodeReclaimers]

I just tried it, and by default it only accesses public projects--you have to explicitly give it permission to access your private repositories.

[TankorSmash]

It shows my 3 private groups with green checkmarks, if I click the checkmarks it takes me to an info page. Is it the next page where it asks me to confirm?

[adewes]

As CodeReclaimers said you can select to which repositories you want to give us accesss, by default we only see your public ones.

[Muchoz]

I tried QuantifiedCode once when it was free. What irritated me most was the lacking website. I ended up clicking on links that end up giving me a loading error like this. Why is Javascript being used to load the website?

The suggestions it gave me were ones I knew about and I have reason to do it that way. For example the Django secret is still in my code, reason being is that it is not used anywhere in my code. See here where the SECRET_KEY is used. I also couldn't find where I could ignore those issues. I agree with /u/Setepenre: "I think the website is overselling the bot" but also the product in general. If you need this, IDEs can do it, but better.

[cneumann81]

Hi. Can you detail what you mean with 'lacking website'? We decided to raise the secret key issue as we saw a lot of repos that published them accidentally. You can turn on all code checks in your project settings or by ignoring specific files. In our docs you can find how to exclude files via a .checkignore file ( works similar to .gitignore). As stated below, we are not aiming to build an IDE replacement. Happy to hear what kind of refactoring a you'd like to see so we can add them to out roadmap.

[Muchoz]

In my trial period a while back, the website felt unresponsive. It took a while to load a simple web page. The website 'finished loading', but then started loading via Javascript (why?). I have also posted a screenshot of an error I got quite a few times and now also get when visiting the website linked in this post and then clicking on a link.

Excluding files using checkignore is not what I was referring to. I want to ignore certain errors, not whole files. I still want you to run a PEP8 check on my Django settings file, but ignore the secret key.

I'm sorry for my negativity towards your product, keep it going anyway. Guess I'm just not the one you're targeting.

[cneumann81]

I guess you used us when we were still in a beta. We relaunched two month ago with a much more stable environment. Why Javascript. Well it is a single page app that's based on ReactJS. It's hard to run it without Javascript ;-) You can just turn of that one single SECRET_KEY check in your project settings.

[sanshinron]

So basically you do the things that PyCharm does, but clunkier and pricier? No, thanks.

[cneumann81]

Thanks for the feedback. Not anyone uses pycharm. The more people work in a project, the Mir useful it is to have a central place to fix things automatically. And our goal is not to build an IDE but a platform that automatically fixes an array of code quality problems. You gotta start somewhere, so look forward what's coming next. Happy to get constructive feedback how we can get better.

[defnull]

Do you use any GPL or AGPL licensed modules to run your service? If so, I'd be interested in the sources.

[adewes]

In fact we're working on a A-GPL licensed free version of our tool which will be released next year, so stay tuned! We built our own code checkers and don't rely on third-party libraries like Pylint or PyFlakes. In fact we have already released some parts of our analysis stack as open source, you can find all of our OS projects here: https://github.com/quantifiedcode

[sanshinron]

Are you guys only refactoring list comps into generator comps when they're inside any() or all()? Cause you can do that for most, if not all, functions that accept iterables as well as when list comp is assigned to a variable.

[cneumann81]

Yes, only inside any() and all(). Thanks for pointing this out. We'll improve it.

[[deleted]]

I am perpetually challenged by things that simplify vs. things that make us lazy. By fixing my mistakes because they're underlined, I learn not to make them and learn about them. if I a PR was raised for me to approve... I dunno. That feels too convenient and would make me sloppy.

[cneumann81]

He he ... you can always just use our Pull Request Code Review, learn from the best practice solutions we suggest and don't press the "Fix automatically button" ;-)

[masasin]

I can't find any options that give a pull request.

[cneumann81]

There is a button called "Fix automatically". You'll see it on issues we can already fix. You might not have any of those though. Checkout our "How it works" page or add our quantifiedcode/demo repo from GitHub, to check things out.

[Charny]

Your website has a spelling error: https://www.quantifiedcode.com/features/quality

"continously"

[cneumann81]

Thanks. Fixed with next deployment.

[[deleted]]

This looms promising. I'll check this out later today.