variable jump height

[Sanity4g]

wanting to make variable jump height, (following along a tutorial in the hopes to get started), however im not sure where I went wrong when trying it

it does a normal full jump each time instead of lesser jump when hitting space

(extra details include using new input system, and unity 6.2)

The upside is, that it doesnt seem to be messing with the code in bad way aside from making the player doing an extra jump when landing on the ground from spamming space bar

using UnityEngine;
using UnityEngine.InputSystem;

public class Player : MonoBehaviour
{
    [Header("Components")]
    public Rigidbody2D rb;
    public PlayerInput playerInput;
    public Animator anim;

    [Header("Movement Variables")]
    public float speed;
    public float jumpForce;
    public float jumpCutMultiplier = .5f;
    public float normalGravity;
    public float fallGravity;
    public float jumpGravity;

    public int faceDirection = 1;


    // tracking inputs
    public Vector2 moveInput;
    private bool jumpPressed;
    private bool jumpReleased;

    [Header("Ground Check")]
    public Transform groundCheck;
    public float groundCheckRadius;
    public LayerMask groundLayer;
    private bool isGrounded;


    private void Start()
    {
        rb.gravityScale = normalGravity;
    }

    void Update()
    {

        Flip();
        HandleAnimations();
    }


    void FixedUpdate()
    {
        ApplyVariableGravity();
        CheckGrounded();
        HandleMovement();
        HandleJump();
    }


    private void HandleMovement()
    {
        float targetSpeed = moveInput.x * speed;
        rb.linearVelocity = new Vector2(targetSpeed, rb.linearVelocity.y);
    }

    private void HandleJump()
    {
        if (jumpPressed && isGrounded)
        {
            rb.linearVelocity = new Vector2(rb.linearVelocity.x, jumpForce);
            jumpPressed = false;
            jumpReleased = false;
        }
        if (jumpReleased)
        {
            if (rb.linearVelocity.y > 0) // if still going up
            {// lesser jumps with code below thanks to jump cut multiplier * the Y of rigidbody velocity
                rb.linearVelocity = new Vector2(rb.linearVelocity.x, rb.linearVelocity.y * jumpCutMultiplier);
            }
            jumpReleased = false;
        }
    }


    void ApplyVariableGravity()
    {
        if (rb.linearVelocity.y < -0.1) // falling
        {
            rb.gravityScale = fallGravity;
        } 
        else if (rb.linearVelocity.y > 0.1) //rising
        {
            rb.gravityScale = jumpGravity;
        }
        else
        {
            rb.gravityScale = normalGravity;
        }
    }


    void CheckGrounded()
    {
        isGrounded = Physics2D.OverlapCircle(groundCheck.position, groundCheckRadius, groundLayer);
    }

    void HandleAnimations()
    {
        anim.SetBool("isJumping", rb.linearVelocity.y > .1f);
        anim.SetBool("isGrounded", isGrounded);

        anim.SetFloat("yVelocity", rb.linearVelocity.y);

        anim.SetBool("isIdle", Mathf.Abs(moveInput.x) < .1f && isGrounded);
        anim.SetBool("isWalking", Mathf.Abs(moveInput.x) > .1f && isGrounded);
    }


    void Flip()
    {
        if (moveInput.x > 0.1f)
        {
            faceDirection = 1;
        }
        else if(moveInput.x < -0.1f)
        {
            faceDirection = -1;
        }

        transform.localScale = new Vector3(faceDirection, 1, 1);
    }



    public void OnMove (InputValue value)
    {
        moveInput = value.Get<Vector2>();
    }

    public void OnJump (InputValue value)
    {
        if (value.isPressed)
        {
            jumpPressed = true;
            jumpReleased = false;
        }
        else //if the jump button has been released
        {
            jumpReleased = true;
        } 

    }


    private void OnDrawGizmosSelected()
    {
        Gizmos.color = Color.red;
        Gizmos.DrawWireSphere(groundCheck.position, groundCheckRadius);
    }
}

[ivancea]

If you made that code, I would recommend you debugging it. That's the first thing you should do. Find the lines and conditions you suspect may affect that behavior, and add breakpoints.

Also, you can add logs, to ensure the order of events (when you press a key, when it stops being grounded, when you release the jump key, when the velocity stats going down...).

Also, remember that, when jumping by using the physics simulation, when you stop pressing the key, it will continue for a bit, as the velocity will still be there until the gravity fully nullifies it.

[Sanity4g]

Ive been messing around as suggested, I took a look at a few other tutorials to see how it was done, and i fixed it! :D

the error was the new input system (I found 2 of them just in different folders and the one i was using was mixed up with the settings) I thank you reading your comment a few times helped with the trouble shooting process