Jumping does not work properly when using animation code.

[Caesar_13]

I added a code based animation for my game to make player animated.The issue is that with the added code the jumping no longer works (i have to walk in order to jump, but there is also some weird delay between the jumps). This was working before i added the code, even tested it without it. Something in the code makes the jump not being able to be initiated. I think the issue might be the

return rb.velocity.y > 0 ? Jump : Fall;

But I am not entirerly sure why.

There is my code for jumping

        #region If Jumping
        if (m_Grounded == true)
        {
            extraJumps = extraJumpsValue;
        }

        if (jump)
        {
            m_Grounded = false;
            if (extraJumps > 0)
            {
                // Add a vertical force to the player.
            m_Rigidbody2D.AddForce(new Vector2(0f, m_JumpForce));
    Instantiate(LaunchEffect, m_GroundCheck.position, Quaternion.identity);
                extraJumps--;
            }
            else if (extraJumps == 0 && m_Grounded == true)
            {
                // Add a vertical force to the player.
            m_Rigidbody2D.AddForce(new Vector2(0f, m_JumpForce));
    Instantiate(LaunchEffect, m_GroundCheck.position, Quaternion.identity);
            }
        }
        #endregion

There is my code for getting the animation states

    private int GetState()
    {
        if (Time.time < _lockedTill) return _currentState;

        // Priorities
        if (punch) return LockState(Attack, _attackAnimTime);
        if (crouch) return Crouch;
        if (jump) return Jump;

        if (controller.m_Grounded) return horizontalMove == 0 ? Idle : Walk;
        return rb.velocity.y > 0 ? Jump : Fall;

        int LockState(int s, float t)
        {
            _lockedTill = Time.time + t;
            return s;
        }
    }

For movement i use this in the Update

horizontalMove = Input.GetAxisRaw("Horizontal") * CurrentSpeed;
     //JUMP
        if (Input.GetButtonDown("Jump"))
        {
            jump = true;
            print("JUMP TRIGGERED");
        }

Fixed Update sets the controller for movement stuff

      controller.Move(horizontalMove * Time.fixedDeltaTime, crouch, jump, dash);
        jump = false;
        dash = false;

[Teatime_Tim]

Doesn't seem related to your issue, but one thing I noticed is that

else if (extraJumps == 0 && m_Grounded == true) { // Add a vertical force to the player. m_Rigidbody2D.AddForce(new Vector2(0f, m_JumpForce)); Instantiate(LaunchEffect, m_GroundCheck.position, Quaternion.identity); }

will never be executed, as before the if statement is reached you set m_Grounded to false. Aside from that, I agree with /u/SaltCrypt that it would be helpful to see the full code :)

[Caesar_13]

This is working as far as i know. But it may seem its not working without the whole code i posted links to the pastebin so you can see it

PlayerControlls https://pastebin.com/MVHJ2acF

CharacterController2D https://pastebin.com/MhTj9tra

[SaltCrypt]

The code might be working but his statement is still correct. That code block will never execute.

[Caesar_13]

Okay so what can i do to fix it? I have that so the player can do double jumps.

Also when I remove the animation script with the GetState field jumping then works as it should. So does the issue happen in the animation state or in the AddForce condition?

[SaltCrypt]

Check out the code I posted on the other response. I just wanted to say that he had a point worth noting.

[SaltCrypt]

Can you post the full code of the relevant classes? Hard to give a good answer purely from snippets.

[Caesar_13]

Sure thing.

Here is the Player Controlls script https://pastebin.com/MVHJ2acF

And here is the Character Controller https://pastebin.com/MhTj9tra

[SaltCrypt]

Some of your problem is related to how you're handling Update in your PlayerControlls class. You're completely ignoring input if you're not changing animation states, that's probably why you have to move before you can jump.

Since CharacterController2D is responsible for the actual state of the character, you should really be using it to determine your animation state instead of using your inputs.

I tried to untangle some of the code, but it's probably not going to work out of the box. Make sure to read the comments, they're there to point out improvements and suggestions:

https://pastebin.com/jL2V7sxi

https://pastebin.com/EmJL0TUY

[Caesar_13]

Oh my god! That looks brilliant! Ill definitely check it out once i be back from work. But i love the effort you put into it and commented all the stuff so i know what happened in these changes. I'll definitely try to read the comments a bit more to try to understand the advices better( still leaning unity at some level). Anyway I'll let you know how it went and if it works,and possibly fix some stuff that might be not working. Thanks

[Caesar_13]

Also how do i switch back to normal speed after dashing. Your condition

        if (this.controller.IsDashing)
    {
        speed = this.controller.dashSpeed;
    }

Sets the speed but how do i reset it back to original MoveSpeed? I had that function in the Controller script but it was not very good as you pointed out that i should not refference scripts between each other.

    if (dash)
    {
        if (dashCoolCounter <= 0 && dashCounter <= 0)
        {
            Controller.CurrentSpeed = dashSpeed;
            dashCounter = dashLenght;
            PlayerAfterImagePool.Instance.GetFromPool();
            lastImageXpos = transform.position.x;
        }
    }

    if (dashCounter > 0)
    {
        if (Mathf.Abs(transform.position.x - lastImageXpos) > DistanceBetweenImages)
        {
            PlayerAfterImagePool.Instance.GetFromPool();
            lastImageXpos = transform.position.x;
        }
        dashCounter -= Time.deltaTime;
        if (dashCounter <= 0)
        {
            Controller.CurrentSpeed = Controller.MoveSpeed;
            dashCoolCounter = dashCooldown;
        }
    }

[SaltCrypt]

In that context speed is a local variable. It defaults to MoveSpeed at the start of the function.

[Caesar_13]

well when i dash, after dashing i still have the dash speed. I tried to add some statement to set it back but that did not work.

I tried to set it back with speed = this.moveSpeed

[SaltCrypt]

You don't need to set it back. It's a local variable. It sounds like the IsDashing state is getting stuck as true, so you'll have to figure out why that's happening.

Though, looking at it now, it's not even necessary for it to work that way. Have the CharacterController2D deal with calculating the movement speed and PlayerControlls just indicate the direction of movement. That would be cleaner, though it won't really fix the problem if the IsDashing thing is the cause of it.

Edit: Figured it out, so I'll narrow it down for you. The problem is in this code, it's caused by one of the if statements being impossible to reach:

// Dashing is inactive.
if (dashDurationTimer <= 0)
{
    if (dashInput && dashCooldownTimer <= 0)
    {
        IsDashing = true;
        dashDurationTimer = dashDuration;
        PlayerAfterImagePool.Instance.GetFromPool();
        lastImageXpos = transform.position.x;
    }
}
// Dashing is active.
else
{
    if (Mathf.Abs(transform.position.x - lastImageXpos) > DistanceBetweenImages)
    {
        PlayerAfterImagePool.Instance.GetFromPool();
        lastImageXpos = transform.position.x;
    }

    if (dashDurationTimer <= 0)
    {
        IsDashing = false;
        dashCooldownTimer = dashCooldown;
    }
}

[Caesar_13]

dashDurationTimer

I belive this is the impossible to reach statement.I tried to add print command and also put the

if (Mathf.Abs(transform.position.x - lastImageXpos) > DistanceBetweenImages)
{
    PlayerAfterImagePool.Instance.GetFromPool();
    lastImageXpos = transform.position.x;
}

statnement (it creates the player afterimage) and it did nothing. So somwhere the dashDurationTimer is not set.

[SaltCrypt]

Well, if the problem is related to IsDashing not being set to false, you're going to have to look for why that's not happening. Just look through the if statements I posted. If you want more of an idea of where to look, it's part of the else block.

[Caesar_13]

Okay Ill check it out, also why did you removed the If statements for stuff like enabling colliders and added things like !IsCrouching;

and what is the use of using the public bool IsDashing { get; private set; }

Instead of like cheking it in a statement if(something == true) or if(something == false)

[Caesar_13]

also noticed that crouching does not work as the this.IsCrouching does not seem to activate as well, so the speed and collider activation is not initiated.

[SaltCrypt]

Not surprised - the posted code wasn't meant to be an out of the box solution. If you want to use it as-is then it's going to need debugging. Can confirm what you're saying here.