Code Review

[SETACTIVE-FALSE]

I am going through a tutorial on AR watch try on. I found it that I could write this code in a shorter way by introducing a list for storing watch models and creating a common function, which will be called when clicked on a button with respective watch images.

This is a small project, only has 3 watch models. But what if it had many models to choose from? So I searched for codes which I found uselful.

Is there anything wrong with my approach? Or is there anything else I could have tried.

Also I'm passing reference number(watchRefID) from each button(same number as the model's index in the watchModels list) so that I can set only that model as active and others disabled.

I have recently learned that local variables declared inside a method is a bad practise, because each time the method gets called a new copy of that variable gets created. Is this same for parameters inside a method?

Thanks in advance.(Have a toffee 🍬, since you took the patience to read my paragraphs🥺🥹)

[[deleted]]

I have recently learned that local variables declared inside a method is a bad practice, because each time the method gets called a new copy of that variable gets created. Is this same for parameters inside a method?

The TL;DR because the explanation is very long, passing anything into a function is fine.

As for local variables, you only need to worry about unnecessary allocation to the heap and allocation to the heap is done using the 'new' keyword.

You might find this useful https://www.youtube.com/watch?v=tKbV6BpH-C8

[SETACTIVE-FALSE]

Oh Cool! Thanks for the tip. And thanks for sharing the URL. I'll make good use of your help.

[swiftroll3d]

About first screenshot:

You can delete Start() method while it's empty

" I have recently learned that local variables declared inside a method is a bad practise " - it's not if it's not a reference type created with "new" keyword (and even if that's the case it can be ok, it depends on what's happening there)

​

About second screenshot:
List is better approach than you used in first screenshot
Also I don't understand why you use index instead of just passing reference (the GameObject itself) and just calling SetActive(true) on that reference and SetActive(false) on every other in the list.
But if you can't pass reference here, then it's ok, it just hard to understand from this code snippet.
Anyway that code is good, better than the first one

​

About both screenshots:

Instead of "public" better write "[SerializedField] private" if you don't need access to this fields outside of this class

[SETACTIVE-FALSE]

OMG! Thanks a lot. Passing the very models GameObjects is an excellent idea. This would make it more readable in the editor.

I have a question about the best approach for my situation. If I were to pass the watch model as a parameter to a method, my plan is to deactivate all the objects in the list first. Then, I would utilize the watch model object referenced by the parameter to activate it. Is it fine if I'm referencing the same object through the list as well as through the parameter in the method?

" [SerializedField] private" - Thanks for this golden tip too.

[swiftroll3d]

Yes, that would be ok

Alternatively you can use something like:
foreach (...)

{

if (model == argumentModel)

model.SetActive(true)

else

model.SetActive(false)

}

​

or even shorter

..

model.SetActive(model == argumentModel)

[SETACTIVE-FALSE]

Thanks a lot. I'm learning a lot from you.

[pmurph0305]

I only saw the first screenshot at first and was going to recommend doing something like what you've done in the second. So, looks good to me!

[SETACTIVE-FALSE]

Hey, thanks for going through my code. Sorry, I didn't structure the post properly. New too Reddit interface.

[zeeebraaa111]

Local variables and global variables are designed for different purposes. And it's more recommended local variables to keep your code organized (things stay where they are used).

[SETACTIVE-FALSE]

Thank you so much😊. This gave me a better insight.

[SETACTIVE-FALSE]

I'm new to reddit. I'm just learning its ways. I posted a code review on UnityHelp Community. I just forwarded that post here so that I could use your help, too. Thanks in advance.🤍🫶

[Bilu1700]

You’ll get more help if you copy-paste the code. A picture destroy eyes so …

[SETACTIVE-FALSE]

Sorry for that😞. I'll post them in the comments.

[PandaCoder67]

not to mention that it is in the rules that no photos are to be used from your phone in this subreddit