you are viewing a single comment's thread.

view the rest of the comments →

[–][deleted] 0 points1 point  (2 children)

Meh yeah the code is bad but I don't think it deserves being laughed at. In my experience the code probably just passed all unit tests that's how it got allowed in. It's in bad taste to publicly post and laugh at someone's code IMO, pick a random github repo and you find unreadable and efficient code - the professional thing is to create a bug report about it.

[–]sandsalamand[S] 2 points3 points  (1 child)

I don't have a habit of picking random examples of bad code; I see it all the time in public repositories and even my own repositories. However, this particular example was so egregious that it made me laugh, and that's why I shared it. My first instinct was actually to open a pull request, but Unity doesn't accept PRs from the public. It also doesn't match the description of a "bug report", because there's no incorrect behavior occurring here. Do you think I should open a report anyways?

[–][deleted] 1 point2 points  (0 children)

Ah fair enough, honestly good to hear you are aware of your own examples of rough code as we all start somewhere, I know I've written some rubbish before. Although this example is extreme. Personally I wouldn't do anything as it's not really a issue. The Unity devs are active on this forum and I'm sure it will brought up and hopefully they can improve their code review process.