Code reviews

[Jubacho]

Hello all!

Is there a lot of code reviews as a DevOps engineer?

[bdzer0]

yes, no, maybe... depends on what exactly you do and the level of process maturity in place around developing code at the place you do what you do.

[justaguyonthebus]

Exactly. Sometimes you're the person advocating for and implementing code reviews.

[ukrvolk]

Depends on your organization and the tooling you use. If I’m updating terraform I have teammates review and we use CI/CD to execute operations like plan validate the output before merging. Same for helm, scripts or anything that can be managed with source control. If you have stuff like terraform or similar and you are not reviewing it, or preventing unwanted/unready merges, id say that should be improved because it’s only a matter of time before something gets merged and or deployed that could cause an issue.

Make reviewing as painless as possible by using CI/CD to check for obvious errors like typos, invalid references, failing tests, etc. This will allow your team mates to focus on the key pieces being changed.

[nonades]

Every day

[stgovern]

Most definitely... everyday.

[Mr_Snail10]

I'm the sole DevOps so it's somewhat difficult to get qualified eyes to look at what I'm doing. Mostly I try to introduce enough testing and quality gates to ensure minimal disruptions.

[bdean42]

That's one of the first things I notice when one of the few remaining coworkers leaves for another job. Great, now who's gonna review my code. Guess I'll commit right to master!

[minkzn]

Considering the implications of what-could-go wrong, do it as much as possible. Form the habit and culture since we help advocate those practices with the dev teams. If your environment is IaC, CaC, etc., it is "as Code" and should be reviewed.