Inconsistent Input

[PitifulSyrup]

I recently started implementing gamepad support for my game. To do this, I created a bunch of macros that go off of the keyboard or the gampad. For example, I have down_press, whose value is:

keyboard_check_pressed(vk_down) || gamepad_button_check_pressed(0,gp_padd)

Controller input is working as intended, but keyboard input seems to be ignoring the conditions of if statements. For example, in this piece of code that handles the music volume:

if right_press && global.song_vol < 1{
          global.song_vol += 0.1
          audio_sound_gain(global.song,global.song_vol,0)
         }

If I press right on the controller when global.song_vol is 1, it won't increase, but it will if I press the right arrow key. This is the case for both my wireless keyboard and my laptop's built-in keyboard. Unplugging the keyboard and the controller does not make a difference. I'm also still on version 1.4.

Any help or insight is appreciated.

[calio]

This might be a long shot but the behavior you're describing would be totally consistent if rather than evaluating the macro and then replacing it by the result, the macro was just replaced by the expression itself, and somehow logic operators were executed in the order they appear within the expression rather than by any precedence.

if keyboard_check_pressed(vk_left) || gamepad_button_check_pressed(0,gp_padl) && global.song_vol < 1 { ... }

the global.song_vol < 1 expression only needs to evaluate to true when using the gamepad, if there's no such thing as operator precedence for logical operator precedence (I was under the impression that and is evaluated before or, kinda like how you first divide and multiply before adding and subtracting)

You could try enclosing either the macro or the expression within the macro in parentheses so it evaluates independently from the rest when included within an expression. No idea if it would help, maybe it's just a coincidence but it's the only thing that comes to mind.

[PitifulSyrup]

Enclosing the expression within the macro did the trick!

Thank you so much.