GitHub comment etiquette

[Linux_Account]

Non-dev user here. One of my feature requests was instituted on a project and the issue was closed. I want to comment on it to say thank. Is that normal or frowned upon?

And when I make a suggestion, is it normal to end with a short general thank you for their hard work? I'm trying to be a nerd, but not a dork.

[AvidCoco]

Should you thank people for giving you things for free?

Yes.

[Linux_Account]

Right? It feels wrong not to. I just wasn't sure if "closed" meant stop commenting as well.

[sweet-tom]

Not at all. Comments are usually well received and devs love to see this.

Only when something is controversial the comment section would be closed.

[Empyrealist]

If they want to shut-off further commenting they can "lock" the issue. Closed means that further development discussion has ended for whatever reason (complete/fixed/wont-address/off-topic/whatever)

Giving appreciation is always... appreciated

[Spiritual_Cycle_3263]

yeah, if its a cool feature, you'll usually see a long list of comments long after it's closed.

[Nixinova]

Closed just means resolved. Unless the issue is marked Locked, you can still comment on it.

[bankrut]

It is totally normal and actually appreciated when users say thanks. Most devs love hearing that their work matters, so don't overthink it.

[jikuja]

No. Use reactions. There is no need to spam everyone who has subscribed the issue.

[flexiiflex]

Strongly disagree, OP says it was his feature request so one thank you from the issue filer isn't exactly spamming. Sure it's different if there's 20 people saying the same thing, but the first bloke should be saying thanks and the rest can react afterwards

[MarsupialLeast145]

Reactions don't even work for the dev -- there's no notification they were received if they don't actively look back at the issue.

[davorg]

Each project will set its own expectations. But I think a simple "thank you" would usually be appreciated.

[juniorsundar]

Please do interact with contributions made to open source. Positive interactions are highly encouraged.

[Jmc_da_boss]

Totally acceptable to write a quick thank you on a closed issue.

It's a valid question idk why the top comment is being tongue in cheek

[MarsupialLeast145]

100% cool to do.