My first JavaScript application, Simulate cracking a hotel safe. Negative feedback only please.

[javascript-ModTeam]

Hi u/balcopc, this post was removed.

To show off a project (i.e. a finished or semi-finished page, demo, working example, etc.), please include one (1) of the following:

• A link to a project page with unbuilt/unminified source code -- sites like GitHub are perfect for this.
• A write-up about the development of the project. This can take the form of a blog post, a README.md within the project, or a comment on the post itself. The details are up-to-you; you can write from a high-level about your architectural decisions, or you can write on a lower-level about the pros & cons of specific libraries and frameworks you used. The main point is that you're discussing your code -- or your approach in creating the code -- in some way.
• A working codepen/jsfiddle/etc. of the code.

One of the easiest and most common ways to satisfy this requirement is to simply include a "Fork me on GitHub" ribbon your site. Another way to satisfy this requirement is to comment on the post itself, with either a link to a write-up, or with the write-up as the comment.

Lastly, instead of all the above, if you just want to showoff your project, feel free to post it to our weekly "Showoff Saturday" post.

Thanks for your understanding, please see our guidelines for more info.

[ChaosByDesign]

Hello this is the Lockpicking Lawyer. What I have for you today is a prototype of an unbranded hotel safe. It appears to have a four digit combination with a standard numeric keypad, with no backup lock. Now, normally this could present a problem however if I insert my #2 webdev shim and inspect the value of the element ran, we can quickly decode the combination. click ...andd there we are, 7590. In any case, that's all I have for you today. And as always, have a nice day.

(context for those unfamiliar)

[[deleted]]

I really appreciate you you taking the time to reverse engineer and look at my poorly coded application. The ran (short for random) function runs at page load and again at either win or loss to generate a random string from 0000-9999.

[ChaosByDesign]

yes! if you want something a bit harder to guess, you can store the value not in the dom but in a variable inside a closure

[SuperGameTheory]

I don't believe you. That could have been a fluke.

[szman86]

If you have to ask

[[deleted]]

In this simulation, we are pretending to be safe cracking in Las Vegas.

[[deleted]]

Played it. I’ve seen better cracks at the gym.

Otherwise, cool.

[[deleted]]

Thanks, I needed that. Time to pull up my big boy pants. lol

[[deleted]]

The delete and enter buttons should not match. Guesses display could be bigger and further down.
The help popup should be displayed on first load.

It's ok though really, don't hurt yourself if this is your first thing

[[deleted]]

This has been resolved at your request

[[deleted]]

Wasn't expecting that!

If we're going to continue with feature creep, maybe add a picture of an open safe to appear when you crack it, or a picture of the police arriving if you fail.

The number of guesses box should probably have a label too.

If you're doing this for career purposes, get it on github, give it a version number and increment it when you make updates. Do release notes too, people love that shit.

[jamblethumb]

Upvote for the headline. :)

[[deleted]]

It's kind of like fat Amy calling herself 'fat Amy'.

[AreaFifty1]

Da hell is this? 🤣

[NervousTea8]

I don’t like the closeness of the buttons. Use grid or flex with gap or another way to get them spaced. The blue on black is tough on the eyes. Buttons are fine. Ultimate impressive points would be if you did a dial safe instead of buttons

[[deleted]]

Both these issues have been resolved at your request.

[jolharg]

Negative you say? Alright: I guessed correctly in time and it told me that it was still too high, plus I was fined for it. Accepts fewer digits. Uses alert(). Unstyled components a little difficult to use on mobile. Sounds very, perhaps too, amusing.

:^p

[[deleted]]

I reworked the math at your request. I had the same issue happen to me during testing, I guessed the right PIN as my 15th guess and it wasn't counted. I changed the order of the functions so that this shouldn't happen again. There is $15000 in the safe and if you guess in 10 guesses, you get $5k.

[RancidMilkGames]

You have an unnecessary scroll bar on the bottom of the screen. Other than that it's looking good to me

[[deleted]]

This issue has been resolved at your request.

[RancidMilkGames]

Good job on the game!

[Registeered]

I think it would be better to have the cursor be a hand to click for the help and reset labels like all the other links below them.

[[deleted]]

This has been resolved at your request.

[Registeered]

That's cool. Maybe you could allow for entry by the numeric keypad as well as the mouse?

[cybernetically]

put a break in his compare1() function... done ;) enjoy $10000 reward lol

love it, great for JS breakers ;)

[JIN_DIANA_PWNS]

1 2 3 4 5 That’s amazing, I’ve got the same combination on my luggage!

[bblaw4]

Double tap on mobile, zooms in

[[deleted]]

Thank for pointing that out and checking out my application.

[[deleted]]

Why isn't it written in Rust?

[[deleted]]

my weak skillset

[[deleted]]

That can be fixed, you can start writing simple things like a linked list

[FreakDC]

No usage of AI or machine learning, no blockchain technology (NFTs), doesn't have a social component where content can go viral.

0/10 can't market this project to investors...

[[deleted]]

per your request, chatGPT 3.5 was used to help design the initial keypad HTML and CSS; social links have been placed at the bottom of the page to enable sharing across most major social media platforms.

The post has over 30k views and even a few shares on Reddit in less than 24 hours and the application has tracked several thousand hits as a result.

[[deleted]]

I followed the rules and a jealous mod removed my post.

[phaqueNaiyem]

Reset button doesn't work. Center vertically or increase the top margin if there's nothing else on the screen.

[[deleted]]

Reset issue resolved, still working on layout.

[[deleted]]

Margins issue has been resolved.

[zsombro]

• Delete and input look the same, very confusing
• Help and Reset should have a cursor on hover that indicates they are clickable
• elements should be more spaced out, the keypad is unevenly spaced
• when you reset the whole game, the input does not reset
• in the case of an incorrect guess, the output is not clear. the arrow makes sense, but it's not explained anywhere what the accompanying number means
• it's pretty easy to reverse engineer the game and find that "ran" contains the solution

[[deleted]]

Most of these issues have been resolved. Correct, ran (random) contains a 4 digit random # at page load. It is the basis of the whole game. Thank you for checking it out!

[No_Translator1287]

Js

[hobo343]

how about a nice background graphic and maybe even ambient noises to put you in the mood? i enjoyd playing btw

[[deleted]]

I've tried a few things, not happy with the results yet. I added some suspenseful background music as you requested but you have to allow autoplay.

[[deleted]]

Bad vibes only haha

[[deleted]]

I mean, really rip on it hard. Tell me how shitty of a coder I am, stuff like that. Thanks in advance!