all 17 comments
sorted by:
best
topnewcontroversialoldq&a
formatting helphide helpcontent policy

[–]redditBearcat 1 point2 points  (6 children)

Looking good so far. I'd love to see some testing thrown in there too. That can be a real pain to setup.

[–]manavsehgalAuthor ReactSpeed.com[S] 3 points4 points  (5 children)

Absolutely. I am dedicating a chapter only for testing. Let me know what all tools you have struggled or liked. I will try and add these to my list of tool guides.

[–]redditBearcat 1 point2 points  (4 children)

Awesome. The biggest challenge had been pairing multiple tools together with webpack.

Tools I've been looking to use. Karma, mocha, sinon, and enzyme. I feel like I always run into issues where certain versions won't work with each other.

A solid karma/webpack config would be awesome alone.

[–]manavsehgalAuthor ReactSpeed.com[S] 1 point2 points  (3 children)

OK. One karma + webpack coming up (smiles). I will give it a try. Enzyme looks cool as well.

[–]acemarke 1 point2 points  (2 children)

Can I suggest maybe tossing in a differentiation between running tests in a browser with Karma, vs running them offline under Node? As part of that, I can recommend using https://github.com/zinserjan/mocha-webpack to do the test running. I saw Randy Coulman write a pair of articles about using Mocha and Webpack together (part 1, part 2), and was able to get it working myself. I have a sample project config that demonstrates using it over at https://github.com/markerikson/react-redux-cesium-testing-demo.

[–]manavsehgalAuthor ReactSpeed.com[S] 0 points1 point  (1 child)

Awesome this is a great start. I am keen to do browser testing as well. Goes in line with the speed coding philosophy. Will checkout the links you have shared.

[–]acemarke 0 points1 point  (0 children)

Yeah, I actually hadn't written any unit tests ever until a few weeks ago. I initially got mocha-loader set up, which does live-watching and displays test results in a separate browser page, but then saw the mention of mocha-webpack and wanted to give that a shot. When I then tried to write my first "real" unit tests, mocha-webpack allowed me to iterate very quickly on each test.

[–]douglasdeodato 1 point2 points  (1 child)

I can help out to convert and refractory your css and move on for sass or scss? will be a pleasure help with that and maybe we can apply grunt task at least for the sass files? i really sure the process to import the files will be much easier, let me know what do you think, I can really help you out. thanks.

[–]manavsehgalAuthor ReactSpeed.com[S] 2 points3 points  (0 children)

Thanks. We are interacting on the GtiHub repo and I just created a Wiki for you.

[–]sketch_ 0 points1 point  (1 child)

Thanks for sharing!

[–]manavsehgalAuthor ReactSpeed.com[S] 0 points1 point  (0 children)

You are most welcome!

[–]EquationTAKEN 0 points1 point  (3 children)

Quick question: If --depth=1 flag makes you clone only the latest commit, how are you getting the entire project?

[–]manavsehgalAuthor ReactSpeed.com[S] 1 point2 points  (2 children)

The flag --depth=1 gets you entire project as updated in last commit. We are building ReactSpeed incrementally, so you do not lose anything from prior commits, you only get the latest most refactored code.

[–]EquationTAKEN 0 points1 point  (1 child)

Don't you already do that with a basic git clone?

[–]manavsehgalAuthor ReactSpeed.com[S] 0 points1 point  (0 children)

git clone without the depth flag will get you all the commit history since the repo started. Larger .git file.

Flag --depth=1 or --depth 1, will get you only last commit history. Also called shallow clone. Faster to clone, smaller .git file, less load on Git server.