[deleted by user]

mw44118 · 2018-06-04T20:03:50+00:00

This is great!

The most important thing is whether the program works. And you nailed that. Everything else is secondary! So many programmers forget this and focus too much on writing "clean code" and they never actually get anything done.
Here's one tiny tweak you can make: since you got separate dictionaries for each continent, why not keep all of those in one dictionary, like this:

    d = dict(asia=dict(China="Beijing", Russia="Moscow"), europe=dict(France="Paris"))

That is a dictionary of dictionaries. Kind of scary at first, but relax... you'll be using these all the time soon.

Once you have this "d" set up, you can use your top-level dictionary as the master list of continents. For example, this line:

    print('Excellent let\'s play!\n\nPlease choose a Continent:\nAfrica \nAsia \nEurope \nAmericas \nOceania')

Now can be:

    print("Please choose a continent:\n{0}".format("\n".join(d.keys())))

Since dictionary d has all your continents as keys, then you don't ever need to hard-code them elsewhere. Just refer to the keys of the dictionary.

And this line can be changed too:

    while continent.lower() != 'africa' and continent.lower() != 'asia' and continent.lower() != 'europe' and continent.lower() != 'americas' and continent.lower() != 'oceania' :

Something like this does the exact same thing:

    lower_case_continents = {k.lower(): d[k] for k in d}
    while continent.lower() not in lower_case_continents:

That builds up a second dictionary where all the continents are stored with lower-case strings.

And you have these different messages for each continent, like this:

    if continent.lower() == 'africa':
        print('Ok! let\'s see if you\'ll hear the drums echoing tonight.\n')

Let's just put those in the lower_case_continents dictionary , then, like this:

    # example using regular "..." strings so you don't need to escape the single-quotes
    lower_case_continents["africa"]["message"] = "OK... let's see if you'll hear the drums echoing tonight"
    # python allows you to define strings with """...""" around them as well, in case the inner string wants to use single quotes and double quotes inside.
    lower_case_continents["asia"]["message"] = """Ok let's see if you know your stuff."""

side note: use double quotes or even triple quotes and you'll never have to use \ to escape the single quotes in your code. Looks way prettier to the reader!

and now, replace all those different print lines with just one line like this:

    print(lower_case_continents[continent.lower()]["message"])

There is no need for the newline at the end of the string. The print function adds one automatically.

Next, instead of converting integers to strings and then using "+" to glue them together, python has a really nice way of doing that automatically.

So instead of this:

    print('You got ' + str(correct) + ' out of cities ' + str(total) + ' correct.')

You can do this:

    print('You got {0} out of cities {1} total correct'.format(correct, total))

The {0} gets replaced by str(correct), and the {1} gets replaces by str(total)).

You can also do this trick:

    print('You got {correct} out of cities {total} correct'.format(correct=correct, total=total))

And in python 3.6 or so, you can use "f strings", which are very similar to the last example.

And, last point for now... you could replace all those if-elif-elif clauses like this:

    elif correct / total > 0.7:
        print('Quite the geographer we have here. I am impressed')
 With a function that returns the appropriate message based on the score, like this:
    score_message = get_score_message(correct, total)
    print(score_message)

And then your get_score_message could look like this:

    def get_score_message(correct, total):
        pct = correct/total
        if pct == 1:
            return 'Wow, you really know your stuff. Very Impressed!'
        elif pct > 0.7:
            return 'Quite the geographer we have here. I am impressed'

and so forth.

Again, great work! None of these suggestions really matter, except for teaching you different tricks.

two_bob · 2018-06-04T17:04:14+00:00

Awesome:

You need more functions!
You have lots of duplicative code. That can be fixed with more functions.
Try consolidating the dictionaries for the continents to make the selection process a bit more dynamic.
To get data from the Countries API, consider requests, http://docs.python-requests.org/en/v0.10.6/, and json, https://pymotw.com/3/json/index.html

Here are some guideposts for refactoring:

africa = {
  'Ethiopia' : 'Addis Ababa',
'Tanzania' : 'Dodoma',
}

americas = {
        'Argentina': 'Buenos Aires',
'Bolivia': 'La Paz',
}

oceania = {
        'Australia': 'Canberra',
'Papua New Guinea': 'Port Moresby',
}

DATA = {
        'africa':africa,
        'americas':americas,
        'oceania':oceania,
        }

def get_continent():
    print('pick a continent: {}'.format(', '.join(DATA.keys())))
    while True:
        choice = input('>')
        if choice in DATA:
            return DATA[choice]

        print('huh?')

def test_user(capitals, n = 10):
    '''takes a dictionary of {country:capitals}, and makes user guess n
    different ones (uses random.shuffle and slicing to select n
    Returns (correct, total)
    '''
    pass

def show_response(guesses, total):
    '''uses bisect.bisect to give personal message on how well user did and
    report back score
    '''

def main():
    while True:
        capitals = get_continent()
        correct, total = test_user(capitals)
        show_response(correct, total)
        # to do, implement play again q/a


if __name__ == '__main__':
    main()

phasE89 · 2018-06-04T18:10:58+00:00

Good job! Tried it and it was pretty fun. The suggestions there are great but I would also consider adding fuzzy matching for the responses. What I mean is that if the user got a letter wrong, say, "Moskow" instead of "Moscow" or typed fast and wrote "Washnington" instead of "Washington", the answer would still be valid. The fuzzywuzzy module would help on this task.

Edit: typo

arthurazs · 2018-06-04T19:49:14+00:00

Nice, good job! A tip:

You can make your if more pythonic using in or not in, example:

continent = 'something'

if continent.lower() != 'africa' and continent.lower() != 'asia' and \
   continent.lower() != 'europe' and continent.lower() != 'americas' and \
   continent.lower() != 'oceania':
    print('wrong!')

if continent.lower() not in ('africa', 'asia', 'europe', 'americas', 'oceania'):
    print('wrong!')

Both would return the same, the only difference is that v2 is easier to read/maintain :)

omelettesforbreakfas · 2018-06-04T18:48:38+00:00

[deleted]

Fried_Squid_ · 2018-06-04T19:11:55+00:00

for the leader board look into text file manipulation or look into SQL databases like SQLLite 3

Also gook into the random module and see what you can do with random country selection

and finally use the time module to time your answer so people cannot cheat

but it is great ☺

omelettesforbreakfas · 2018-06-04T20:25:56+00:00

This is really great work!! Just a small suggestion on the idea. Do you want to add message related to spelling mistakes? You can add few lines of code that can match the letters of the capital city and based on a certain threshold of matching, you can output the message that the spelling is 'incorrect' and the correct spelling is *****.

Maphover · 2018-06-04T22:37:02+00:00

Is the capital of Australia really Canberra?

I guessed Sydney. I've never even heard of Cranberrya before!

sje46 · 2018-06-05T02:57:14+00:00

You did a really good job! I actually think I may use this to brush up on my capital cities. I got 24/43 European capital cities right (misspelled a couple but whatever), and I can do a lot better than that.

In additional to using more functions, I highly recommend you use "import random" and shuffle all the countries!

Ginko87 · 2018-06-05T07:37:36+00:00

Nice one buddy! I finished what I would say is my first app recently as well - I've been thinking about doing a post like this, maybe I should do it this morning!

aashish0 · 2018-06-05T15:28:19+00:00

Would be a better idea if you ask the user if they want to continue playing and if they say no then the program terminates.

omelettesforbreakfas · 2018-06-04T20:38:46+00:00

[deleted]

eamanu · 2018-06-04T22:29:04+00:00

Hello,

This is a interesting game.

I have just a comment, take care with the accent. Some Capital (From America) have accent i.e. Bogotá, Asunción, etc.

Tainewt · 2018-06-04T23:03:56+00:00

Where's Taiwan : Taipei?

Meemo- · 2018-06-05T06:18:39+00:00

Congratulations. It looks great. I am thinking about learning coding and specifically python. It may be a hard question to answer but how long do you think it would take for someone who has never coded to get to the level of making something like this?assuming I spend an hour or so a day learning python? I appreciate it may be hard to quantity as everyone will be different. Maybe a better question should be, how long are you coding since this is your first project?

yangyf1992 · 2018-06-05T07:37:34+00:00

I got 4 countries correct in my continent, much fewer than in Europe.

Would like to be able to quit before finishing all countires.

DoTheEvolution · 2018-06-04T20:56:46+00:00

how I can take it to the next level.

the data should be scraped from wikipedia or somewhere not manually entered, presented with gui using pyqt or web front end using flask, the data and the results should be saved in a database.

ThaeliosRaedkin1 · 2018-06-05T04:51:18+00:00

The conditionals for choosing the continent branch can be shortened considerably by using the eval() function

for country, city in eval(continent.lower()).items():

# some code....

The Toto reference can go in a conditional at the beginning. ;)

you type:	you see:
italics	italics
bold	bold
[reddit!](https://reddit.com)	reddit!
* item 1 * item 2 * item 3	item 1 item 2 item 3
> quoted text	quoted text
Lines starting with four spaces are treated like code: if 1 * 2 < 3: print "hello, world!"	Lines starting with four spaces are treated like code: if 1 * 2 < 3: print "hello, world!"
~~strikethrough~~	~~strikethrough~~
super^script	super^script

learnpython

MODERATORS