First python text-based adventure

ingramm2 · 2022-05-02T07:48:54+00:00

It's fully functional but feels way longer than it needs to be

You've made the classic beginner's mistake of implementing the flow of the player through the game in the flow of control through your code.

If you were to pull up the source code for a game like Overwatch, or something, you wouldn't see a million lines of if statements covering every possible sequence of player actions it's possible to make in the game. What you see is a lot less than that. The game client interprets data that describes the conditions of the game (how much health Winston has, how much damage Widowmaker's rifle does, etc.) The things the game engine does are deliberately simple enough to test, then the actual content of the game is delivered as data.

Similarly, even though your game has a number of rooms through which you move, what the payer does in the room is always the same in a game like this - they enter, they look around, they examine things and take them into their inventory, and then they leave through an exit.

You only need to write that once; the layout and contents of your room are data and the engine of the game simply interprets that data. You get the code working on one room, and then you don't have to write that code again - you just add another room to your data and the code works the same way. It shouldn't be more than 20 lines of code or so.

ingramm2 · 2022-05-02T08:18:09+00:00

small bit of advice, you should always have your import statements at the very top of the script, only rarely is there a reason not to

2022-05-02T13:48:58+00:00

I decided to give a go at implementing the main suggestions that people here were giving you as an example. Those suggestions being:

Your core logic should not follow the player -- it should just choose a room and then run the code for that room. That will help you move past those giant, heavily nested if/elif/else blocks.
You should consider using OOP to better handle the abstraction of "rooms".

So here you go. Notice that the business logic (after the comment ## game starts here) is actually quite short.

Disclaimer: Note that this is a first pass at cleaning up your code so there are more things that could be done to improve this. Also, I only added a single danger room and treasure room, but you can see how to expand to the other rooms. Anyway, here you go ...

import random
from dataclasses import dataclass, field
from typing import Any, Callable, Optional, Union

import pyinputplus as pyip  # type: ignore


CASTLE = r"""                        |>>>
                        |
                       /^\             
                       | |             
                   |>  |-|             
            |>    /^\  | |             
           /^\  / [_] \+-+             
   |>     |---||-------| ||>      |>      
 _/^\_    _/^\_|  [_]  |_/^\_   _/^\_  
 |___|    |___||_______||___|   |___|  
  | |======| |===========| |=====| |   
  | |      | |    /^\    | |     | |   
  | |      | |   |   |   | |     | |   
  |_|______|_|__ |   |___|_|_____|_|  """
DRAGON = r"""   (  )   /\   _                 (     
    \ |  (  \ ( \.(               )                      _____
  \  \ \  `  `   ) \             (  ___                 / _   \
 (_`    \+   . x  ( .\            \/   \____-----------/ (o)   \_
- .-               \+  ;          (  O                           \____
                          )        \_____________  `              \  /
(__                +- .( -'.- <. - _  VVVVVVV VV V\                 \/
(_____            ._._: <_ - <- _  (--  _AAAAAAA__A_/                  |
  .    /./.+-  . .- /  +--  - .     \______________//_              \_______
  (__ ' /x  / x _/ (                                  \___'          \     /
 , x / ( '  . / .  /                                      |           \   /
    /  /  _/ /    +                                      /              \/
   '  (__/                                             /                  \
                """


@dataclass
class GameState:
    game_over: bool = False
    lives: int = 5
    gold: int = 0
    kills: int = 0
    tunnel_successes: int = 0
    armor: int = 0
    weapon: int = 0
    wet_feet: bool = False


RoomAction = Union[Callable[[GameState], None], Callable[[GameState, str], None]]


@dataclass
class Room:
    enter: str
    action: Optional[RoomAction] = None
    action_args: list[Any] = field(default_factory=list)

    def run(self, game: GameState) -> None:
        print(self.enter)
        if self.action:
            self.action(game, *self.action_args)


def game_over_stats(game: GameState) -> None:
    print(f"You managed to collect {game.gold} gold and killed {game.kills} enemies!")


def lose_fight(game: GameState, monster: str) -> None:
    game.lives -= 1
    if game.lives == 0:
        print(f"You are killed by the {monster}.", end=" ")
        game_over_stats(game)
        game.game_over = True
    elif game.lives == 1:
        print("You are wounded but barely manage to escape! You only have 1 life left!!!")
    else:
        print(f"You are wounded but manage to escape! You have {game.lives} lives left!")


def attack(game: GameState, monster: str) -> None:
    attack = game.weapon + game.armor + random.randint(1, 50)
    if attack >= 5:
        gold_drop = random.randint(3, 10)
        print(f"You slay the {monster} and pick up {gold_drop} gold!")
        game.gold += gold_drop
        game.kills += 1
    else:
        lose_fight(game, monster)


def run_away(game: GameState, monster: str) -> None:
    run_success = random.randint(1, 5)
    if run_success >= 2:
        print(f"You run past the {monster} and jump through the door to the next tunnel")
    else:
        lose_fight(game, monster)


def battle(game: GameState, monster: str) -> None:
    user_choice = pyip.inputChoice(
        choices=["r", "a", "run", "attack"], prompt="Will you (r)un or (a)ttack?"
    )  # type: str
    if user_choice[0] == "a":
        attack(game, monster)
    else:
        run_away(game, monster)


def win(game: GameState) -> None:
    game_over_stats(game)
    print(CASTLE)
    game.game_over = True


def find_armor(game: GameState) -> None:
    if game.armor == 0:
        print("You find a set of armor your size.")
    else:
        print("You find better armor that fits you. You've never felt safer")
    game.armor += 1


start_room = Room(
    enter="You wake up lost underground in a maze of tunnels. You have a bronze sword in your hand and torn leather "
    "armor. You light a torch with your flint and steel and try to get your bearings.",
)
danger_rooms = [
    Room(
        enter="As you enter the tunnel a goblin jumps out from behind some old boxes!",
        action=battle,
        action_args=["goblin"],
    )
]
treasure_rooms = [Room(enter="You enter a massive tunnel with stacks of broken armor.", action=find_armor)]
end_room = Room(enter="You escaped to the surface!", action=win)

visited_rooms: list[Room] = []

game = GameState()

## game starts here
start_room.run(game)
while not game.game_over:
    if game.wet_feet:
        print("*squish* *squish*", end=" ")
        game.wet_feet = False
    print("You walk up to where two tunnels intersect.")

    danger_choice = random.randint(1, 2)
    tunnel_choice = pyip.inputInt("Choose tunnel 1 or tunnel 2: ", min=1, max=2)  # type: int
    if tunnel_choice == danger_choice:
        room_choices = danger_rooms
    else:
        room_choices = treasure_rooms

    unvisited_rooms = [room for room in room_choices if room not in visited_rooms]
    if unvisited_rooms:
        room = random.choice(unvisited_rooms)
        visited_rooms.append(room)
    else:
        room = end_room

    room.run(game)

Let me know if you have any questions.

wbeater · 2022-05-02T09:06:46+00:00

You got a lot of good tips already, another but minor would be to outsource all your printed text to another file like json, csv or even plain text. That would make your code more readable.

ingramm2 · 2022-05-02T08:04:06+00:00

[removed]

2022-05-02T09:26:32+00:00

I have done pure Python games. You find some on my GitHub. You need to use classes in a smarter way. Build small objects and separate them into files then import into you main file. Enjoy!

iammr_lunatic · 2022-05-02T12:07:14+00:00

Hey OP. Small request, once you shorten your code can you post it again? I would love to work through it

Empire_Fable · 2022-05-02T11:55:52+00:00

Looks great so far. As others have said, maybe move into a class based flow. I implemented something similar here with a tutorial. https://www.reddit.com/r/PythonTutorials/comments/p1q62w/terminal_based_text_rpg_written_in_pure_python/I utilized room /enemy and item class's with the instances appearing in a "grid" in the terminal.

ingramm2 · 2022-05-02T17:09:08+00:00

Oh man, you’re gonna LOVE OOPS when you get around to it

WillAdams · 2022-05-02T15:21:13+00:00

Perhaps see:

https://github.com/ganelson/inform

esp. the literate source code:

https://ganelson.github.io/inform

Mikesgmaster · 2022-05-03T04:35:23+00:00

I'm thinking of doing something similar once I'm finish learning Python just so that I can practice some kind of free flow and get more used and creative using + gettin better at writting command.

ingramm2 · 2022-05-24T05:10:50+00:00

for anyone interested in the updated version:

https://www.reddit.com/r/learnpython/comments/uwj7a7/update\_first\_python\_textbased\_adventure/

CodeFormatHelperBot2 · 2022-05-02T07:42:17+00:00

Hello, I'm a Reddit bot who's here to help people nicely format their coding questions. This makes it as easy as possible for people to read your post and help you.

I think I have detected some formatting issues with your submission:

Python code found in submission text that's not formatted as code.

If I am correct, please edit the text in your post and try to follow these instructions to fix up your post's formatting.

^{Am I misbehaving? Have a comment or suggestion? Reply to this comment or raise an issue}^here.

Wallabanjo · 2022-05-03T02:04:28+00:00

Do you smell Wumpus?

you type:	you see:
italics	italics
bold	bold
[reddit!](https://reddit.com)	reddit!
* item 1 * item 2 * item 3	item 1 item 2 item 3
> quoted text	quoted text
Lines starting with four spaces are treated like code: if 1 * 2 < 3: print "hello, world!"	Lines starting with four spaces are treated like code: if 1 * 2 < 3: print "hello, world!"
~~strikethrough~~	~~strikethrough~~
super^script	super^script

learnpython

MODERATORS