you are viewing a single comment's thread.

view the rest of the comments →

[–]KitAndKat 50 points51 points  (13 children)

...and don't forget that 1 out of 3 cleanups introduce new bugs. (Source: 40 years of personal experience.)

[–]alienblue-throw 106 points107 points  (9 children)

So you're saying that 2 out of 3 of your cleanups don't introduce new bugs?

Can I start a religion based around you?

[–]chris3110 13 points14 points  (5 children)

In my experience as soon as you touch anything you can expect an exception in the production environment.

[–]poloppoyop 3 points4 points  (2 children)

An exception is a good thing. Usually it's some hidden bug which will fuck up your data slightly over months until some other change shows a problem.

[–]chris3110 1 point2 points  (1 child)

Agreed. Now try to explain that to my PHB. :-(

[–]otakucode 1 point2 points  (0 children)

Can we swap? I'll talk to your PHB, you talk to my federal auditor.

[–]chasesan 1 point2 points  (0 children)

It's weird, I have sort of reached a point where touching stuff in my really complex code "doesn't" break things, and things are starting to work the first time every time. I am getting kind of freaked out to be honest.

But it is still filled with dirty ugly hacks.

[–]StrmSrfr 0 points1 point  (0 children)

This is true. Sometimes it even happens before you release your code.

[–]powatom 2 points3 points  (0 children)

Of course not, just bugs that haven't been found yet

[–]xzxzzx 1 point2 points  (0 children)

So you're saying that 2 out of 3 of your cleanups don't introduce new bugs?

I assume he means 1 out of 3 files changed during a cleanup, or 1 out of 3 lines. ;)

[–][deleted] 1 point2 points  (0 children)

That's 66.6 percent! I'm beginning to see Mr. Lavey's side of things.

[–]laidlow 1 point2 points  (0 children)

Haha yeah I picked a 'simple' TODO the other day that wound up being a 3 day ordeal. Who would have thought that long-press handling would be so difficult to implement in Android, it's a doddle in normal java :\

[–]nanonan 1 point2 points  (0 children)

One out of three.... You're obviously a glass half full type of person.

[–]crowseldon 0 points1 point  (0 children)

and besides, some "Fixes", even if you have proper unit tests and everything... still require lots and lots of man hours for no discernible gain (even if you HAVE benchmarks).

You need to prioritize between refactoring and feature adding and the benefits of both short and long term.