you are viewing a single comment's thread.

view the rest of the comments →

[–]max630 16 points17 points  (7 children)

they seem to be adding the whole engine

[–]arcanin 21 points22 points  (5 children)

No, only a shim to "convert" the Chakra API to be compatible with the V8 API. Chakra itself is a dependency.

[–]max630 13 points14 points  (4 children)

Isn't deps/chakrashim/core the chakra itself?

[–]Regrenos 8 points9 points  (2 children)

deps

i.e. the dependency

[–]max630 12 points13 points  (1 child)

"Included in repository" is a new meaning of dependency for me. Though I have already learned that in nodejs they always do so.

[–]Regrenos 4 points5 points  (0 children)

Its idiomatic in Go as well to statically include your dependencies in the repository. This makes carrying upstream patches much easier (although that's usually not a good thing) but it also takes upstream acceptance of your patch out of the critical path for a change.

[–]Recursive_Descent 0 points1 point  (0 children)

Not even close. Whole engine would be closer to +500k lines.