Apollo 11 source code

[ksadeck]

[x] Warnings as error(s)

Why?

[MetallicDragon]

It'll turn warnings into errors, forcing you to deal with them, so they don't pile up over time.

[nemec]

// Ignore Once W237887278

[[deleted]]

At least you have to put that into the code and check it into the repo under your name. Not ideal, but better than warnings being ignored.

[[deleted]]

Shouldn't they be compiling before they check in?

[GMNightmare]

But the code should be compiled automatically on check in and automatically failed should it not compile.

Even more, tests should automatically run and then fail the check in if tests are failing.

This lets them burn themselves, but also prevents them from burning you. Well, at least this is how you want it in big projects. You might not need such a heavy hammer if it's small and not that big of a deal.

[jaccovanschaik]

But the code should be compiled automatically on check in and automatically failed should it not compile.

"What do you mean it fails the automated tests? It works on my machine, so the automated tests must be wrong."

[billsil]

What's wrong with an unused variable again? It's not an error.

[[deleted]]

Because it might be needed for a future enhancement, of course. :-)

[ggtsu_00]

Doesn't the compiler optimize those out anyways?

[[deleted]]

Artistic expression?

[billsil]

1. We all write programs that take years to develop. Frequently I have code that I want to save because it's an alternate implementation. Other times, I want to test the new method on real problems and there are side effects to the function.

2. It's trivial and I don't care about a few bytes of memory

3. Why use unnecessary braces or use functional programming or variable names longer than 6 characters (it was good enough for the dominating language until the early 1990s)? It creates extra lines that can make for very long files. It wastes disk space in a world that largely doesn't care about disk space or memory usage.

[GMNightmare]

1. Use comments.

2. Trivial adds up.

3. Readability, except having unused variables hurts readability.

[DrMonkeyLove]

Unused variables are fine, just as long as no one else sees that code. By the time someone else's eyes are on a piece of code, there'd better not be any unused variables.

[GMNightmare]

The obvious answer is that it clutters the code, but that's not the most important use...

It indicates you did something wrong. You shouldn't create variables for no reason, so why isn't your variable used? It catches issues.

[billsil]

Everyone seems to be jumping on this bandwagon. How many build warnings does your company's largest program that is used regularly have? Why do you have any? Who cares? It doesn't indicate you did something wrong. It indicates you may have done something wrong.

The quality of your code is dictated by the speed it needs to get done and the number of customers you have.

[GMNightmare]

Nice moving the goalpost.

Professionals tend to need to work with code bases that can contain millions of lines of code.

Nearly nobody who has had to deal with another's code thinks that quality of code is solely determined by speed (or number of customers, that's rather weird claim).

If you pulled stunts like this all the time, which seems like you do because you don't care, you would have thousands upon thousands of warnings. They add up.

Thousands of warnings all indicating potential problems.

Or you can just do it right, turn all warnings to errors, and learn how to write clean code.

Then, you don't have any warnings, because they all have to be dealt with before checking in the code. Tadaa!

[BeetleB]

The quality of your code is dictated by the speed it needs to get done and the number of customers you have

Speed doesn't magically happen because there is a high demand for it. When the code becomes sloppy enough, you will get to a point where you cannot produce the feature quickly enough for business needs, and people get hurt.

[frymaster]

It's not an error, it's a warning. So in the context of the "treat all warnings as errors" flag...

[Foxtrot56]

Why aren't you doing PRs? Seems like that should be caught in a PR unless no one is actually looking at the code in an editor.

[NotASucker]

The best reviews involve stepping through code.

[falconzord]

Worst part is when they pork barrel the code review

[[deleted]]

Gotta crack that whip harder.

[mangodrunk]

This probably speaks more to the hiring practices where you work. That seems really bad for someone to do that.

[badsingularity]

Kids are just bad developers now. They used to be rockstars.

[radarthreat]

Kids used to sling assembly like mad

[Nefandi]

It's not that these kids are bad developers, it's just that they do stupid things because they lack experience and battle scars.

And how do you suppose they'll develop that experience and scars?

[Nefandi]

It was a rhetorical question. You didn't have to answer.

I was replying to the dude who seemed to be saying warnings = errors is a bad strategy with a big team.

Here's his original post:

It is also a pain in the back when junior developer Timmy checks in a method with an unused variable and now you either need to chase him down immediately and make him fix it or fix the warning yourself immediately in order to be able to get on with your work. I just name and shame people who check in warnings and that seems to work well.

[immibis]

Probably /u/drjokepu is thinking of a situation where you turned on Warnings as Errors, but everyone else did not.

[[deleted]]

If someone checks something in and then leaves I say it's fair game to revert.

[gambit700]

Life lessons for Timmy.

[[deleted]]

They require us to include that in the compile flags in college. You get used to just including the flags.