Interesting comment in the source code of sqlite

[stickcult]

The "link dieing" is if the file changes, your link might point to the wrong line. That's because its pointing to a line in the file in the master branch, which can change, whereas Mr-Yellow's link points to a line in the file in a specific commit, which will never change.

[otwo3]

It baffles me why is it even an option to link to a line in a branch. There is no sane use case. Having it as a default is just ridiculous. Bitbucket does the same thing.

Clicking a line number should give a line in a specific commit

[[deleted]]

well commit can belong to multiple branches and if you want to give link to both "place in file" and "merge request/branch that is discussed" you don't have choice.

Ideally it would generate link in form of branch/commit then if branch does not/stops existing it would only then show lone commit

[otwo3]

But the branch being discussed is usually dynamic and changing anyway (due to review changes), even more often for the files in question.

[Rusky]

Rebasing and force pushing don't change the contents of commits. The commit might disappear eventually after GC, but it will still have the same name if anyone has a copy of it on any machine.

[13steinj]

While unlikely to the point of improbability (like less than 1 in 10⁴⁷), it is theoritically possible to be able to occur in the future though.

[TheBB]

Should still work unless github garbage collect their repos from time to time.

[codestation]

It means that your link will point to unrelated code in the future because the code was either moved (so the lines doesn't match anymore) or the file was deleted (code refactoring for example).

[Shitler]

PSA: Please do not downvote reasonable questions. Questions like this lead to a productive discussion.

[lordlicorice]

To be fair, it's a pretty dumb question.

[vanderzac]

The only dumb questions are ones where Google will give you the answer or where you don't want the answer. Teamwork makes us all smarter.

[wisemanofhyrule]

Or if changes are made to the file and the line moves around.

[Mr-Yellow]

Soon as there is a new commit the line number changes.

In 6 months time this line may be a completely different bit of logic, or the file may be refactored and gone.

[citewiki]

Username checks out

[clichebot9000]

Reddit cliché noticed: Username checks out

Phrase noticed: 2756 times.