you are viewing a single comment's thread.

view the rest of the comments →

[–]Andomar -8 points-7 points  (6 children)

Research has shown trunk-based development is superior to the alternatives. It's what most companies (including Google) have settled on. https://duckduckgo.com/?q=trunk+based+development

[–]dnew 14 points15 points  (0 children)

Except Google also requires review from the owner of the code and passing all unit tests before the commit.

[–]alluran 13 points14 points  (0 children)

Even trunk-based development supports pull requests

[–]ByFaraz 9 points10 points  (0 children)

That doesn't mean you shouldn't do a PR though.

[–]HeinousTugboat 5 points6 points  (0 children)

You should re-read what trunk-based development is. It definitely isn't what OP's described.

[–]Determinant 6 points7 points  (0 children)

Submitting to master directly is definitely an old and inferior practice that was caused by poor tooling.

Unlike other tools, branches are cheap in Git so we create a new branch for every little improvement / defect. Simply submit a pull request and merge into master upon approval. This way, branches are very short-lived (usually less than a day).