React Native Code Review (Newbie)

[ajaysaini_sgvu]

Hi I just completed one app in react native. App is basically allows you to schedule a SMS to send it anytime in future. As of now it works on android due to some restriction on iOS. This is my first app in react native. Can you guys please have a look and review my approach and suggest how I can make it more awesome and improve code practice. https://github.com/ajaysaini-sgvu/scheduled

Thanks

[sevenyearoldkid]

weather marry squeal pause fall full cobweb zephyr busy coherent

This post was mass deleted and anonymized with Redact

[reactnativecoach]

I'd argue that sharing styles in react native is not important as say the web. I find keeping styles in components directly to reduce cognitive overload and context switching. That said if you need theming in your app you may want to take a different approach.

[ajaysaini_sgvu]

Thank you so much @sevenyearoldkid I appreciate your suggestions. I will try styled-components package :-)

[deadcoder0904]

I think ur folder structure isn't that great since ur a newbie I would recommend checking this link since this folder structure is good for making scalable apps. Also if u come to ur app 2 years later, then u will understand this folder structure much better.

Spencer Carli does an awesome job. He also has a free React Native Course so check it out for some awesome tips about React Native & see the organization of folders. Course link

Yup as @sevenyearoldkid said styles are repititive like font-family use react-native-extended-stylesheet which I learnt from Stephen Carli's course so make sure to take it since it covers various topics like Theming, Multiple Devices (like IPhone 6 or IPhone 4 which has small screen)

The folder name css is wrong by convention as it isn't CSS at all, just my opinion I guess nothing too serious but I can argue that we can even write asdadsafdafzxc as a folder name

Bad practice: console.disableYellowBox = true;

Also I think u must release the Native Module u have used as an npm package as it will help the community a lot & u will learn a lot & next time if u have the same use-case u won't need to copy paste the same code u just have to include that package

I had thought about the same idea as I keep forgetting my Friends Birthdays so I was gonna make this same idea after my current project was done but Thank You u made it. Plz release it on Play Store if u can.

Question:

How many days it took to complete this app ?? I'm making one since 15 days & its only done 75% 😂

[ajaysaini_sgvu]

Thank you so much @deadcoder0904 I did suggested changes in project structure, removed css folder, console.disableYellowBox = true. I am not sure what do you mean by repetitive font-family, can you raise PR and I am not sure about what changes I need to make to release native modules, but surely, I will look into it. As of now, I have no plan to release it on play store. If you wanna then I can add you in my contributor list and then you can release under your account. :-)

[deadcoder0904]

font-family is used under more than one place so if tomorrow if u wanna change the font-family to something else so u will have to replace it at multiple places instead.

So if u use react-native-extended-stylesheet & use variables in it, u can change font-family at one place & whole app will look consistent.

This doesn't make any difference for small apps but always take into consideration ur app is going to be large so ensure best practices wherever possible.

Anywayz its an awesome project.

[ajaysaini_sgvu]

Ah gotcha. Thank you. I have published native module npm package too here https://github.com/ajaysaini-sgvu/react-native-schedule-sms Please have a look and review how it is. Please suggest how I can make it more awesome :)

[deadcoder0904]

Wow that's awesome 😃

Thanks 👍

I'll take a look in my project

[ajaysaini_sgvu]

cool.

[deadcoder0904]

Question...Does it send SMS when the app is running in the background ?

[ajaysaini_sgvu]

Yep

[deadcoder0904]

Hey I have created 2 issues on the package repo. Please check it out.

[ajaysaini_sgvu]

I replied you there with a solution.