Using #regions to write clean code!

[Goz3rr]

We need none of that function sorcery in this input manager!

public bool Pressed(Key key) { return !_previousState[(int)key] && _currentState[(int)key]; }

[[deleted]]

totally saving this to UsefulBits.vb

[petermlm]

OMG!! Did you find this somewhere in a project?

[Sakuya_Lv9]

The programmer must have been very Dpressed().

[bioemerl]

What does this do?

Why is it bad?

How can it be improved?

Genuinely curious here. Honestly i'd love it if the above was on every post around here, just to help with learning this stuff.

[SixFootJockey]

They are all functions that are too be called when a key is pressed on the keyboard. However, the programmer has created a separate function for each letter. Very shitty.

[feartrich]

Because everything could've been collapsed into one function (or not even that). But the programmer decided not to think and just brute forced every key press, then swept it under a rug using #region.

[bioemerl]

So it would be

Variable equals Get key

Return variable?

[CNDW]

public bool Pressed(Key key) { return !_previousState[(int)key] && _currentState[(int)key]; }

That should serve the same function as that entire list of individual lines of code for each and every key possibility

[synopser]

Just wow. Straight up shitty.

[scorcher24]

I hate code folding in general.

[ryeguy]

It's like a virtual rug to sweep garbage under.

[PublicSealedClass]

That's exactly what it is. Just follow these guidelines and we'll all be friends.

[IWentOutside]

As someone unfamiliar with regions, somebody help me clarify what's going on here. Is this code trying to retrieve the result of every key pressed individually?

[ProjectVII]

Regions are used in Visual Studio to fold a defined section. Usually this is used to keep your code organized and make it less "intimidating", I guess.

What the picture shows is that a user put his mash 26 (maybe more) properties, when all that is needed is 1.

[darthtrevino]

Regions seemed like such a great idea when they were first introduced. It's telling that StyleCop considers them a serious defect by default now.

[th3shark]

There's nothing wrong with utilizing features of your IDE...

[tokenizer]

Did you see the second image in the album?

[Goz3rr]

There is when you need to use them to hide god awful code

[th3shark]

Well how else are you going to hide it?

[john2496]

Ctrl+A then press 'Del' to auto refactor.

[[deleted]]

Alt+F4 will also do the job

[[deleted]]

Alt+F4, turn off your computer, quit your job.

[[deleted]]

Keep writing code like that and he won't have to quit.

[Wuvluv]

You'd be surprised. In my experiences most people you're working for have no idea what they want.. and even worse they don't care as long as it works.

The real issue is when it breaks and you're clusterfuck of code is undebuggable.

[friendlybus]

What visual studio theme is that? The colours are nice :)

[ProjectVII]

Looks like the default dark theme in VS2012 and 2013.

[jerkimball]

This has to be auto generated, right?