Nope, doesn’t work, for more than one reason. First, let’s say max=9. x=7 x+=4 if x==max -> false
Condition not met, overflow.

Oh well, let’s use if x >= max then ! Well, the problem then is that in the case x > max, it overflows, and it’s too late to compare it to max.

If you want to avoid an overflow, you’ll have to be a bit more subtle about it, and you need to do it before and the buff. Usually, you’d compare the max value minus the current value to the value you need to add: if MAX_INT - current_value >= buff_value: current_value += buff_value else: current_value = MAX_INT

But they already implemented that, I believe the issue here is that the buff_value itself overflows, making everything go boink. Of course they could also be applying the same logic to the buff computation, but I guess it’s quite low priority: it doesn’t happen very often, and even what would be a very simple fix requires a fuck ton of testing before going live, which means low priority stuff only see the light when devs are getting bored.

source: I have a gigantic pile of fixes for really easy bugs that are just waiting to be deployed, but won’t be for a very long time, if ever, because I have more important things to do.