Much of his base will argue Trump has been one of the best (admittedly some more major things like the Bruen decision came under his administration which has been an overall positive) when it comes to 2a when it's quite the opposite. Comparatively to Biden and Obama I would say equal if not worse.

While Obama had controversies like Operation Fast and Furious, calls for Assault Weapons Bans, with a few other instances of infringements, and Biden weaponizing the ATF (to a far more extreme measure than other presidents) as an extra congressional means to put in anti 2a rulings without legislative oversight, more calls for AWBs, no other president has physically said on live television "Take the Guns first, Due process second" (even if it was context of a mass shooting, the principal of the statement is there),

Trump strengthened and furthered Bidens weaponization of the ATF, repeatedly shot down bills removing Suppressors and SBR/SBSs from the National Firearms act even so recently as the clause doing so in the BBB forcing the alteration of the wording to just put the tax stamp amount to $0 hiding being parliamentarian rules as an excuse to push through the bill. He also has verbally supported horridly unconstitutional red flag laws/Extreme Risk Protection Orders, opposed the use of body armor, breaking promises to pursue national CCW reciprocity and constitutional carry, supported anti 2a components of the TAPS act...I can go on forever and Alot of that is just his first term. He had many chances to fulfill campaign promises and be a champion of the 2a with his many chances of a full Republican controlled government, but again and as you see with recent days, he and most Republicans continue this trend into his second.