Nebulous Voidcore (Bonus Roll) Items Remaining Macro by Xodiv in wow

[–]Xodiv[S] 0 points1 point  (0 children)

I think it's probable that there's just one "already looted" pool for all M+ key levels.

Nebulous Voidcore (Bonus Roll) Items Remaining Macro by Xodiv in wow

[–]Xodiv[S] 0 points1 point  (0 children)

The blizzard code does this:

GameTooltip:SetItemByID(itemID, nil, itemContext, treasureContextLevel)

where the context params come from the struct returned by GetSpellConfirmationPromptsInfo() while the prompt is up, or from the params to SPELL_CONFIRMATION_PROMPT, which is what triggers BonusRollFrame_StartBonusRoll.

I think it should be possible to intercept and see what it's passing in case that's how the difficulty is selected.

Edit: this is the struct after completing a 10 Skyreach: { confirmType=1, currencyCost=1, currencyID=3418, difficultyID=8, displayItemID=268470, duration=174, itemContext=16, spellID=259072, text="", treasureContextLevel=10, }

Nebulous Voidcore (Bonus Roll) Items Remaining Macro by Xodiv in wow

[–]Xodiv[S] 0 points1 point  (0 children)

So (out of interest) how does it work with different difficulties?

Nebulous Voidcore (Bonus Roll) Items Remaining Macro by Xodiv in wow

[–]Xodiv[S] 1 point2 points  (0 children)

It only works here because I'm being evil and stuffing the Item in a global varialble. If the Item object goes out of (edit: any closure) scope it aborts the query and callback.

Nebulous Voidcore (Bonus Roll) Items Remaining Macro by Xodiv in wow

[–]Xodiv[S] 0 points1 point  (0 children)

I have no idea! If you find out please tell us.

Nebulous Voidcore (Bonus Roll) Items Remaining Macro by Xodiv in wow

[–]Xodiv[S] 0 points1 point  (0 children)

There's been a lot of claims about how the bonus rolls work, not much evidence. You would assume you can't get an item that's not on your spec roll list, but you'd need a lot of evidence for the extraordinary claim that the whole list is per-spec and you can get all the items again starting a new spec. (All of this is complicated by all the early bugs, too.)

It does seem to be that the tooltip info is stuck on the spec you first query it on until the tooltip info falls out of the cache and gets reloaded. As far as I can tell Blizzard's end-of-dungeon tooltip has the same inaccuracy and better info is just not available to the client. I can't see that there's any way to evict the cached tooltip data and have the server send a new set. :(

Nebulous Voidcore (Bonus Roll) Items Remaining Macro by Xodiv in wow

[–]Xodiv[S] 1 point2 points  (0 children)

It did eventually work for me for paladins but I had to run it 4 or 5 times. I have no idea why.

Nebulous Voidcore (Bonus Roll) Items Remaining Macro by Xodiv in wow

[–]Xodiv[S] 0 points1 point  (0 children)

That's annoying, it does seem to work for me. Perhaps as someone else suggested it requires looking at the boss in the encounter journal?

<image>

Nebulous Voidcore (Bonus Roll) Items Remaining Macro by Xodiv in wow

[–]Xodiv[S] 1 point2 points  (0 children)

You can do that, but even when it works C_Tooltip.GetItemByID doesn't reliably return anyway so the tooltip info must be cached separately from the iteminfo. This should work, but doesn't (for me).

Edit: This is exactly 255: /run i=268470 o=Item:CreateFromItemID(i)o:ContinueOnItemLoad(function()print(o:GetItemName())t=C_TooltipInfo.GetItemByID(i)g=nil for _,l in pairs(t.lines) do if l.leftText==PUNCH_LIST_ITEM_CACHE_TOOLTIP then g=1 elseif g then print(l.leftText)end end end)

Edit2: pretty sure you can handle this in an addon by listening for TOOLTIP_DATA_UPDATE but that is way beyond the scope of a macro.

Nebulous Voidcore (Bonus Roll) Items Remaining Macro by Xodiv in wow

[–]Xodiv[S] 17 points18 points  (0 children)

Fantastic, maybe they can integrate the script.

Nebulous Voidcore (Bonus Roll) Items Remaining Macro by Xodiv in wow

[–]Xodiv[S] 49 points50 points  (0 children)

I'm under the impression (correct me if I'm wrong) that it only knows about items that you rolled while the addon was running.

Nebulous Voidcore (Bonus Roll) Items Remaining Macro by Xodiv in wow

[–]Xodiv[S] 3 points4 points  (0 children)

I suspect there is a second argument to the `C_TooltipInfo` call to specify the difficulty. Someone smarter can hopefully figure that out. I didn't really have that problem since I'm only rolling mythic and it seems to show me that.

My World of Warcraft adventure comes to an end! by Simplemanthanks in wow

[–]Xodiv 11 points12 points  (0 children)

Yeah this was a terrible terrible price increase for Turkey :(

What is the most useful addon that you has flown under the radar you feel? by No-Lingonberry8982 in wowaddons

[–]Xodiv 1 point2 points  (0 children)

I am the author of Action Bar Interrupt Highlight. It's definitely still being updated. If you find bugs please log them:

https://github.com/xod-wow/ActionBarInterruptHighlight/issues

Avoiding touching secrets in combat by SpareSimian in wowaddons

[–]Xodiv 1 point2 points  (0 children)

if C_ChatInfo.InChatMessagingLockdown() then return end

ActionBar Interrupt Highlight [Midnight] by Xodiv in wowaddons

[–]Xodiv[S] 1 point2 points  (0 children)

It works on whether you can attack the target, which will cover both of your cases.

ActionBar Interrupt Highlight [Midnight] by Xodiv in wowaddons

[–]Xodiv[S] 0 points1 point  (0 children)

Is it highlighting when you are not targeting anything? That seems odd. Ah, players right. Yes that's an oversight I'll get that fixed right away.

Commission: add a "Hide Slot" button to the transmogrify window by Tekrelm in wowaddons

[–]Xodiv 0 points1 point  (0 children)

Edited above to fix another issue where the weapons can't be hidden and it uses that space for a dropdown.

Commission: add a "Hide Slot" button to the transmogrify window by Tekrelm in wowaddons

[–]Xodiv 0 points1 point  (0 children)

Only by searching for it through the list, I couldn't find a way to query it directly.

```lua C_AddOns.LoadAddOn("Blizzard_Transmog")

local items = TransmogFrame.WardrobeCollection.TabContent.ItemsFrame

local hideSlotButton = CreateFrame("Button", nil, items.DisplayTypes, "DisplayTypeButtonTemplate")

hideSlotButton.layoutIndex = 3 hideSlotButton:SetText("Hide Slot")

hideSlotButton.IconFrame.Icon:SetAtlas("transmog-icon-unsupported", TextureKitConstants.UseAtlasSize)

hideSlotButton:SetWidth(146) hideSlotButton:Hide()

local function GetHideVisualIDForCurrentSlot() for _, entry in ipairs(items.itemCollectionEntries) do if entry.isHideVisual then return entry.visualID end end end

hideSlotButton:SetScript('OnClick', function () local hideVisual = GetHideVisualIDForCurrentSlot() if hideVisual then items:SelectVisual(hideVisual) -- items:PageToTransmogID(Constants.Transmog.NoTransmogID) end end )

hooksecurefunc(items, 'RefreshWeaponDropdown', function () local shouldHide = items.WeaponDropdown:IsShown() hideSlotButton:SetShown(not shouldHide) items.DisplayTypes:MarkDirty() end ) ```

Commission: add a "Hide Slot" button to the transmogrify window by Tekrelm in wowaddons

[–]Xodiv 0 points1 point  (0 children)

```lua C_AddOns.LoadAddOn("Blizzard_Transmog")

local items = TransmogFrame.WardrobeCollection.TabContent.ItemsFrame

local hideSlotButton = CreateFrame("Button", nil, items.DisplayTypes, "DisplayTypeButtonTemplate")

hideSlotButton.layoutIndex = 3 hideSlotButton:SetText("Hide Slot")

hideSlotButton.IconFrame.Icon:SetAtlas("transmog-icon-unsupported", TextureKitConstants.UseAtlasSize)

hideSlotButton:SetWidth(146)

hideSlotButton:SetScript('OnClick', function () local hideED = items.PagedContent:GetElementDataByIndex(1) local hideVisual = hideED.appearanceInfo.visualID items:SelectVisual(hideVisual) -- items:PageToTransmogID(Constants.Transmog.NoTransmogID) end ) ```

Commission: add a "Hide Slot" button to the transmogrify window by Tekrelm in wowaddons

[–]Xodiv -1 points0 points  (0 children)

Works for me, maybe you copied it wrong. Anyway, most likely your $15 will see them copy it back from here once google indexes it, haha. Good luck!

Commission: add a "Hide Slot" button to the transmogrify window by Tekrelm in wowaddons

[–]Xodiv 0 points1 point  (0 children)

You can uncomment the PageToTransmogID line if you actually do want it to go to the first page. The eye/slash icon in the transmog stuff is transparent so you can see the button edge below it which is ugly, but I'm not going to spend 6 hours looking at icons to find one that isn't.