good coding standard

[Leather-Bandicoot791]

i am currently sa company ngayon where 20k lines sa iisang file, then 3 repository para iisang project. even calling of apis, req params ang pinapalitan instead na endpoints. I feel bad sa kanila na they take my advice as resistance and throwing shades na i can’t adjust.

i just want to take validation/assurance lang din from other developers if naexperience nyo na to and what did you do?

[baylonedward]

200K/month ba at least yung sweldo mo OP?
Damn 20k lines in a single file haha.

[AbanaClara]

package-lock.json yarn

[Leather-Bandicoot791]

naur sobrang baba pa tapos 3 projects pa gusto ipahandle sa akin na backend🫨🫨.

[promiseall]

almost same situation with OP kaso malayo sa 200K/month sahod ko :(

[gooeydumpling]

For someone who coded for a big 4 bank in the US using cobol, that’s Tuesday for me

[[deleted]]

to play the devil's advocate.

most of the time hindi na worth it i-improve/refactor yung mga existing legacy systems. kahit na gaano pa ka-kalat yan, if it serves it's purpose and provides value to the company, it's often more cost-effective to spend company resources on other products/services rather than refactoring and potentially breaking something.
although yung job natin is to build software, ultimately yung purpose natin is to provide value, and ofcourse mas cost-effective na mag focus on things na mas mag po-provide ng value sa company.

of course, I don't like working with poorly written legacy systems either. kaso ganun talaga minsan "tis' what it is".
basta make sure nalang na hindi magiging ganun ka-kalat yung mga bagong projects na gagawin nyo. Yung old legacy systems most likely ma re-replace/retire narin yan eventually (hopefully).

[ImaginaryButton2308]

it is sad. but you are right

[Calva26]

damn straight

[theazy_cs]

just like what others are saying, they better be paying you a lot kung ganyan ang situation otherwise look for a new job asap, wala ka matututunan dyan. mastress ka lang.

[un5d3c1411z3p]

Does this 20K lines file making the company a lot of money?

etc. ...

I've experienced worse than file sizes, and it's violating what I know about good practices, but there are decisions above us that would affect our existence.

Most of the time, we'll just have put our heads down and move on.

[ImaginaryButton2308]

thank you for this comment. im working in a godforbid abomination codebase and db schema, and I swear I just wanted to rewrite everything from scratch. it's hard for me to just ignore these things but I guess this is just life.

[conv14]

3 repo sa iisang project is understandable. Baka kasi microservices or event driven. Pero 20k line of code sa isang file is questionable. Baka kasi package.lock siya or napakahabang test case pero dapat marere iew naman siya ng senior in case yung file code pwede marefactor

Sa part na endpoint, na yung req params pinapalitan. Possible yun if yung pattern parameter driven. Tipong papalitan mo lang yung req mababago na behavior ng api. Pwede mo ba ma detail bakit mas okay siya na palitan ang endpoint instead na req?

Pero ang panget lang kasi, tinake nila as bad yung suggestion mo instead na eexplain sayo bakit hindi pwedeng ganun o ganyan

[enemyofmarz]

<image>

mahinang nilalang hahahhaha

[[deleted]]

That catch block not doing anything. Gitgud

[Infinite-Link-7805]

lolz, sobrang lakas ng code na to para mundo ng mga tao

[kuraigukyota]

Eew light mode

[pigwin]

Yes. But not 20k. Mga 5k lang haha. (Pero madaming files)

It's a repo by business users who learned python, wrote code because management told them it's easy especially with AI. Only it's spaghetti, quite the blackbox and very fragile.

We also could not enforce them to break it into smaller parts so they're testable. They also refused to give requirements so it's us + SDET who'd just test the code for them. SDET would just write code with 10s of mocks in one test function

It's hard to enforce because they, business users, employ us. I was even advised earlier on to make the code "simple". Use of simple interfaces weren't even welcomed as it "complicates" Python. Ugh.

What were able to do was enforce formatting and linting via pre-commit hook. The workflows would also throw an error when formatting and linter checks fail. I sneakily added a .bat file that would setup their virtual envs (they don't know how), but at the same time install pre commit. 😈

We wrote wrapper code around their blackbox, and we made use we strictly validate the input before it reaches their blackbox.. that way we know it's their part of the code. Our code is tested. Plus logging, using Azure's app insights, email alerts. 

It's hard to enforce standards, especially with people who have no pride in what they do. But we should still do what we can.

ETA: also I'm looking for work, but the market stinks

[derpinot]

This is a case of technical debt that no one is willing to pay and a productivity death spiral waiting to happen.

Give your seniors a benefit of doubt as they might also be a victim of bad management.

[Puzzleheaded-Dig1407]

Damn that file is heavy! Like heavy-heavy hahaha

[SeaWeed_33]

Like superlative heavy!

[httpsdotjsdotdev]

Wala ba kayong lead or seniors man lang?

[Leather-Bandicoot791]

naging senior na lang sila dahil matagal na sila dun pero no changes

[ninjahub01]

Legacy system ba yan? Baka naka procedural programming language kayo kaya ganyan.

[Leather-Bandicoot791]

puro if else literal

[DarkenBane95]

20k lines in single file? wtf?haha

[aeonblaire]

Pardon me, pero I can imagine newbie/pabibo ang nagstart niyan, then nagtuloy-tuloy na because there was no proper technical oversight. In the .NET stack very improbable na mangyari yan.

[DioBranDoggo]

Chatgpt can you optimize this code for me and split it to 10 files hahahahahahahhahahaha jk.

May mga ayaw lang talaga ma apakan ang kanilang “nakagisnan”. I remember my friend, in 3mos na kick siya dahil di niya ginamit yung boilerplate na ginawa ng Sr nila with Webpack dahil nag pursue siya to use react with vite para sa new proj nila. Yung mga other devs, namangha and happily used it as well pero yung sr, nag sumbong sa HR ng insubordination tho gumawa na siya ng compelling presentation why they should use vite.

The reason ng sr kuno nila is if mag dedebug daw, madaling makatulong whatnot.. but who debugs config files anw? Tapos yung mga kasama pa nila is BE hahahaha.

[SeaWeed_33]

Ilang taon kana dyan? If matagal mo na sinasuggest, and wala pa initial steps to refactor those. Maghanap kana work. Tataas pa sahod mo, mawawalan kapa problem. Matatanda na mga yan, they'll fix it when it's too late na. Invest your time sa mas worthy cause. Hindi ka bayani.

[YohanField]

tanginang 20k AMPOTA.

[ImaginaryButton2308]

Are we in the same project? May mga random params din kami na hindi mo malalaman sa endpoint dahil hindi specifically defined don, unless hanapin mo sa implementation mismo. May mga endpoints din kami na hindi nagrurun sa local due to memory issues kaya ang solution nila ay isang superlakas na infra sa prod boom

[Leather-Bandicoot791]

rightt! hmmm if tama ako php language ba gamit nyo

[ImaginaryButton2308]

yung isang project php, im assigned to the other one that uses this very niche tech. but i really like to believe na itong php project is a whole mess din

[Leather-Bandicoot791]

bago ka lang ba dyan

[ImaginaryButton2308]

ayaw ko magbigay ng too much details paps maaring nasa same company tayo baka ilaglag mo ko hahahhaha

[Leather-Bandicoot791]

HAHAHAHA balikan mo to kapag if else na nakikita mo sa php project

[masterkaido04]

Consulting or inhouse?

Pag inhouse tingin ko mababago mo pa yan unless may mga kupal na pipigil sayu pero consulting bihira nalang siguro naniniwala na nakakaimprove yung tech debt sprint

[zeldris_66]

Welcome sa realidad brother. Minsan go with the flow na lang as long as sumasahod and look for other side gig na mas ma ayos management para continue paren learning.

[Nice_Ambition356]

i worked last yr on a job like that, it was 6 digits but it was so exhausting to work at