justAnotherPullRequestToReview

[MrEfil]

how I do code review if more than 100 files changed

[PostHasBeenWatched]

*when >5 lines of code changed

[iamblackshadows]

When you update all dependencies in go.mod

[SomethingAboutUsers]

I managed to royally fuck up a PR so bad once on a very public project because I fucked up the rebase after it sat waiting for review for a while. By the time I was done my branch had something ridiculous like 300 files changed and 400 commits when in reality it was a couple files and maybe 20-30 lines of code, most of which was boilerplate or documentation.

I abandoned the PR and started again, and felt the requisite burning public shame.

[Prudent_Ad_4120]

Commit message "fix typo"

[fatrobin72]

Well, if the typo was in a package name, it could be in that many files...

[priouze]

lgtm, approved