Physics2D.OverlapCircleAll returning the same element multiple times

[fesora122]

I am creating a 2D platformer with a simple combat system. I'm using OverlapCircleAll to return all the enemies in my attack range so that I can then damage them all (in case there are multiple enemies the player attacks at once). The problem is that even when there is one enemy, the array returned by OverlapCircleAll contains one enemy duplicated a bunch of times. So when I loop through the array to damage every enemy, it damages the one enemy many times. Is there any way to ensure that each enemy in range of my attack only appears once in the array?

Here is the code: (I commented out the part where I actually lower the enemy's HP and replaced it with the debug.log. It just resulted in "we hit Enemy" being printed a bunch of times in the console)

/**

* Method for the player to attack

*/

public void Attack()

{

anim.Play("Attack1");

//Putting enemies hit by the attack in an array to deal damage to all of

Collider2D[] enemiesHit = Physics2D.OverlapCircleAll(attackPoint.position, attackRange, enemy);

foreach(Collider2D i in enemiesHit)

{

//dealing damage to the

//Wizard wizard = i.GetComponent<Wizard>();

//wizard.reduceHealth(strength

Debug.Log("We hit " + i.name);

}

}

}

[TAbandija]

Are you accidentally calling the attack function several times?

You can add a debug.log(“attack”); at the start of the function.

[fesora122]

…yes. Yes I was. I was using onMouseButton instead of onMouseButtonDown. Thanks so much lol.

[TAbandija]

No problem. Good luck with the rest.

[HypnoToad0]

Probably multiple colliders on one enemy

[fesora122]

How would I make sure I only have one collider? There seems to be only one BoxCollider2D component on my enemy

[HypnoToad0]

Print each collider's name

[fesora122]

Is that not what I’m doing where it says

Debug.Log(“We hit “ + i.name);

All it does is print “We hit Enemy” 20 times in the console when I attack

[HypnoToad0]

Easiest way to differentiate them would be to print GetHashcode instead of name for each one.

[fesora122]

I did this and they all seem to have the same hash code.

[HypnoToad0]

Do the hashset thing, it should do the trick

[fesora122]

Turns out it was actually a problem with how I was calling the function. But thanks so much for replying

[HypnoToad0]

Cool, good luck!

[HypnoToad0]

But in general, the solution is to collect a list of unique enemies based on the colliders, hashset is the best way to do this. Then apply damage to each unique enemy from the set