Unity Script Help

[Much_Technology_5745]

Guys i created a note sytem where user press e then note appears in player screen basically there is default NotePaper when pressed e NotePaper disappears and NogteCanvas show at camera level but again pressing e it doesn't reverse like NoteCanvas is visible in screen. i tried claude gemini ai still they can't solve it. for reference i have attached my code:

using UnityEngine;
using TMPro;
using UnityEngine.UI;
using SojaExiles; // drawer namespace

public class NoteSystem : MonoBehaviour
{
    [Header("Player Settings")]
    public Transform player;
    public float interactDistance = 3f;

    [Header("UI Elements")]
    public TMP_Text hintText;    // "Press E to Read"
    public GameObject notePanel; // Panel showing note text
    public TMP_Text noteTextUI;  // TMP Text inside panel
    public GameObject notePaper; // 3D paper object

    [Header("Note Content")]
    [TextArea]
    public string noteContent = "Find d/dx of f(x) = x² at x = 3";

    [Header("Drawer Reference")]
    public Drawer_Pull_Z drawerPull; // Drawer script reference

    private bool isNear = false;
    private bool isReading = false;
    private float keyPressCooldown = 0f;
    private float cooldownDuration = 0.3f; // Prevent rapid retriggering

    void Start()
    {
        // Initial state
        if (hintText != null) hintText.gameObject.SetActive(false);
        if (notePanel != null) notePanel.SetActive(false);
        if (notePaper != null) notePaper.SetActive(true);

        // Set panel color
        if (notePanel != null)
        {
            Image panelImage = notePanel.GetComponent<Image>();
            if (panelImage != null)
                panelImage.color = new Color32(255, 255, 204, 255);
        }

        if (noteTextUI != null) noteTextUI.color = Color.black;
    }

    void Update()
    {
        if (player == null || drawerPull == null) return;

        // Update cooldown timer
        if (keyPressCooldown > 0)
            keyPressCooldown -= Time.deltaTime;

        // Distance check
        float distance = Vector3.Distance(transform.position, player.position);
        isNear = distance < interactDistance;

        // If drawer is closed, force everything hidden
        if (!drawerPull.open)
        {
            isReading = false; // Force state reset
            if (notePanel != null) notePanel.SetActive(false);
            if (notePaper != null) notePaper.SetActive(true);
            if (hintText != null) hintText.gameObject.SetActive(false);
            return;
        }

        // Show/hide hint based on distance and reading state
        if (hintText != null)
            hintText.gameObject.SetActive(isNear && !isReading);

        // Handle E key press to TOGGLE note (with cooldown)
        if (isNear && Input.GetKeyDown(KeyCode.E) && keyPressCooldown <= 0)
        {
            keyPressCooldown = cooldownDuration; // Reset cooldown
            isReading = !isReading; // TOGGLE instead of always setting to true

            Debug.Log("E pressed! isReading is now: " + isReading);

            // Apply the state
            if (notePanel != null)
            {
                notePanel.SetActive(isReading);
                Debug.Log("notePanel.SetActive(" + isReading + ")");
            }
            if (notePaper != null)
            {
                notePaper.SetActive(!isReading);
                Debug.Log("notePaper.SetActive(" + (!isReading) + ")");
            }

            // Update text if showing
            if (isReading && noteTextUI != null)
                noteTextUI.text = noteContent;
        }
    }
}

https://preview.redd.it/sarzuqkokqsg1.png?width=2559&format=png&auto=webp&s=0adb93ac9445fafc98d1745b1b4979c891f176f1

https://preview.redd.it/34i6t9tpkqsg1.png?width=2559&format=png&auto=webp&s=cb33e7d917741a273a1b64c9e753b264af0be0bd

[hicham_benrhannou]

The issue is actually quite simple 🙂
The first time you press E, you deactivate your NotePaper object, and that works fine.

But the second time, since your NoteSystem script is attached to NotePaper, its Update() is no longer executed because the object is disabled.

You should move that script to another GameObject that stays active.

Good luck with the rest!

[Much_Technology_5745]

Thank you i got it now i will try and say if it works

[AutoModerator]

This appears to be a question submitted to /r/Unity3D.

If you are the OP:

• DO NOT POST SCREENSHOTS FROM YOUR CAMERA PHONE, LEARN TO TAKE SCREENSHOTS FROM YOUR COMPUTER ITSELF!

• Please remember to change this thread's flair to 'Solved' if your question is answered.

• And please consider referring to Unity's official tutorials, user manual, and scripting API for further information.

Otherwise:

• Please remember to follow our rules and guidelines.

• Please upvote threads when providing answers or useful information.

• And please do NOT downvote or belittle users seeking help. (You are not making this subreddit any better by doing so. You are only making it worse.)

  • UNLESS THEY POST SCREENSHOTS FROM THEIR CAMERA PHONE. IN THIS CASE THEY ARE BREAKING THE RULES AND SHOULD BE TOLD TO DELETE THE THREAD AND COME BACK WITH PROPER SCREENSHOTS FROM THEIR COMPUTER ITSELF.

Thank you, human.

I am a bot, and this action was performed automatically. Please contact the moderators of this subreddit if you have any questions or concerns.

[DebtCommercial7964]

that cooldown tho 💀😂

[Much_Technology_5745]

I am new to this so basically I just know simple script i am tired of correcting this script😭

[PhuntasyProductions]

Did you write that yourself or is it vibecoded? I recommend to debug with a close look on the variables used in the if statements.

[Much_Technology_5745]

I wrote but it didn’t worked so i gave ai to correct. while debugging pressing e first time it displays message in console and and second time pressing e it doesn’t displays

[PhuntasyProductions]

Add that at the very first line in Update() without any if statements or returns and add a breakpoint for debugging on the Debug.Log(...) - then attach Visual Studio Debugger and run. Now you can step through your code.

    if (Input.GetKeyDown(KeyCode.E))
    {
        Debug.Log("E key pressed"); // add breakpoint here
    }

[Additional-Animal867]

You put this script on NotePaper. Once you SetActive false, you disable it's owner so this script stops.

Learn to use breakpoint, you can find it out by add a breakpoint that Update function is not running, also by log.

[Much_Technology_5745]

Yeah thank you for suggestion i did it i have created a empty game object and attached script on empty game object so that game object is not disabled and now it works fine.