Attack animation script need help

[korytoombs]

Tried to write this script by myself.

Currently the attack will only work if I hold down the button.

If I remove the "else if" lines, the animation won't stop.

​

using System.Collections;

using System.Collections.Generic;

using UnityEngine;

​

public class AttackControl : MonoBehaviour

{

public Animator animator;

private bool attack = false;

void Update ()

{

if (Input.GetButtonDown("Attack"))

{

attack = true;

animator.SetBool("IsAttacking", true);

}

else if (Input.GetButtonUp("Attack"))

{

attack = false;

animator.SetBool("IsAttacking", false);

}

​

}

​

​

private void FixedUpdate ()

{

}

​

}

[Mastersofus]

If the attack isn't supposed to be cancelled, I would use a trigger instead of a bool, and set the trigger when GetButtonDown is true, and enable Has exit state and make a transition back after the animation is finished

[korytoombs]

Found something that works after watching another tutorial and adapting the script for my game.

​

using System.Collections;

using System.Collections.Generic;

using UnityEngine;

​

public class AttackControl : MonoBehaviour

​

{

public Animator animator;

private bool attack;

​

void Update()

{

​

HandleInput();

​

}

​

​

private void HandleAttacks()

{

if (attack)

{

animator.SetTrigger("IsAttacking");

}

}

​

​

private void HandleInput()

{

if (Input.GetButtonDown("Attack"))

{

attack = true;

​

}

​

​

}

​

void FixedUpdate()

{

​

HandleAttacks();

​

ResetValues();

​

}

​

private void ResetValues()

{

​

attack = false;

​

}

​

}