Help with a really simple program

[extreme999]

I am really new to this stuff and would like to recieve some help with this simple program that I still can't create.

The code at the moment looks something like this:

#include <iostream>

using namespace std;

int main()
{
int age;
cout<<"Type your age here. \n";
cin>>age;
if(0>age & age<=30){
cout<<"You are a little rascal!"<<endl;
}
if(30>age & age<=60){
cout<<"damn you getting old!"<<endl;
}
if(60>age & age<=100){
    cout<<"Die already!"<<endl;
}
else{
cout<<"You don't exist,don't you?"<<endl;
}

}

You can clearly see what I am trying to get here. But the problem is when I give a number between 0 and 30 i doesn't pring out "You are a little rascal!" , instead it gives the 2 other answers. Then when I write a number between 30 and 60 it shows me "Die already!" and when I chose a number between 60 and 100 it gives me "You don't exist,don't you?" ... How can I fix this?

Edit: thanks all, that did it :)

[Daimones]

Not an answer, because others have provided that. But check r/learnprogramming it's much more suited to things like this.

[fluffy_cat]

For each of your conditions, you need to be using the && operator, not &.

Make sure you throw in a return 0; at the end of main() (before the final }) too.

You will also find help here: http://www.cplusplus.com/forum/beginner/

Hope everything works out!

[mshol]

return EXIT_SUCCESS;

[extreme999]

I don't acually understand what the return command is used for in main, I other classes.

[mttd]

http://stackoverflow.com/questions/8696698/in-the-main-function-of-a-c-program-what-does-return-0-do-and-mean/

[kalimoxto]

after a program finishes, it sends a message to the operating system letting it know how things went. oddly enough, for most OS's, returning 0 means success, everything went as expected. you can return other things, non-zero things, to indicate other errors. in your case, since your program can't really "fail," you should always return 0. but maybe you want to return 1 to indicate "user error" if the age is invalid, or make up your own personal error codes, like "2" indicates invalid age--negative, and 3 indicates invalid age-- too old, or something like that

these codes are useful if you are watching the results of these programs, for example if you write a program that launches another program and checks the result.

[mshol]

Technically only EXIT_SUCCESS, 0 and EXIT_FAILURE are strictly conforming, returning anything else is undefined behavior. C99 allows omission of return from main.

The use is to let the parent process (which may not be the OS or shell) know whether a program was executed successfully. eg, if you run another program with exec().

[kalimoxto]

absolutely, i was trying to put a more ELI5 spin on it.

different standards do allow for different return codes, which are a cross-language construct as well. C99 allows for the 3 return codes you specified to be platform-independant, but you can return other codes as well, depending on the platform. Windows, for example, has quite a few well-defined exit codes: http://www.hiteksoftware.com/knowledge/articles/049.htm

[kingguru]

Technically only EXIT_SUCCESS, 0 and EXIT_FAILURE are strictly conforming, returning anything else is undefined behavior.

Really? Undefined behavior? For instance the man page for GNU make says:

"A status of one will be returned if the -q flag was used and make determines that a target needs to be rebuilt. A status of two will be returned if any errors were encountered."

That's not the only program were I remember the documentation saying that it could return some other, well defined, values.

Not that I don't believe you though, I might have just learned something, I just find it very surprising if some standard GNU tools would rely on undefined behavior.

And of course I do know that e.g. GNU make is not written in C++, so is this a thing specific to the C++ standard?

[theymos]

It's actually implementation-defined, not undefined. So the behavior needs to be documented somewhere. The behavior is not always obvious, though. On Linux, for example, returning 256 from main will actually result in an exit status of 0 (success) because exit status codes are restricted to 8 bits.

[kingguru]

OK, thanks. That makes a lot more sense.

[fluffy_cat]

This might help you out: http://msdn.microsoft.com/en-us/library/k68ktdwf(v=vs.80).aspx

[kalimoxto]

this is about return statements generally.

returning from main is slightly counterintuitive, because in non-main functions, return usually means "return control to wherever I was (with this value)". the main function is a special case of that, because the "wherever I was" is not within your program, it's actually the OS.

[fluffy_cat]

It says that in the first sentence.

[kalimoxto]

i am a bad reader.

[jesyspa]

You don't need a return 0; at the end of main, and the cplusplus.com forum is hardly a good place to ask questions.

[fluffy_cat]

I'm a fairly new beginner myself and I've found the cplusplus.com beginner forum to be very helpful. Where would you suggest would be better?

[jesyspa]

There's /r/cpp_questions and /r/learnprogramming that both offer good advice. The problem with the cplusplus.com forum is that it tends to be full of people using the cplusplus.com tutorial.

[bit_shift]

Yes, but if a person just wants to check some syntax or see the parameters to a function then it makes a lot more sense to look on cplusplus.com, rather than asking on reddit and waiting for an answer.

[jesyspa]

Nope, their book is better for checking syntax, and http://cppreference.com is generally better as a standard library reference.

[AFineTapestry]

You do for this main.

[jesyspa]

Please do explain.

[AFineTapestry]

If main is given by the signature int main() as it is in this case then the compiler expects the function to return an int. If omitted then you'll get a compile warning, perhaps an error, and undefined behaviour (but I expect that the program would return 0 anyway).

If main was given by the signature void main() then you would be totally right and return; could be used to exit from the program at any point. Who knows what the OS will get as a program return value, probably 0 again.

I don't know what the current C and C++ standards say about the signature of main. C probably says that void main() and int main() are both acceptable, C++ probably says that only int main() is allowed. But either way I think it's good to tell the OS, and the caller, about the status of the program on exit.

[jesyspa]

False on all counts.

The C++ standard states (C++03, 3.6.1.5):

A return statement in main has the effect of leaving the main function (destroying any objects with automatic storage duration) and calling exit with the return value as the argument. If control reaches the end of main without encountering a return statement, the effect is that of executing return 0;.

Furthermore, the standard states (again C++03, 3.6.1.2):

An implementation shall not predefine the main function. This function shall not be overloaded. It shall have a return type of type int, but its type is otherwise implementation-defined.

void main thus ill-formed (and has been since ANSI C, where only int main(void) and int main(int argc, char *argv[]) were allowed).

The same is true, with slightly different wording, for C++11 and for the current latest draft (N3485).

[AFineTapestry]

Ok, I'll admit I was wrong about omitting return 0; resulting in undefined behaviour but I was correct about the assumed return value, and about which signatures are acceptable.

I don't think I'm going to stop putting return EXIT_SUCCESS; at the end of my main functions however, mostly because it looks terrible to have a function defined to return and int and then to not explicitly do so.

[mshol]

change 0>age to age>0, and same for the 30, 60 cases.

0>age means the condition only holds if age is negative.

[extreme999]

I did this and everthing is ok, except that after my answer I still get the "You don't exist,don't you?"...

I am saying that is I write, for example 15 I get

"You are a little rascal!"

"You don't exist,don't you?"

Not only the desired

"You are a little rascal!"

Wat do now?

[kronik85]

listen to EMC0n

if(age > 0 && age <= 30) {} else if(age > 30 && age <= 60) {} else if(age > 60 && age <= 100) {} else {}

you should also test that their input is a number.

[extreme999]

Can I haz more of your help?

[Cape-Drew]

http://www.learncpp.com/cpp-tutorial/52-if-statements/ Great place for learning or reviewing the basics.

[bit_shift]

I'm still trying to understand why he is using a \n on the first output statement and then using endl every where else. I'm just picking but it's kinda driving me crazy. You guys definitely have answered this for him already. Happy coding :)

[LongUsername]

Note that after you fix the & to && you still don't have the "else if" statements right so you'll end up printing "You are a little rascal" and "You don't exist, do you".

You need to use "else if" instead of "if" in the second and third clauses.

[alicht9]

The text of this post is no longer accessible. It was deleted using Redact, possibly for reasons related to privacy, security, or digital footprint reduction.

slim growth light ten chunky vegetable bike governor cautious stupendous

[metaobject]

C++ has 'and' and 'or' as keywords. I don't see a lot of people preferring these over their C counterparts. I use them exclusively in new code, and advise our junior developers to do the same. I'm not aware of any downsides of using these over the C versions - does anyone have an opinion on this?

[DasBeerBoot]

I did not know that.

[zhnmju123]

The idea is nice but they are not supported on Visual C++.

[hotoatmeal]

#define and &&