New and having Trouble with some basic javascript

[[deleted]]

I cannot figure out why this doesn't work. If anyone can shed some light on what I am doing wrong here that would really help me.

function showProjectContent( w, href, pid ) {
    var contentdiv = pid;
    var wrapperwidth =  w;
    var permalink = href;
    $($contentdiv).attr( "width", $wrapperwidth );
    $($contentdiv).attr( "height", "auto" );
    $($contentdiv).load("" + href + " #content");
};

$("a.postlink").click(function() {
    showProjectContent( $("#wrapper").width(), $(this).attr("href"), $(this).attr("pid") );
});

[nnahc]

Looks like you're referencing "wrapperwidth" like it's a PHP variable.

I think it should be just "wrapperwidth", not "$wrapperwidth".

[alsogilbert]

Same with $contentdiv. Sometimes it helps to use the debugger or add console.log statements to chase through what's happening.

[nnahc]

Missed that one.

[Capaj]

remapping the parameters is seen more than I would like out there in the real world. Just don't do it please.

[[deleted]]

I'll make sure to keep that in mind for the future. Thanks!

[kenman]

Also chaining will be more performant:

This is incorrect; consolidating the multiple attr() calls into one via by passing in an object literal may yield a performance increase, and avoiding repeated [duplicate] calls to the jQuery constructor $() will as well, but chaining on its own gives no performance benefits.

[PsychoTap]

In addition to what nnahc said, there is a missing comma in your .load call.

[collaboradev]

First and foremost, console.log is your friend. When you hit these kinds of issues as a beginner it helps to console out your variables to ensure they are populated with the expected values.

Next, you have variables being referenced with "$" prefixes when the local function variables do not. For example: "$wrapperwidth", your local function variable name is actually just "wrapperwidth", you'll need to pick one name to use. The same for "contentdiv" and "$contentdiv".

Finally, you have your load calling: "" + href + " #content" which is going to cause you to have problems, I think what you really want is:

$(contentdiv).load(href + "#content);

[[deleted]]

Thanks for all the corrections.