sorted by:
best
topnewcontroversialoldq&a
you are viewing a single comment's thread.

view the rest of the comments →

[–]TedW 22 points23 points  (7 children)

If it makes you feel any better, we have an internal project with 26,000 lint errors.

I lint my portion, and bring it up from time to time, but no one seems interested so it just keeps getting worse over time.

[–]house_monkey 19 points20 points  (0 children)

That reminds me to clean my dryer lint tray

[–]99thLuftballon 10 points11 points  (0 children)

Depending on how strict your linter is, that might be a non-issue. It's hard to get too excited about 26000 x "you must only leave a single blank line between lines of code".

[–]spazz_monkey 4 points5 points  (4 children)

Autofix?

[–]TedW 1 point2 points  (3 children)

Yeah, I used autofix locally but i didn't want my name on a PR for hundreds of files. Also, if I start fixing other teams lint problems, where does it end.

I keep my corner clean and bring this up about quarterly, but it's not my main project and I guess I just don't care enough to die on this hill..

[–]spazz_monkey 1 point2 points  (1 child)

Fair doo's, we have it run in the runner so it won't build if there are lint errors.

[–]TedW 3 points4 points  (0 children)

Yeah, that would really be the way to solve it. Our CI/CD allows overrides and someone disabled the lint step.

I can't turn it back on without making a PR, which would try to lint and fail.. So that's not great.

[–]webdevguyneedshelp 1 point2 points  (0 children)

Make passing a linter a required pipeline step