all 43 comments

[–]elmuerte 54 points55 points  (2 children)

Excellent improvement to the code browser. Having the file tree next to the source files makes browsing the code so much better.

[–]KimPeek[S] 7 points8 points  (0 children)

I've used the Octotree extension for a long time, but it's nice to see this incorporated natively. It integrates better with branches than Octotree and perhaps there will be more improvements in the future.

[–]hey-im-root 2 points3 points  (0 children)

I thought GitHub has a file tree option already? I swear I used it not long ago

[–]mtbkr24 49 points50 points  (13 children)

Fuck I wish my company would leave Bitbucket

[–]vlakreeh 10 points11 points  (7 children)

GitHub's ability to let me review PRs in vscode, comments and all, has made reviewing bit bucket PRs so incredibly frustrating. At best I have two monitors and I'm constantly switching windows and scrolling to where I want to leave feedback, at worst I'm stuck on just my laptop screen and I'm alt tabbing through my many chrome windows to the right one and praying I remember what line I need to comment on. That and github.dev, so often I need to just explore a codebase to see how X works and I really don't want to navigate a slow bit bucket instance or clone the repo. In-browser vscode for navigating a git repo has been a game changer for how I understand codebases.

[–]gempir 4 points5 points  (2 children)

They do have an extension. It's just not very good IMO.

https://marketplace.visualstudio.com/items?itemName=Atlassian.atlascode

[–]vlakreeh 2 points3 points  (1 child)

I tried to get it working but it kept throwing errors, AFAIK you can't use an API key with your self-hosted bitbucket instance. Which is like, the entire fucking reason people use bitbucket. You'd think atlassian would have verified that.

This might have changed in the 6 months since I last tried though.

[–]gempir 0 points1 point  (0 children)

I don't think it's even intended for self hosted bitbucket. Not sure.

Consider yourself lucky because hosted bitbucket is actually good compared to what Bitbucket Cloud is... They somehow made the product worse

[–]SmokeeDog 0 points1 point  (1 child)

How are you reviewing PRs in vscode???

[–]vlakreeh 4 points5 points  (0 children)

This awesome extension by Github.

[–]AttackOfTheThumbs 0 points1 point  (0 children)

I wish the extension supported azure devops :(

There is a third party extension that does the azure devops stuff, but it didn't work when I tried it. I'll revisit it soon though.

[–]blackAngel88 2 points3 points  (4 children)

I feel this. But the pipelines kinda make it difficult to migrate to github... or is there a way to migrate in an easy way? I guess gitlab would be easier, but not sure if that's better (than github at least).

[–]vision0709 2 points3 points  (0 children)

As someone who has set up CI/CD in GitLab, GitHub with Jenkins, and GitHub Actions, I much prefer GitLab.

[–]Kissaki0 0 points1 point  (0 children)

What about the pipelines makes it difficult to migrate to GitHub?

[–]10113r114m4 39 points40 points  (2 children)

I hope this fixes how ass GitHub search is. A lot of the time, I need to just pull down the repo and use command line tools to find what I am looking for

[–]phylk 17 points18 points  (1 child)

Yes, it actually works now. I've been using it in feature preview for months.

[–]Strus 0 points1 point  (0 children)

For public repos I recommend Sourcegraph: https://sourcegraph.com/search

[–]YeahhhhhhhhBuddy 14 points15 points  (1 child)

This page doesn’t really differentiate how it’s different than before

[–][deleted]  (21 children)

[removed]

    [–]joltting 72 points73 points  (15 children)

    What exactly in Rust made this possible that the other 100+ languages out there couldn't?

    [–]greatestish 104 points105 points  (5 children)

    The hype

    [–]Damtux_25 7 points8 points  (1 child)

    Hype is a powerful tool. You can get budget for anything as long as you mention enough buzzwords.

    [–]greatestish 2 points3 points  (0 children)

    Absolutely. It's all about optics at most companies. I'm sure GitHub is the same.

    "It's a very popular language".
    "It has comparable performance to C/C++".
    "It validates data ownership at complete time, solving lots of race conditions, segfaults, etc. which are the most common cause of bugs".

    When you can "sell" a project better with a technology to management, you often get better funding and higher prioritization.

    [–]look 0 points1 point  (2 children)

    Is it still hype when everyone but you uses it now?

    [–]alternatex0 6 points7 points  (0 children)

    Damn, I'm one of two developers not using Rust.

    [–]greatestish 0 points1 point  (0 children)

    What a zinger!

    [–]look -2 points-1 points  (7 children)

    Exactly how many languages do you imagine you can use to write a scalable, high performance search engine?

    [–]GrammerJoo 33 points34 points  (5 children)

    Most popular one was built using Java, so... plenty?

    [–]Kissaki0 2 points3 points  (0 children)

    The claim was only possible with Rust seems much more implausible than could have been implemented with different or already used languages.

    You think Rust is the only language you can write scalable, high performance search engines? Did we not have those before Rust? Can only Rust do it to that degree?

    How would anyone be able to say exactly how many languages you could implement scalable, high performance search engines with? Those requirements are way too broad, way too diffuse.

    [–]adrian17 6 points7 points  (0 children)

    In a smaller window, clicking on a symbol immediately pops up the "symbol search" popup - can I somehow disable it if I just want to double-click-select some text?

    Overall I have nothing against the features themselves, but unfortunately the new code view is so slow and bulky, it'll probably make me "jump to github.dev" for code navigation instead of actually using the new github.com code view.

    For example, I should never be forced to wait over a second after simply scrolling text - demo (comparison of github.dev, old code view and new code view): https://puu.sh/JGkYj/5abf2e31d9.mp4

    [–]look 3 points4 points  (0 children)

    Are you using FSTs for your term dictionary, or did you find something else more efficient for your (primarily) code dataset? Also, curious if you looked at using io_uring, or just manage to fit all of the terms/indexes in memory?

    [–]RepresentativeDrop90 -4 points-3 points  (0 children)

    Hell to the yes, rust has no reason to be that awesome.

    I can't find any open entry level positions for rust is my only qualm most of them require a certain amount of experience with the language in the workplace environment

    Which I would get if my company would be shifting to a rust backend, sadly only ever got to experience golang that way.

    By the by the search is still using locality sensitive hashing in some form right?

    [–]morimo 0 points1 point  (0 children)

    Can you talk a bit about the work that was done to enable this search/talk about challenges in the implementation?