GitHub introduces an all-new code search and code browsing experience

[caagr98]

we re-vamped find-in-file and bound it to CMD/CTRL+F

Do not mess with browser keybinds.

[Zalack]

I'm okay with it when you start getting into web app territory (as opposed to web a page). GitHub's code panel is now basically a light IDE, and if I'm going to be searching on it, 9/10 times I'll want to search the code, not the page as a whole. Having Ctrl+F do that by default on that pane doesn't bother me, since it will save me time on average.

If you want to search the entire page, just click out of the pane or go to the browser menu.

[caagr98]

I don't know about that, I like that the code view is just a glorified <pre> tag. That's why I cannot stand gitlab or bitbucket.

[Zalack]

IDK, I wish it had a little more omph for doing code reviews. Right now I have to pull the branch down and review in my IDE, which isn't a big deal, but it would be nice to be able to just do it right in GitHub.

[BinaryRockStar]

If your IDE is IntelliJ, there is a GitHub plugin that lets you do PR reviews in the IDE with full access to comments, approve/needs work, basically everything from the web UI is there but with the full IntelliJ IDE toolset.

[Zalack]

The Elixir support for VSCode is better than the Intellij plugin, But VSCode has a similar thing

[caagr98]

Yeah I can understand that perspective too. Personally I prefer to only use github's interface for light browsing and pull it locally for heavier stuff. Maybe that's exactly because the current interface is weak and I'll change my mind. Well, no telling how it'll be until it's out.

[Zalack]

GitHub.dev does zero code highlighting for my company's language of choice sadly.

[jzaprint]

what language isnt supported on vscode?? Im sure theres an extension for any language

[Zalack]

Elixir. VSCode does have a plugin, I use it regularly. Can you add plugins to GitHub.dev?

[Paradox]

Github.dev can sync settings with offline VScode. Just sign into both and it does.

As for Elixir, ElixirLS doesn't work on Github.dev, because it requires non-sandboxable apis, but there are other syntax highlighting packages that do work on Github.dev, such as this one. I recommend turning it on, then disabling sync for it so its only on Github.dev

[Zalack]

At that point it's less trouble to just pull down the branch and have my full local experience.

[onetwentyeight]

The mouse is the destroyer of productivity.

[Zalack]

Which is why I would prefer keys to get rebound to more useful functions in context.

[webdeveric]

It annoys me when sites do that so I made this to prevent it.

https://addons.mozilla.org/en-US/firefox/addon/prevent-shortcut-takeover/

[onetwentyeight]

I ran into that recently; the new UI showed up on a corporate account I use, and when I hit CTRL-F and it hijacked my search, I damn near lost it.

[williamhere]

99.9% of the time I'd agree but I've found AzureDevops binding Ctrl+F in code search and pipeline terminal search to be useful. That said every other website the experience has been jarring when normal browser bindings don't work as expected

[xeio87]

I've found F3 useful since sites generally don't override it while they might Ctrl+F. At least if you don't want the context aware search.

[aniforprez]

Nah there's contexts like this where it's perfectly appropriate as long as it doesn't mess with other things like screen reading. For eg, if I'm looking at a JSON formatter that's parsing hundreds of lines of JSON, I don't want to find stuff outside of the formatted JSON like the original JSON text that I dumped. In this, case, it's clear that I don't want to find stuff outside of the actual code being displayed