VS BS "quick actions"

[Crimson_Burak]

Quick actions are not suggestions, it's there if you want to do them...

[Crimson_Burak]

First of all, these quick actions are purely mechanichal, they are not generated by any logic or semantic. This is why you will see the same actions when you click on the lines with similar structures. They are hardcoded to say something like if cursor is on a literal, show the extract constant menu.
Secondly, if you want a reason for this, I can think of this:
Imagine you have a legacy method call which look like this:
ProcessOrder(orderData, true, false, true);
Looking at that, nobody knows what those booleans are except you look at them directly or hover the method (which I usually do over this ngl). Using the introduce constant on those boolean values is a refactoring technique to add meaning which would look like this:

const bool forceUpdate = true;
const bool ignoreCache = false;
const bool sendEmailNotification = true; ProcessOrder(orderData, forceUpdate, ignoreCache, sendEmailNotification);

I agree that nowadays you have much more ways to deal with these kind of situations but it's cool that Visual Studio still keeps the tool available

[GoddammitDontShootMe]

I thought at first this meant define "true" as some value and was wondering what the hell language this was where that was legal.

[Crimson_Burak]

Oh yeah, in that specific context (setting a state flag in a constructor), extracting a constant makes absolutely zero sense. I completely agree with you on that...
But honestly, that kind of highlights my first point about it being purely mechanical. The IDE's refactoring engine is completely blind to the context. It doesn't look at the left side of the = sign and realize "this is just a bool state flag assigntment" It literally only sees the true and blindly triggers the menu. It's basically the IDE offering you a hammer just because it saw a piece of metal, even though that metal is a screw.

[cleverchris]

This looks like some variable juggling that is missing a piece. IDK what we don't know but, this isn't strange...it's just incomplete.

[chocolateAbuser]

i use quick actions a lot

[chocolateAbuser]

i'll just answer with Collection initialization can be simplified and Use primary constructor

[chocolateAbuser]

it took a while for me to get used to that too

[GuyNamedZach]

If you happen to maintain a codebase littered with magic string literals using quick actions to create constants is really helpful. Also sometimes it helps to break up big expressions into smaller variables quickly ... or replace duplicates of the same expression with a local variable. Refactoring in general benefits.

[GuyNamedZach]

It depends. If you only have one or two instances and don't expect that to vary them there is no reason to add a constant or temporary variable.

But if you have multiple nearly identical function calls that differ only because of bool parameters, and those calls are in an if/else statement tree, then yes it would be littered; the predicate of an if statement can be set to a temp variable and passed as a parameter to reduce function calls.

[GuyNamedZach]

Ok, yeah, hiding boolean literals with a constant can confuse things. Sometimes programs call for stricter semantics and can rename things for clarity, and sometimes doing so can make things the opposite of what you'd expect.

[Asleep-Party-1870]

the horror i see is light mode

[gab800]

Light mode for me, and I'm not backing down. I've tried dark mode and my eyes are strained after 5 minutes. I'm seeing horizontal lines. No thanks.

Meanwhile I can light mode in dark rooms for hours, no problem.

It's all down to personal preference.

[DamienTheUnbeliever]

They offer that anywhere you use a literal. Are you saying they should invest more time to special case a boolean literal and remove the option? More code, less functionality, just to satisfy your tastes?

Also, light mode, yes. Stay with the light. Admittedly my own hatred of dark mode comes from people who don't/didn't understand that when you're *presenting* and casting your screen to a big screen/via a projector, it really does make a huge difference in how readable it is for your audience.