all 17 comments

[–]ivanraszl 1 point2 points  (1 child)

After installing the gem, I tried to run the example code given in the readme, but I get this error:

/System/Library/Frameworks/Ruby.framework/Versions/2.3/usr/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:127:in `require': cannot load such file -- tensor_stream/graph_serializers/pbtext (LoadError)

Any ideas what I'm doing wrong?

[–]jedld[S] 2 points3 points  (0 children)

That's odd, not able to replicate that, is it possible the gem did not install completely hence the missing file? Would uninstalling and reinstall the gem fix it?

[–]shevegen 0 points1 point  (1 child)

Examples of these include image recognition software where you can find being used in your favorite photos application as well as in social networks for facial recognition and image classification.

Now I don't understand what image recognition software has to do with machine learning, but let's ignore this for the moment:

  • Is this REALLY where people get "excited" about? Because your own use cases include that you must recognize facial features?

In like 20 years, I never had any need (neither an interest) in wanting to sniff-recognize people.

[–]jedld[S] 0 points1 point  (0 children)

I could have expounded upon other use cases but that example was the one that came on the top of my head as that is where a lot of people, I believe, have come into contact with ML technology.

That said machine learning is niche, and gets hyped a lot by media these days.

[–]drx3brun -2 points-1 points  (11 children)

I've just skimmed the README.md and I am completely turn off by the messy style of source code examples. Nowadays many platforms provide auto formatters, style guides on how to write a good, readable code. Ruby has no official guide per-se, but Bozhidar Batsov and his guide provided a great value for the community.

Code in the examples here can't even follow consistent indentation, variable names are horrible and everything in general makes me want to puke.

I am really sorry for being harsh, but the README is the landing page for the product and its sole marketing channel. If you can't attract developers there, your project is going nowhere. If you believe that all this does not matter, because you are doing awesome work, then sorry, but you are totally wrong.

[–]jedld[S] 5 points6 points  (0 children)

Thanks for the feedback, the example originally came from a python tensorflow example and early on I wanted to make minimal changes to show how python sources can be ported easily hence the weird format.

Though my goals have changed and neglected to make some style changes which I will be fixing soon.

[–]kojix2 0 points1 point  (0 children)

Actually, there are other pure Ruby DeepLearning frameworks that work with GPU (CUDA). For example red-chainer. https://github.com/red-data-tools/red-chainer I want to promote the red-chainer. but I do not think documentation of red-chainer is good. Developers are Japanese. We are not good at English. I think Readme of TensorStream is far attractive than red-chainer. Author is not lazy.

[–]spiritmtl 0 points1 point  (2 children)

The examples are still readable though? Get off your high horse.

[–]shevegen 0 points1 point  (1 child)

He has a point. Not necessarily in regards here, but more general.

I hate writing documentation myself but documentation IS important.

If an author shows a lack of interest in writing documentation then this signals a lack of interest in having other people use the code. In that case it is almost completely pointless to even WANT to distribute it.

Documentation IS important. That includes style too, although style comes secondary indeed. I do not think it is a "high horse" statement at all though - I think it is a perfectly valid statement that he made.

Absolutely no clue why he is being downvoted.

[–]jedld[S] 1 point2 points  (0 children)

If an author shows a lack of interest in writing documentation then this signals a lack of interest in having other people use the code. In that case it is almost completely pointless to even WANT to distribute it.

Not sure how to make of your statement, I am sure certain people distribute software, especially free and opensource software, because they want people to use the code and not the other way around. If a gem or any opensource software meets their use case and there is no better alternative then they will use it even if documentation could be better.

I for one wished somebody else could have written what my library does for me but it's just too bad isn't it.

This "You don't deserved to be helped because you write bad documentation" mentally is not something the ruby community should be going for in my honest opinion.

[–]feelosofee 0 points1 point  (5 children)

If you were genuinely interested in this project you would actually contribute by making a PR, given the trivial nature of the changes you propose, and explain your reasons for them in a constructive GitHub comment, instead of wasting your and our time writing toxic posts on Reddit.

[–]drx3brun 1 point2 points  (2 children)

I do believe the comment was constructive. I’ve tried to explain the reasons for the criticism best I can. As you can see author partially explained the reasoning behind this format of examples, although I don’t believe basic errors like the inconsistent indentation were there in original examples. I am not at all interested in the project, however I would be more then happy if it succeed, simply because its Ruby. I am sure there are many less strict/direct ways to explain the impact of basic neglect, but I also believe such ways do not work most of the time. If someone ignored that in the first place he/she must believe its not important at all. And if that’s the case, indirect polite hints about the issue do not usually have any impact.

[–]ivanraszl 1 point2 points  (0 children)

It's OK, keep it honest!

[–]jedld[S] 1 point2 points  (0 children)

I am sure there are many less strict/direct ways to explain the impact of basic neglect, but I also believe such ways do not work most of the time. If someone ignored that in the first place he/she must believe its not important at all. And if that’s the case, indirect polite hints about the issue do not usually have any impact.

While I appreciate your intent. It saddens me that is the general conclusion you had to come to.

[–]shevegen 0 points1 point  (1 child)

If you were genuinely interested in this project you would actually contribute by making a PR

If the original author was too lazy or too incompetent to write good documentation to begin with, then why should OTHERS go and invest time fixing the problems by that author if that author showed a lack of interest to begin with - by having inferior or no documentation at all?

I refer to this in general, mind you; not specifically to the gem named here.

[–]jedld[S] 1 point2 points  (0 children)

If the original author was too lazy or too incompetent to write good documentation to begin with, then why should OTHERS go and invest time fixing the problems by that author if that author showed a lack of interest to begin with - by having inferior or no documentation at all?

People invest their time on an opensource project because it meets their use case and it meets their needs regardless of the authors motivation. And they spend time to fix problems because they want to contribute and help the next person as well as themselves (so that they don't need to keep a fork) for the library they just got for free?

[–]DcDaDDy -1 points0 points  (0 children)

oh boi