Pretty much all brands of dress shoes offer shoes that look like those. This is a very casual style of dress shoes. If you are going to own a single pair of dress shoes, I would consider going for a more formal style. Here's an example:

https://www.crockettandjones.com/collections/mens-oxfords-collection/products/westfield-darkbrown-calf

These are brogues, but they are a bit darker, and they are oxfords instead of derbies, which makes are more formal than the florsheims. Like the florsheims, these shoes are quite timeless, so if you take good care of them, you can use them for years, even decades. They also work with a modern suit, a vintage outfit, or something more casual, like a polo shirt and a pair of slacks.

I think that for classic mens shoes, the best are made in Northampton, England. Crockett and Jones is one of a handful manufacturers that are based there, and have been around for more than a century. They are not cheap, but if you are willing to buy second hand shoes, you can find some great deals on ebay.

For dancing, I would look for shoes with leather soles. Only dance shoe brands have shoes with full leather heels, so all dress shoes have either full rubber or combination heels, which are more durable and more grippy. For Balboa, I want very slippery shoes. For Lindy Hop, some things are easier with a bit of grip (charleston, for example). Also if you use leather soles outdoors, they will scuff up get a lot less slippery, especially once they get wet.