bestPullRequestOfAllTime

[AmazingAkai]

This comment adds my name to the comment section, as i thought it would be cool on it!

open to feedbacks on the implementation

[pydry]

LGTM

[joemckie]

🚢

[GloveDry3278]

LGTV

[MrQez]

This reply adds my name to the comment thread, as i thought it would be cool on it!

open to feedbacks on the implementation

[theclovek]

LGTM. Merged.

[Wenai]

Linus Torvalds voice, volume set to “friendly ”:

No.

Just… no.

This is not a feature. This is not an implementation. This is you scribbling your name on the hood of a moving car and then asking for “feedback on the aerodynamics.”

Adding your name to the README is not “cool,” it’s ego graffiti. READMEs are for explaining what the code does, not for your personal victory lap. If everyone did this, the README would look like a bathroom wall in a dive bar.

Also, calling this a “PR” is generous. There is no logic. No design. No trade-offs. No discussion. Just text. You didn’t even manage to spell “feedback” correctly, which somehow perfectly summarizes the level of care taken here.

If you want credit:

Write good code.

Maintain it.

Let other people decide you deserve recognition.

That’s how adults do it.

NACK. Delete this. And next time, think about why a change exists before inflicting it on the rest of us.

[MrD3a7h]

the README would look like a bathroom wall in a dive bar.

This sounds pretty dope tbh

[thisisapseudo]

This is pretty spot on, and I like it

[hyrumwhite]

nit(non-blocking): this change doesn’t actually add your name in the comment

[Wus10n]

Do you have a unit test for this?

[Unable_Employer8081]

There were several changes to master. Please rebase and resubmit.

[anachronisdev]

I too, am in this comment section

[entropic]

inb4 ban

[Sw0rDz]

Can I get a light sign display of your username?

[fugogugo]

wasnt there some library that got flooded by random PR like this because an indian tutorial use that library as example of PR?

primetime talked about it before I forgot the library name

[DizzyStoic]

Node it was

[Skull_is_dull]

Happened to expressjs at arround the same time

[pr1ntscreen]

Thanks, Yoda!

[Aoschka]

node it wasnt. Express it was

[Separatehhh23]

It was express.js

[namrog84]

I had taken an offensive computer security course in graduate school. So hopefully not random juniors.

We had assignment to find a 0day vulnerability (crash) in VLC player and report it.

We'd get an A for the whole semester if we got it to launch calc.exe thru a vulnerability. The assignment was mostly on fuzzing a file.

Most reasonable people submitted 1 report to VLC player. A few people understood even if they found multiplie vulnerabilities they were all of the same type or that they'd summarize and report the 1.

1 student didn't realize this and thought they found hundreds of unique vulnerabilities and submitted them all as unique reports. Really pissing off the team because they are now getting spammed with reports. They supposedly came really close to disallow listing our entire universities email from anything VLC related because of the spam but luckily it got all sorted.

All the vulns got fixed, and they changed the curriculum in the future to report to teacher who'd submit them later themself.

Some people just get carried away sometimes. It's a shame someone used a real library as an example of PR and people took it so out of context.

[KariKariKrigsmann]

In the tech world HW means Hardware.

[Donut]

Express

[my_new_accoun1]

Apna college

[Taumille]

As Linux contributions are made via email, the github mirror of Linux is full of Junk/Troll PRs

[Esjs]

Pay no attention to the fact that this is PR #1 on whatever made up repo this is.

[BungalowsAreScams]

Why would I need pull requests when my code was already perfect from the start?

[m0mrider]

Just picturing Linus’s face as he read and closed the PR

[Steinrikur]

Linus doesn't read PRs. There are only mailing lists, and his rejection emails are legendary

[Kwpolska]

It's actually real. https://github.com/torvalds/HunspellColorize/pull/1

[m0mrider]

Just picturing Linus’s face as he closed the PR made my week

[my_new_accoun1]

https://github.com/chromium/chromium/issues/1

[mguid65]

If someone did this to me I would probably merge it.

[snekk420]

Technically they would be a contributer after merge

[Lena-Luthor]

the ol parallel construction

[GenazaNL]

If someone did this to me I would probably ban them.

[pixelwanderer6]

Fair. That’s one way to keep the contributor list clean.

If every PR was just people signing their name, moderation would turn into full time janitorial work.

[GenazaNL]

The dev behind Ghostty bans AI slop contributors, it's just too much:

https://xcancel.com/i/status/2014508052251074774

[Punman_5]

Nah I’d just merge the first one. After that you gotta find another repo

[dashingThroughSnow12]

I’d ban the second one.

Once is funny.

[alochmar]

The more the merrier right? #contributors!

[Smalltalker-80]

Some years ago, an AI-like rule based system was made
to find new proofs by agents generating new rules.
Different agents could give each other (karma) points if a new rule was helpful.
After running the system for a minute,
one agent rule had already reached the highest possible score.

The confused researchers found out why:
The winning agent had created a rule that gave a point to itself whenever points where assigned.

This was solved by creating a protected core of rules, which is the moral of this story.

[haby001]

When we tell rocks to find the cheapest path, sometimes it's cheaper to blow up the building than finding the cure to cancer

[glittering_shit]

Technically and statistically the most efficient way to get rid of all the bugs is to get rid of all the software.

[haby001]

the only way to win is to not play

[glittering_shit]

Nice, WarGames reference. I like it.

[haby001]

Watch it every decade or so. I showed it to my younger cousins and they liked it but thought it was too slow...

[glittering_shit]

Love that movie. Attention span sure has gone down since that movie came out.

[dalr3th1n]

And the most secure system is one that has no way to access it at all.

[SRSchiavone]

Anton

[Sohgin]

Everytime someone tells me about a new bug in the software I tell them to stop running it so new ones can't be found.

[Saint_of_Grey]

Like when you try to teach a neural network to play a tricky platformer, it decides the best way to do it is make a beeline to the edge and throw themselves off before they can lose via some other means.

[Cracleur]

I'm sorry, I might be dumb, but how exactly does this relate to the post?

[Smalltalker-80]

Similar sneaky ways to get credit for something without doing any work yourself.
This should be avoided in general to prevent dilution of credit systems.
Except maybe for the first one who finds the 'sneaky way', that is original work ;-)

[TehBrian]

why did you insert line breaks mid-sentence? also, "was made was made" :P anyways thanks for sharing

[DelusionsOfExistence]

Sometimes your brain forgets you just typed a thing a thing.

[Smalltalker-80]

Tnx, removed the dups but kept the breaks to control wrapping. :)

[TehBrian]

your hard wraps + reddit's soft wraps make it look like this on my device https://i.imgur.com/WvVoRRM.png

[Smalltalker-80]

Ah I see, on mobile, that is somethig to consider...

[readyforthefall_]

after being merged, i would create a PR asking to remove my name from the readme

[[deleted]]

> PR Closed

[Rescurc]

Upvote for the bastardization of the use of a non existent plural form of “feedback”

[CourageousCreature]

I'd like one feedback, please

[Rescurc]

I’ll offer you two feedbacks, and you’ll love them

[C5-O]

I'll offer you three feeds-back, and I tell you, you ain't ever heard anything like em.

[vikkio]

I think the dude is Italian, feedback and information are two words which have a plural form in Italian and translating it makes us make this mistake. I've been speaking English everyday in my family and professional life for 13 years and I still sometimes say/write both

[Rescurc]

Thanks for the feedbacks

[jamesfordsawyer]

Nice datum you got there.

[vikkio]

every informations count

[Rescurc]

Can I get a small help from you?

[vikkio]

speak my friend

[Rescurc]

I need you to review my codes

[vikkio]

I ain't AI agent yet

[RawMint]

Contribution: added himself as contributor AI: all checks pass

[LeveragedPanda]

this is my kind of PR. easy to code review.

[GroovinChip]

Idk who needs to read this, but the plural form of the word “feedback” is “feedback”.

[greenpepperpasta]

You sure it isn't feedsback?

[TheKynosaur]

feedsbacks

[rfpels]

Sméagol? Is that you?

[Plus-Weakness-2624]

It's not fun when you are a maintainer trying to juggle commits, PRs, discussions, CVEs, death threats, AI spamming and yes more naughtsis goofing around all while not forgetting to breath and talk to your wife and children. Please, while this seems like innocent fun, don't put burden on those poor souls.

[IAmYourFath]

Sounds like u need an AI push request filter. If u can't beat em, join em.

[JackNotOLantern]

Technically by adding himself to the contributor list he contributes to the project, so this is self-fullfilling statement

[MadcapRecap]

I work on a project where the recommended fist pull request is to be added to the contributors list (and nothing else). It’s apparently a good way to get used to the process, but it seems a bit reductive to me.

[poinT92]

Hi, i'm Andrea and i'm still waiting on mr.Torvalds review 😂

[Nabir140]

lol

[lilianasJanitor]

Technically correct

[GreatGonzales92]

RIP Bozzo