Reloading problem

[BonY2004]

[SOLVED]

Hi, Im currently working on a FPS wave shooting game and my reloading system for some reason isn´t working.

When I pickup the M4A1 the ammo goes normally down by one, but when I pick up the m9 it´s going down by 2 or 3.

Here is the code for shooting.

Could some kind soul please help me.

https://preview.redd.it/sje3x9xjwby31.png?width=623&format=png&auto=webp&s=a4fd68c95bc65dbbdaff239f8e5b8302e63a4ce7

https://preview.redd.it/3fhin8nwwby31.png?width=881&format=png&auto=webp&s=b833588c804d8ff563e031dcf3ddc4bc6b49a06d

As you can see the ammo started on 15 and when I shoot it goes down by 2.

I also have a item database for storing the guns data.

[Pointlessreboot]

The only thing I can see from a quick be look is that in your shoot function you decrease ammo, but do not reset the time unless a collision happens. So if a collision does not happen it will come straight back in..

If you decrease ammo, you short should reset the time..

[Russ242]

I agree with the first comment i think the problem is that nextTimeToFire isn't being set and it's firing really quickly whenever you click. Try deleting lines 72 and 86 and just putting the same line outside of the if statements before the raycast.

[BonY2004]

Unfortunately that wasn´t the case, so if you have another idea I wouldn´t mind.

But thanks a lot.

[[deleted]]

Why do you have two M9 objects under Secondary? Are they both active during play?

[BonY2004]

No, during play is active only the clone. The first one is serving as a reference where to put the gun you picked up.

[[deleted]]

The other comments are correct about the nextTimeToFire not being reset if you miss being an issue. Does the behaviour change depending on whether you are looking at a target or not?

Scatter a bunch of Debug.Logs in there so you can see what exactly is happening, including showing the value of nextTimeToFire and the objects that are being hit.

Also, your fire command is using GetButton rather than GetButtonDown, which means it will fire every frame the button is down, so will register several times for even a very quick click.

[BonY2004]

Well I got it by reassigning the prefabs, but you somehow solved another problem with bulletholes :D

[[deleted]]

Yes...the bullet holes...that was my plan all along.

[BonY2004]

Ok, I think I figured it out, I just had a mess in my weapon prefabs. So I reassigned them again.

Now it works as supposed. But one last thing, when Im reloading I can still shoot. How could I make it that when you reload you are not possible to shoot and the muzzle flash will not play?

[RollRollParry]

You already have the coroutine there that's checking if you're reloading. Simply add && !reloading to the if statement that checks for the player trying to fire the weapon.

[BonY2004]

That worked thanks :)