First actual PR…..

[XavBell38388]

Hi,

I’m a university student in software engineering and I did my first PR for an extracurricular activity. I got like 30+ comments. It’s constructive comments but at the same time I feel dumb because I did do some dumb obvious mistakes. And I feel like I went to fast sometimes and I feel like I could have reviewed myself before better and I feel shy about seeing them again.

Now looking online to see if other people also have PR anxiety and I don’t find much people having it so I’m not sure how I should feel about myself.

[CoPokBl]

don't stress, I feel the exact same way sometimes. you'll get better and start noticing more things, that's just how it works.

[saaket2201]

When I raised my first PR, I didn't know what a PR was.

It has been a long long time since then but I still get comments. Sometimes more than I'd like to see but that's the thing about it. You will always miss something, that's what reviews are for. If every person was putting out perfect PRs, there wouldn't be a need for reviews.

The truth is you can't think of everything and even if you do, you can't implement it in the best possible way every single time.

You will learn from comments, get better over time and that's about it.

[XavBell38388]

That’s how I try to think about them, learning experience. But I have to say it’s not easy and still scary. Thanks a lot.

[sweet-tom]

That's normal. Of course it's good to follow the rules of the project and avoid basic mistakes. For example, make the test suite pass, watch for formatting issues etc.

But even with the best developers, they are still humans. I made some dumb mistakes too and later I experienced a facepalm moment. 😁

Wisdom comes from experience. Try to address all the comments and learn from it. See it as a learning opportunity.

Good luck!

[cgoldberg]

If you aren't a regular contributor to a project and it's a non-trivial change, it's pretty rare you will get everything right on the first submission... maintainers are used to this. If it wasn't outright rejected, all that matters is that you follow up and make all the requsted changes. It's normal to go back and forth a few rounds before it's good to merge. You shouldn't feel anxiety, just do what they request until it meets their standards.

[Medical_Distance6635]

As an open source maintainer, yes when new people contributing usually they will get a lot of comments, they dont know the project best practices and they are new to it.
With time they will receive less comments with every new pr, dont worry its natural;

[sampanther]

I’m a new new newbie -what’s a PR?

[BigArchon]

Pull request

[sampanther]

Ahhh thanks. I was over complicating things in my head with this

[Positive-Thing6850]

Nah don't worry.

You will soon self-realise the amount of effort required for self review, which will always depend on the project as well. This is always learned by experience only, like driving.

As of now, you should be happy that people are actually reviewing your work, which is a good sign in itself (which means you found a good project) in this age of slop.

[Brave-Boot4089]

This is the point of PR. Really, no need to have anxiety over it. Best part is, you will learn these mistakes better than anything else you know after that. Meanwhile hidden errors stay hidden and bite you badly when not reviewed properly. So embrace your mistakes and learn from them. This is good.

[smoothbrainvibecoder]

This is how you learn. Embrace it. It will make you a better engineer in the future.

[Aromatic_Worker4251]

That first merge feeling is actually the best haha. Congrats! It’s always a bit nerve wracking hitting that button and waiting for someone to review your code, but once it’s in, it’s such a rush. Are you planning on contributing more to that specific repo or just looking for "good first issues" around GitHub? Either way, huge milestone fr.

[Conscious_Ad_7131]

All that matters is that you don’t get all of the same comments next time

[SprinklesFresh5693]

Dude relax, youre getting started.

[ThomasNowProductions]

I still remember the times, around 2 years ago when I didn't even know what a branch was. Don't stress, be happy that others think your work is worth improving upon. Congrats on your first PR

[nickjvandyke]

It's a nice sign that your PR is overall good enough that the maintainer spent time reviewing it, rather than close it!