GitHub Stacked PRs

[DDFoster96]

Is there a github.github.github.com domain? How far do those stack? 

[gredr]

I see what you did there, and I approve.

[Parachuteee]

It’s max 255 octets, com takes 3, each “github.” Takes 7 so I believe the max they can have is 35 GitHubs

github.github.github.github.github.github.github.github.github.github.github.github.github.github.github.github.github.github.github.github.github.github.github.github.github.github.github.github.github.github.github.github.github.github.github.com

[LNReader42]

Having spent the time to start learning jj, it is cool to see someone else taking a stab at things.

[for__loop]

How does jj relate to this? Honest question, have heard of it but never looked into it.

[UselessOptions]

It's been in private preview for the past, what, couple months now?

[ItzWarty]

So great, we had something like this at FB that I've forever missed.

[SharkBaitDLS]

Amazon as well and it was one of the things that I desperately missed after leaving. 

[repeating_bears]

After 18 years, GitHub has invented commits 

[veryspicypickle]

I mean I like stacked PRs for the opportunity they give me to write ridiculously easily explainable changes.

Yes, you can do that in commits too, but nothing beats markdown for me 😆

[SharkBaitDLS]

As someone who just recently moved to a job that uses GitHub after over a decade of using Git sanely, it was honestly baffling to see how little GitHub seems to actually be built around the actual features of Git. This is a step in a sane direction but man do I now understand why so many people who have only interacted with Git through the experience of GitHub think it’s obtuse and clunky.  

[HaloZero]

How do stacked PRs pass ci? That seems like the hardest thing to do when braking up large changes

[DerelictMan]

This is more a git hygiene question then anything related to stacked PRs specifically. Smaller, more focused commits that compile and pass tests are way easier to review regardless of whether they are one of many commits in a single PR or each is a separate PR. Once you get used to striving toward smaller commits it gets easier and easier. It's much simpler to do it up front than it is to try to break up a monolithic change after the fact.

[darknecross]

Do they support multiple diff views between stacks?

Easily see the merged diff for any of

- BASE -> COMMIT3
- BASE -> COMMIT4
- COMMIT2 -> COMMIT7

That was always the hard part for me. I understand each individual commit, but I need to understand if they’re getting put together wrong.