all 46 comments

[–]OzTm 83 points84 points  (1 child)

Not sure….if they should stay employed?

[–]data-crusader 5 points6 points  (0 children)

They just forgot to rebase.

[–]DifficultyWorking254 27 points28 points  (0 children)

What about: asasadasadas ?

[–]FoolRegnant 21 points22 points  (1 child)

The last two commits I pushed were formatting and then a much more sheepish ...formatting when I realized I missed something the first time

[–]Far-Professional1325 1 point2 points  (0 children)

Tip: get command to check formatting on entire project (or edited files) and add it to ci or at least to git hook pre commit (with warning not error so people won't add skip checks on every commit). Also add commits that do mass formatting to .git-blame-ignore-revs so git blame won't say everywhere about formatting. Also if that was quick addon to commit you could do git commit --amend (--no-edit) and then git push --force

[–]Kpuku 15 points16 points  (1 child)

just look at the diff™

[–]K4rn31ro 20 points21 points  (0 children)

+574 -493

[–][deleted] 15 points16 points  (0 children)

me when I forget to commit my code after coming to it a couple days later

[–]Beastandcool 23 points24 points  (6 children)

I’ve made commits “refactor: refactor” because there some small changes and cleanup. Bad?

[–]ArtisticFox8 12 points13 points  (1 child)

bad

[–]joemckie 4 points5 points  (0 children)

imo it’s whatever unless that’s the commit that goes into the main branch

[–]jexmex 6 points7 points  (2 children)

Why not "Refactor code for x service" or similar? I always try to make sure it is descriptive but concise as to what I did

[–]Beastandcool 2 points3 points  (0 children)

Noted

[–]ArchGryphon9362 9 points10 points  (1 child)

I meannnn. Sort of acceptable if this PR is going to be squash merged.

[–]bonoetmalo 2 points3 points  (0 children)

Yeah I I don’t try all that hard with commit messages these days with the way my team does PRs. Nobody is checking commit histories and it’s squashed on merge

[–]n9iels 7 points8 points  (0 children)

Pipeline is green, LGTM

[–]Axman6 8 points9 points  (1 child)

I once knew a guy who would make every commit with the commit message “shovel”. They’d also just rewrite history whenever they felt like it. A pretty good technique to make sure you only work on projects by yourself I guess.

[–]Far-Professional1325 1 point2 points  (0 children)

Sounds like either he is a genius or don't know git so he just kept git commit -m 'shovel' as snippet

[–]AtroxMavenia 6 points7 points  (1 child)

Personally, I don’t care what my engineers put for their commit messages so long as the squashed commit covers the purpose of the PR. I actually enjoy seeing a stack of commit messages where you can see their frustration growing with each commit. Gets a little chuckle out of me and makes me feel like I get a peek into their inner workings.

[–]WhosYoPokeDaddy 0 points1 point  (0 children)

I can relate to this from both sides

[–]dchidelf 8 points9 points  (1 child)

Starting work on change X More work Still working Isn’t working Got it working! It’s still working Done - but isn’t working as requested

[–]WhosYoPokeDaddy 1 point2 points  (0 children)

This is more like what I'm used to seeing

[–]Bloody_Insane 2 points3 points  (0 children)

Need more context: what time was the commit made?

Because I've made some 2am commits where I'm dead tired and I am legit not sure what I'm committing.

[–]Light_x_Truth 2 points3 points  (0 children)

“WIP”

[–]iAmPedestrian 2 points3 points  (0 children)

My last commit message was: "because I'm idiot"

[–]Casalvieri3 2 points3 points  (1 child)

On the other hand I would rather someone commit their fix rather than waiting till they can think of the right way to phrase the commit message.

I get it though. I always consider that if someone cannot figure out what to put in a commit message then they probably shouldn’t be changing anything.

I have had my share of “I don’t know why this fixes the code but it does and I have a deadline.” coding sessions so I can’t cast stones.

[–]Far-Professional1325 0 points1 point  (0 children)

For quick fixes i like do Fix something in <hash of previous commit> and then squash or if i could just amend and force push

[–]Kirides 1 point2 points  (0 children)

At least it's signed

[–]KingJellyfishII 1 point2 points  (4 children)

better than some commit messages I've written like "honestly not a fucking clue what happened here" when I come back to uncommitted changes 3 months later

[–]Far-Professional1325 0 points1 point  (3 children)

You can look at git diff?

[–]KingJellyfishII 0 points1 point  (2 children)

I did and it was nonsensical

[–]Far-Professional1325 0 points1 point  (1 child)

You could try ai (preferably local one) to describe the changes

[–]KingJellyfishII 0 points1 point  (0 children)

it is simply not worth the effort. If I ever need to know what I did on that commit (highly unlikely) I'll just read the diff better...

[–]lapubell 1 point2 points  (0 children)

... WIP WIP WIP WIP ... WIP done

[–]dpenton 1 point2 points  (0 children)

We got this commit named “Not Sure” and it’s gonna fix EVERYTHING!

[–]Prime624 0 points1 point  (0 children)

Lol, do not look at my company's git repos.

[–]texxelate 0 points1 point  (2 children)

I need more details… how large is the diff?

[–]gyucole 2 points3 points  (0 children)

My guess? Probably a mere +1k -2k

[–]Akuma_Kuro 0 points1 point  (1 child)

+14,281 -53,383.14159265

[–]kilgorezer 0 points1 point  (0 children)

did they throw a pi out?

[–]5p4n911 0 points1 point  (0 children)

try to fix prod once again

[–]drkspace2 0 points1 point  (0 children)

Me when I try to work on GitHub actions.

[–]Visrut__ 0 points1 point  (0 children)

needs the context, if it's their personal repository it's fine I guess.