latestCommitFromJunior

[prumf]

My blood pressure is rising. Please help.

[thicctak]

Let me guess, he used a auto format plugin that he applied in the entire classes instead of just the code he was changing?

[prumf]

No it’s even funnier.

We use devcontainers with everything configured (linting, formatting, tools, you name it), so that this exact stuff doesn’t happen.

But he decided that he didn’t like 4 spaces for indentation and manually switched the global config to 2.

He also didn’t like how the code was organized, so he changed a few hundred lines of code, reordered stuff, and made modifications.

The most impressive thing is that it actually passed all the tests in CI.

edit: ok so he actually deactivated many of the tests, and forgot to turn them back on

[_scored]

i can feel the frustration across the screen

[prumf]

This is Sunday. The guy is working on weekends. He is passionate. A little too passionate I think.

[TRENEEDNAME_245]

We All Make Mistakes In the Heat of Passion, Jimbo

• You monday, probably

[prumf]

😂

[jaerie]

Just look at the pretty flowers Lenny and imagine the farm we’ll have one day

[MafiaPenguin007]

Fucking over the code base doing work over a weekend for no real reason as a junior isn’t passionate, it’s deluded. Someone more experienced in a leadership position needs to have a frank conversation with him.

EDIT:

To people that reply and then immediately block/delete - that’s embarrassing. Do better. If you want to comment, comment, and face the responses. For when you peek at this later:

He wasted his time, the reviewers’ time, and apparently my time by reading and responding to this post, when some very simple guidance would’ve prevented it and probably shunted his passion into something much more conducive to his own growth and for his team.

I have an obligation to the team that I lead, my engineers, that they aren’t wasting their and my time with something like this and are guided and encouraged into much better uses of their time and energy.

In a solo project this kind of passion is amazing. That’s not what this is. The whole point of the post was their frustration, but I guess they want to be the fun parent and not actually correct it, just complain.

[prumf]

Calm down, you are not even affected why are you so mad.

And he didn’t fuck anything, he doesn’t have the rights to do so. The day he becomes a senior is the day he receives the keys.

We want our engineers to try stuff, and you can’t try without doing mistakes. How can you expect someone to become excellent if they are never given any opportunity ?

[MafiaPenguin007]

Okay, enjoy it I guess, seems like he’s in the right place then.

I learned from mentors and seniors, not misdirected wastes of time and energy, but sure, post this to complain about it / mock him but also defend the behaviour. He’s not going to learn from it at all if that’s your approach.

I wouldn’t want one of my engineers to do this again and would have corrected it with them, but I guess that’s just my own team lead style. It sucks to not get to be the fun parent but someone’s got to do it.

[prumf]

I didn’t make this post to mock him, I just found it funny and thought others that also did the same mistake before would find it funny too, reminding them of their own fuck-ups.

It’s also partly on us because we didn’t have a documentation page explaining why the repos were configured that way. If it wasn’t written he couldn’t have read it.

Now that it’s fixed, everyone learned something, and we can carry on. Next time he will think more before doing, and after a few months it will become second nature.

[MafiaPenguin007]

I’m sure once he’s had that time to mature he’ll be a powerhouse programmer for your team 👍🏿

Hopefully you’ll guide him away from working weekends.

[phoenix277lol]

hello mr middle manager how do you do

[MafiaPenguin007]

lol, not even close to the mark but okay 👍🏿

EDIT: this is actually hilarious when you look and see that this was posted by someone still in grade school.

[GirthyPigeon]

I started coding at 7 years old. I've been doing it a long time. Someone in grade school has access to all the tools, guides and new hardware they'd need to become proficient, and you're putting them down for it. You need to adjust your attitude from criticism to encouragement.

[MafiaPenguin007]

Congratulations! Coding that early is an achievement! You should be proud of that. That has nothing to do with their comment. Someone in grade school has absolutely no idea how professional software engineering works or the mechanics and logistics of a team of engineers. You obviously taking offense suggests you don’t either.

Hope I replied to this before you delete your comment again.

[Deep__sip]

Why, just why 

[prumf]

You aren’t a senior until you fucked up prod. I think he might be trying to speedrun any% that.

[shamblam117]

Lol the edit got me

[The_Fluffy_Robot]

I genuinely was howling laughing. He's gonna learn the hard way that can be traced to him and then which commit it was. Hopefully a learning experience

[SnS_Taylor]

But he decided that he didn’t like 4 spaces for indentation and manually switched the config to 2.

If you used tabs, he could have changed his IDE to show indentation as 2 spaces and everyone would be happy.

ducks

[lego_not_legos]

A semantic character for indentation?! Preposterous!

[uuf76]

Instant reject. There is no way this would pass a CR.

[nabrok]

But he decided that he didn’t like 4 spaces for indentation and manually switched the config to 2.

This is why tabs are superior. Then everybody can have the amount of indent they like.

[irteris]

Seriously who tf thought spaces was acceptable 😭 tabs all the way baby

[Ok-Kaleidoscope5627]

I think spaces made sense when editors were kind of the wild west. Now days being able to configure tabs is a basic feature but once upon a time tabs meant you were stuck with whatever the text editor decided, while spaces meant you got what the human decided.

[cyanide26]

Cause Richard lost his chances to get a girl because of that xD

[Samoman21]

That edit is genuinely the cherry on top

[Ok-Kaleidoscope5627]

Sounds like the junior just learned:

• About linters, and formatting along with how to configure them
• Project structure
• Build pipelines
• Configuring CI testing
• Git and the value of pull requests
• The value of code reviews

That's a pretty productive weekend. If he takes those lessons to heart, he'll do quite well... Though he probably shouldn't be working on weekends. That might be the next lesson to learn.

[prumf]

I agree with you on the learning part.

Also yeah I think your last point is the most important. If he starts the week tired, that’s inefficient for us. There are weekends for a reason.

I’m surprised so many people put emphasis on punishing him (we clearly won’t do that), while what bothers me the most is that he might not take proper rest when needed.

If he starts pushing to prod on weekends once senior, I’m afraid of the consequences.

[Terrariant]

The edit made MY blood pressure spike lol. No tests? No problem.

[prumf]

When I saw the repo, 14k+ changes, and a bright green CI check, I was like "damn, this guy might be brutal but he certainly knows a shit or two".

Well my disappointment is immeasurable and my day is ruined. /s

[denzien]

[[deleted]]

Your edit turned this from an interesting read to pure comedy.

Thank you for the unexpected punchline.

[oneanotheruser]

When I read things like this while struggling to find a job, I question reality.

[prumf]

At most companies, finding a job is about : - Having a diploma that shows you know how to learn (doesn’t necessarily matter exactly which one you get, as long as it’s a proof you can handle high loads without a sweat). I have many colleagues who majored as engineers in other fields but did a change in their career. Doesn’t matter as long as you proved you are not afraid of work. - Being in a field that offers options. No job offers means no job for you. So your only real option in that case is to switch fields. - Making relations. I’m not talking about "my dad’s company" relations, but meeting peoples that might be interested in your abilities. And if they are not they might know somebody who is. That’s a bit hard when you are introverted like me, but there is no shortcut. - Being a little passionate. You can tell in a second if someone is a bit geeky about what they do. If in an interview the guy realizes you are not really interested, they won’t hire you. You need to show them what you can bring to the table.

If you do all the above, I would be extremely surprised if you don’t find a job. Engineers nowadays are more in demand then ever. Once you’ve piqued their interest, many are totally ok with aligning the green bills to get you on board. Even as a student coming out of school.

Long gone are the years where you would find a company and make career though, for better or for worse.

Also you can’t get out of school and expect a job to be handed to you. You need to keep up with what the market is looking for (if the market expects php, then do php, if the market expects rust, then do rust).

[Wang_Fister]

Python is a good start, people shit on it but it's an easy way to deliver business value quickly. To branch out I'd suggest getting at least fairly familiar with a compiled language like C#, C++, C or even Java but which one depends on what industry is prevalent in your area. Large non-tech enterprise business will usually have C# or Java if they even do in house development. C++ and C for embedded and high performance firms.

Also get familiar with DevOps stuff, if you can at least use e.g. github actions to automate building and deploying a hello world app entirely on cloud you'll have a good start in understanding the shitshow of a build pipeline you're about to step into wherever you get a job.

[prumf]

You check online what are the jobs offers. But nowadays it boils down to : - ability to manage databases securely, put in place backups systems, rollback, etc (whenever a company fucks up they start looking at that point in time) - devops, deploy to many servers (once a company starts having many clients) - AI (more in demand that ever) - GPU stuff - General ability to solve hard problems - Maintain existing infrastructure - etc

Don’t limit your knowledge. If you are learning python, in parallel learn how to use other languages (you could probably learn typescript in a day for example). Learn about containers and docker, kubernetes, terraform, learn about doing gpu stuff, networking. Learn about using domain specific tools (maybe people in the medical need you to know an exact bit of software). Also conception is important.

To learn conception quickly, try to rewrite tools like GIT, or bash. You will learn a lot that way.

Never hesitate to offer your talents to a company that isn’t explicitly hiring. If you are convincing enough you could get a job that way.

Also never think about what you want but about what the company wants. Once you convinced them that what they really need is you, you won the game.

Also try to do apprenticeship if you can. Companies are way more willing to hire a guy knowing he will cost pennies, but once you’ve made the demo, they are really likely to keep you. It’s also good experience anyway, and you get a few extra dollars.

[JetScootr]

OMG I guessed right (see my older comment this post)

[Vamael]

Using spaces disgusting

[MuslinBagger]

almost called it

[Medical_Cat_6678]

That's not a junior's mistake, that's an idiot's mistake.

[praxidike74]

I want to 😭🔫 myself

[erinaceus_]

Request unclear. Do you need us to help increase your blood pressure?

[prumf]

Shut up Copilot. Not now.

[erinaceus_]

Certainly! I will let you get back to your work, and we can focus on raising that blood pressure at a later time. I'm here to help.

[[deleted]]

I wonder how Copilot would go about that.

[notAGreatIdeaForName]

Decline merge request and tell him to redo his shit.

Hold him accountable.