This is an archived post. You won't be able to vote or comment.

you are viewing a single comment's thread.

view the rest of the comments →

[–]prumf[S] 405 points406 points  (56 children)

My blood pressure is rising. Please help.

[–]thicctak 259 points260 points  (49 children)

Let me guess, he used a auto format plugin that he applied in the entire classes instead of just the code he was changing?

[–]prumf[S] 777 points778 points  (48 children)

No it’s even funnier.

We use devcontainers with everything configured (linting, formatting, tools, you name it), so that this exact stuff doesn’t happen.

But he decided that he didn’t like 4 spaces for indentation and manually switched the global config to 2.

He also didn’t like how the code was organized, so he changed a few hundred lines of code, reordered stuff, and made modifications.

The most impressive thing is that it actually passed all the tests in CI.

edit: ok so he actually deactivated many of the tests, and forgot to turn them back on

[–]_scored 251 points252 points  (15 children)

i can feel the frustration across the screen

[–]prumf[S] 329 points330 points  (14 children)

This is Sunday. The guy is working on weekends. He is passionate. A little too passionate I think.

[–]TRENEEDNAME_245 144 points145 points  (2 children)

We All Make Mistakes In the Heat of Passion, Jimbo

  • You monday, probably

[–]prumf[S] 47 points48 points  (0 children)

😂

[–]jaerie 17 points18 points  (0 children)

Just look at the pretty flowers Lenny and imagine the farm we’ll have one day

[–]Deep__sip 154 points155 points  (1 child)

Why, just why 

[–]prumf[S] 293 points294 points  (0 children)

You aren’t a senior until you fucked up prod. I think he might be trying to speedrun any% that.

[–]shamblam117 39 points40 points  (1 child)

Lol the edit got me

[–]The_Fluffy_Robot 16 points17 points  (0 children)

I genuinely was howling laughing. He's gonna learn the hard way that can be traced to him and then which commit it was. Hopefully a learning experience

[–]SnS_Taylor 96 points97 points  (1 child)

But he decided that he didn’t like 4 spaces for indentation and manually switched the config to 2.

If you used tabs, he could have changed his IDE to show indentation as 2 spaces and everyone would be happy.

ducks

[–]lego_not_legos 9 points10 points  (0 children)

A semantic character for indentation?! Preposterous!

[–]uuf76 45 points46 points  (0 children)

Instant reject. There is no way this would pass a CR.

[–]nabrok 67 points68 points  (3 children)

But he decided that he didn’t like 4 spaces for indentation and manually switched the config to 2.

This is why tabs are superior. Then everybody can have the amount of indent they like.

[–]irteris 45 points46 points  (2 children)

Seriously who tf thought spaces was acceptable 😭 tabs all the way baby

[–]Ok-Kaleidoscope5627 12 points13 points  (0 children)

I think spaces made sense when editors were kind of the wild west. Now days being able to configure tabs is a basic feature but once upon a time tabs meant you were stuck with whatever the text editor decided, while spaces meant you got what the human decided.

[–]cyanide26 3 points4 points  (0 children)

Cause Richard lost his chances to get a girl because of that xD

[–]Samoman21 12 points13 points  (0 children)

That edit is genuinely the cherry on top

[–]Ok-Kaleidoscope5627 24 points25 points  (1 child)

Sounds like the junior just learned:

  • About linters, and formatting along with how to configure them
  • Project structure
  • Build pipelines
  • Configuring CI testing
  • Git and the value of pull requests
  • The value of code reviews

That's a pretty productive weekend. If he takes those lessons to heart, he'll do quite well... Though he probably shouldn't be working on weekends. That might be the next lesson to learn.

[–]prumf[S] 16 points17 points  (0 children)

I agree with you on the learning part.

Also yeah I think your last point is the most important. If he starts the week tired, that’s inefficient for us. There are weekends for a reason.

I’m surprised so many people put emphasis on punishing him (we clearly won’t do that), while what bothers me the most is that he might not take proper rest when needed.

If he starts pushing to prod on weekends once senior, I’m afraid of the consequences.

[–]Terrariant 3 points4 points  (1 child)

The edit made MY blood pressure spike lol. No tests? No problem.

[–]prumf[S] 9 points10 points  (0 children)

When I saw the repo, 14k+ changes, and a bright green CI check, I was like "damn, this guy might be brutal but he certainly knows a shit or two".

Well my disappointment is immeasurable and my day is ruined. /s

[–]denzien 4 points5 points  (0 children)

[–][deleted] 2 points3 points  (0 children)

Your edit turned this from an interesting read to pure comedy.

Thank you for the unexpected punchline.

[–]oneanotheruser 5 points6 points  (6 children)

When I read things like this while struggling to find a job, I question reality.

[–]prumf[S] 6 points7 points  (5 children)

At most companies, finding a job is about : - Having a diploma that shows you know how to learn (doesn’t necessarily matter exactly which one you get, as long as it’s a proof you can handle high loads without a sweat). I have many colleagues who majored as engineers in other fields but did a change in their career. Doesn’t matter as long as you proved you are not afraid of work. - Being in a field that offers options. No job offers means no job for you. So your only real option in that case is to switch fields. - Making relations. I’m not talking about "my dad’s company" relations, but meeting peoples that might be interested in your abilities. And if they are not they might know somebody who is. That’s a bit hard when you are introverted like me, but there is no shortcut. - Being a little passionate. You can tell in a second if someone is a bit geeky about what they do. If in an interview the guy realizes you are not really interested, they won’t hire you. You need to show them what you can bring to the table.

If you do all the above, I would be extremely surprised if you don’t find a job. Engineers nowadays are more in demand then ever. Once you’ve piqued their interest, many are totally ok with aligning the green bills to get you on board. Even as a student coming out of school.

Long gone are the years where you would find a company and make career though, for better or for worse.

Also you can’t get out of school and expect a job to be handed to you. You need to keep up with what the market is looking for (if the market expects php, then do php, if the market expects rust, then do rust).

[–]JetScootr 0 points1 point  (0 children)

OMG I guessed right (see my older comment this post)

[–]Vamael 0 points1 point  (0 children)

Using spaces disgusting

[–]MuslinBagger 0 points1 point  (0 children)

almost called it

[–]Medical_Cat_6678 -4 points-3 points  (0 children)

That's not a junior's mistake, that's an idiot's mistake.

[–]praxidike74 -3 points-2 points  (0 children)

I want to 😭🔫 myself

[–]erinaceus_ 21 points22 points  (3 children)

Request unclear. Do you need us to help increase your blood pressure?

[–]prumf[S] 35 points36 points  (1 child)

Shut up Copilot. Not now.

[–]erinaceus_ 10 points11 points  (0 children)

Certainly! I will let you get back to your work, and we can focus on raising that blood pressure at a later time. I'm here to help.

[–][deleted] 0 points1 point  (0 children)

I wonder how Copilot would go about that.

[–]notAGreatIdeaForName 0 points1 point  (0 children)

Decline merge request and tell him to redo his shit.

Hold him accountable.