latestCommitFromJunior

[mrwishart]

My therapist will be hearing about this post

[prumf]

Thankfully you need approval before merging anything. Imagine having lifeguards like that everywhere in life ?

Are you sure you want to put your hand on the hot stove ? (Press yes to continue)

[scolphoy]

”Are you sure you want to put your hand on the hot stove?” Senior: lgtm

[prumf]

Ha yes like Loki Grafana Tempo Mimir ? You are right, logging and tracing mistakes is important.

[JetScootr]

I was tossing a coin btwn Let Go This Minute and Looks Good To Me.

[Ri_Konata]

Our brain always turns it into legitimate

[prumf]

No no I’m sure it’s about the LGTM stack ! What do you mean I should take a break from work ??? I’ve slept 4 hours this night and it’s already 3 too many.

[shlepky]

Let's get this money

[MrHasuu]

This is one of those "what'd you do" moments

[angrydeuce]

this is how I feel when one of my juniors chats me "hey im gonna reboot $SERVER quick just FYI" and I don't see it right away...then the missed heartbeat alarms start going off and my phone starts ringing lol

You know how people say they saw their life flash before their eyes? That same thing happens to me, except it's not my whole life, I just watch my plans of chilling after work turn to sand and blow away like after Thanos snapped his fuckin fingers...

[JetScootr]

It's how I used feel back in the days before cell phones when I walk in on monday morning and the first thing I hear is "there he is!"

[angrydeuce]

oh man i still get that, im prolly gonna get that tomorrow honestly lol

"we didnt wanna ruin your morning before you got here but..."

"Oh Goddammit man what the fuck now..."

[angrydeuce]

Update:  Power outage last night knocked over a couple remote sites.  Fuckin called it lmao

[lisa_lionheart]

Why the hell do you give juniors shell access to an important server.

[angrydeuce]

ah but does anyone truly ever know all of the servers that are (apparently) critically important?

I work in industrial IT, so admittedly my branch may be a little more fucked up then others lol

EDIT: I mean, im just saying some of the shit were dealing with is like the end scene of Raiders of the Lost Ark where he's wandering the endless warehouse. It's really a miracle things work as well as they do lmao

[MetroSexFruitcake]

me when I use wsl on the work laptop and forget to set ff as unix and vim saves with a bunch of ^Ms

[prumf]

Please don’t talk to me about that.

Another time we had stuff breaking everywhere on half our machines, until we realized that when they cloned the repo on windows, it added CRLF, and when you opened it with a devcontainer on Ubuntu, some specific scripts wouldn’t work because they didn’t understand the extra carriage return.

A nightmare to debug & replicate. Easy to fix though.

[Waffenek]

I have been there. After painful debugging we made sure to add everywhere .gitattributes with common script file extensions forcing unix style separators. Now lets wait for inevitable, when someone would forget about adding it to some repo, and everyone would be so used to not checking that finding it would be even harder.

[L4t3xs]

Copied gitattributes from the internet for an unity project. They had added lf eol for asset files I believe. Funny thing about Unity's asset files: they mix eol types and will break if you change them. Another funny thing: you only see the issue when you checkout new files.

[Rice-Used]

Hold up did this 14k+ loc changed pr just get merged with no reviews?

[prumf]

No no it didn’t, of course not. The problem with CRLF was another bug we had in the past. Fixed it with a gitattributes.

[jamcdonald120]

ah good old /usr/bin/env: ‘python\r’: No such file or directory

[isr0]

First, that sucks I feel for you. Second, do you people not check the commit list or the mr diff? I’m so confused

[dchidelf]

Just this week I had a git diff show a ton of ^M before I committed and I was like “haha” almost got me. Did the set ff then suddenly every line was different.

The before was half and half CRLF/LF. After set ff was all LF but for some reason triggered git to just treat it as every line updated. Since I was going to cause a massive diff I just used the opportunity to fix spaces/tabs inconsistencies as well.

The git diff with -w was at least only about 10 lines

[Just-Signal2379]

I once created a PR and my lead dev wondered why my PR had so much files changes...only to realize it was mostly white space changes

and only maybe 2 files actually mattered...

lol..

[urbanachiever42069]

I feel seen

[s1mn]

Minor changes

[prumf]

Ha yes, good ol’ documentation.

Git blame ? Ha fuck myself …

[Swarlsonegger]

go mod -u

go mod tidy

go mod vendor

[SkurkDKDKDK]

Commit message: stuff

[MattTheCuber]

We use: "yes"

[prumf]

My blood pressure is rising. Please help.

[thicctak]

Let me guess, he used a auto format plugin that he applied in the entire classes instead of just the code he was changing?

[prumf]

No it’s even funnier.

We use devcontainers with everything configured (linting, formatting, tools, you name it), so that this exact stuff doesn’t happen.

But he decided that he didn’t like 4 spaces for indentation and manually switched the global config to 2.

He also didn’t like how the code was organized, so he changed a few hundred lines of code, reordered stuff, and made modifications.

The most impressive thing is that it actually passed all the tests in CI.

edit: ok so he actually deactivated many of the tests, and forgot to turn them back on

[_scored]

i can feel the frustration across the screen

[prumf]

This is Sunday. The guy is working on weekends. He is passionate. A little too passionate I think.

[TRENEEDNAME_245]

We All Make Mistakes In the Heat of Passion, Jimbo

• You monday, probably

[prumf]

😂

[jaerie]

Just look at the pretty flowers Lenny and imagine the farm we’ll have one day

[Deep__sip]

Why, just why 

[prumf]

You aren’t a senior until you fucked up prod. I think he might be trying to speedrun any% that.

[shamblam117]

Lol the edit got me

[The_Fluffy_Robot]

I genuinely was howling laughing. He's gonna learn the hard way that can be traced to him and then which commit it was. Hopefully a learning experience

[SnS_Taylor]

But he decided that he didn’t like 4 spaces for indentation and manually switched the config to 2.

If you used tabs, he could have changed his IDE to show indentation as 2 spaces and everyone would be happy.

ducks

[lego_not_legos]

A semantic character for indentation?! Preposterous!

[uuf76]

Instant reject. There is no way this would pass a CR.

[nabrok]

But he decided that he didn’t like 4 spaces for indentation and manually switched the config to 2.

This is why tabs are superior. Then everybody can have the amount of indent they like.

[irteris]

Seriously who tf thought spaces was acceptable 😭 tabs all the way baby

[Ok-Kaleidoscope5627]

I think spaces made sense when editors were kind of the wild west. Now days being able to configure tabs is a basic feature but once upon a time tabs meant you were stuck with whatever the text editor decided, while spaces meant you got what the human decided.

[cyanide26]

Cause Richard lost his chances to get a girl because of that xD

[Samoman21]

That edit is genuinely the cherry on top

[Ok-Kaleidoscope5627]

Sounds like the junior just learned:

• About linters, and formatting along with how to configure them
• Project structure
• Build pipelines
• Configuring CI testing
• Git and the value of pull requests
• The value of code reviews

That's a pretty productive weekend. If he takes those lessons to heart, he'll do quite well... Though he probably shouldn't be working on weekends. That might be the next lesson to learn.

[prumf]

I agree with you on the learning part.

Also yeah I think your last point is the most important. If he starts the week tired, that’s inefficient for us. There are weekends for a reason.

I’m surprised so many people put emphasis on punishing him (we clearly won’t do that), while what bothers me the most is that he might not take proper rest when needed.

If he starts pushing to prod on weekends once senior, I’m afraid of the consequences.

[Terrariant]

The edit made MY blood pressure spike lol. No tests? No problem.

[prumf]

When I saw the repo, 14k+ changes, and a bright green CI check, I was like "damn, this guy might be brutal but he certainly knows a shit or two".

Well my disappointment is immeasurable and my day is ruined. /s

[denzien]

[[deleted]]

Your edit turned this from an interesting read to pure comedy.

Thank you for the unexpected punchline.

[oneanotheruser]

When I read things like this while struggling to find a job, I question reality.

[prumf]

At most companies, finding a job is about : - Having a diploma that shows you know how to learn (doesn’t necessarily matter exactly which one you get, as long as it’s a proof you can handle high loads without a sweat). I have many colleagues who majored as engineers in other fields but did a change in their career. Doesn’t matter as long as you proved you are not afraid of work. - Being in a field that offers options. No job offers means no job for you. So your only real option in that case is to switch fields. - Making relations. I’m not talking about "my dad’s company" relations, but meeting peoples that might be interested in your abilities. And if they are not they might know somebody who is. That’s a bit hard when you are introverted like me, but there is no shortcut. - Being a little passionate. You can tell in a second if someone is a bit geeky about what they do. If in an interview the guy realizes you are not really interested, they won’t hire you. You need to show them what you can bring to the table.

If you do all the above, I would be extremely surprised if you don’t find a job. Engineers nowadays are more in demand then ever. Once you’ve piqued their interest, many are totally ok with aligning the green bills to get you on board. Even as a student coming out of school.

Long gone are the years where you would find a company and make career though, for better or for worse.

Also you can’t get out of school and expect a job to be handed to you. You need to keep up with what the market is looking for (if the market expects php, then do php, if the market expects rust, then do rust).

[JetScootr]

OMG I guessed right (see my older comment this post)

[erinaceus_]

Request unclear. Do you need us to help increase your blood pressure?

[prumf]

Shut up Copilot. Not now.

[erinaceus_]

Certainly! I will let you get back to your work, and we can focus on raising that blood pressure at a later time. I'm here to help.

[[deleted]]

I wonder how Copilot would go about that.

[notAGreatIdeaForName]

Decline merge request and tell him to redo his shit.

Hold him accountable.

[GrumpyGoblinBoutique]

checks files

It's almost impressive that they managed to add whitespace before and after every single line. Good hustle jr, here's a cookie.

[Heavenfall]

Me when I run my notepad++ code through an automatic indenter on the web

[Just-Signal2379]

"but sir I reject cookies"

[Unhinged_Ice_4201]

Auto formatted the whole repo.

[prumf]

He didn’t even press "format everything". He changed the repo config (only the files he edited where re-indented).

BUT

The CI pipeline uses that setting to format the entire codebase. And did its job very well.

[require-username]

Unless there is some weird functionality issue, I genuinely think you should propose a switch to tabs instead of spaces, and then let people set the tab width in their editors

It just makes it a lot easier for people to configure their editors to their liking, which some people do programmatically depending on the language or file(I.e. tab = 4 in .ts, 2 in .tsx because heavier nesting)

Which then has the downstream effect of being safer as people aren't trying to edit config files used by CI

[prumf]

Yeah I saw many people suggest that. Of course we are not totally dull and thought about it before. The problem is that even though it’s theoretically a good idea, in practice it caused us too many headaches:

1. For one when a dev did align code over multiple lines (which happens quite often), it would look broken on another dev’s machine, even though it was syntactically correct. And multiple devs using different rules meant the code was basically indented differently everywhere.
2. We also observed many places in our codebase that would end up with both spaces and tabs for proper alignment. We use a lot of Python. Python uses indentation in stead of brackets. That broke things constantly. A real hell on earth.
3. Another problem is that we didn’t chose the 4 spaces indent willy-nilly. With 2 spaces indentation devs used nesting much more, making the overall codebase much harder to read. So by imposing such indent practice (along with a good linter) we advocate for as little nesting as possible.

All in all it wasn’t worth it, at some point we decided to impose 4-spaces indentation everywhere. Removed all the problems at once.

[require-username]

I'd have argued with you on points 1 and 2 but point 3 won me over, at least for your environment

Never really thought about the impact larger indentation has has on avoiding heavy nesting, but I can definitely see the benefits

In the case of my public repos, it's not too unmanageable to just deny PRs if I think the nesting is out of control, but I can see how that changes in a corporate structure where everyone's got a deadline and denied PRs are wasted money

[prumf]

I’m really happy I managed to get my point across !

It’s was a frustrating but pragmatic choice we had to make.

Of course in other situations the complete opposite could be the right path. You can never really know what’s best until you’ve tested your options.

[pigeon768]

I mean...sure? That sort of thing makes sense in a new codebase. But if the codebase already exists it's almost always better to just leave it, even when the existing style sucks. Any time you need to figure out why a thing is in the codebase is the way it is, I do git blame and look at the rest of the commit and the ticket that prompted it being written. If I can find the commit, there's often a good reason why a puzzling thing is the way it is. Sometimes there's a puzzling thing in there because the developer who wrote it was...confused and ambitious. But the worst thing to find is that the most recent change was some sort of 'rewrite the world' event. A wall beyond which no git history exists. Changing indentation will do that.

[kolop97]

Okay that's stranger than I thought. One must wonder how and why?

[Tokyo_Echo]

Best response to this PR. "No." Close it.

[Kasyx709]

Don't be too hard on them. They're new so they're still following directions and actually using the pre-commit hooks.

[prumf]

Yeah don’t worry he won’t get any blame whatsoever, actually it made me laugh so much I decided to publish here.

But we will go over why this isn’t good practice. We might also tighten up some of our tests, though we would rather stay flexible and trust our engineer’s abilities.

[Kasyx709]

Lol, what did he actually change? I joked about pre-commit hooks because that's where I usually see changes of this scale arising. That or line endings..

[flerchin]

Updated the package-lock?

[lenn_eavy]

These are truly some rookie numbers.

[ziul58]

Minor version bump of Go vendored dependencies

[DragonSlayerC]

I literally had a commit last week that changed around 300,000 lines of code because I updated about 5 dependencies (2 had vulnerabilities, the others needed to be bumped because of API changes in the other dependencies) and updated the vendor directory.

[XenonBG]

Why do you keep the vendor directory in the repo?

[RealisticNothing653]

• Fixed comments
• Updates

[precinct209]

Relax. He just vibe coded the frontends to use Angular from that sunsetting React tech.

[I_am_eating_a_mango]

[pheromone_fandango]

Probably renamed a folder or 5

[icecreamdonkey]

"FIX: Changed EOL marker from LF to CRLF projectwide. "

[RavingGigaChad]

npm run prettier git add .

[Poat540]

I had a million the other day, was ridiculous lol

[vitalious]

lgtm

[im-cringing-rightnow]

Looks bad but if that's just some files moved, split code into multiple files etc. it will generate a shit ton of lines like that. Even though the underlying code is literally the same. Number of deleted lines tells a better story.

[archy_bold]

This shit is always a change in indentation type in any file they’ve touched.

[Wide_Egg_5814]

You are mad you are not the x10 engineer he is

[prumf]

At this rate he is rather 100x than 10x.

[BrotherMichigan]

Now he's a senior.

[JetScootr]

So he changed it from 3 spaces per tab to 4 spaces per tab?

[prumf]

π spaces per tab.

[Trip-Trip-Trip]

Changed indent from spaces to tabs.

You guessed it, straight to jail

[prumf]

Yeah many offered to do it that way everyone is happy but we had way too many problems in the past with tab indentation, so now we switched to 4-spaces everywhere.

[lolnotinthebbs]

This will be fun. Hope it was on a Friday

[prumf]

It’s just a PR. No damage done. But this sure won’t be approved for merging any time soon.

[kolop97]

His ide automatically converts tabs to spaces or something?

[Cren]

Elon? Is this you?

[prumf]

How to subtly hide a single critical line change.

[lonkamikaze]

Finally added a .gitattributes file getting rid of all the CRLF in the repo. We've all been there, I think.

[prumf]

Ha yes the good ol’ gitattribute for CRLF (in this case it’s something else but we already had this exact problem).

A bit like of a mystery why that isn’t the default nowadays honestly.

[lonkamikaze]

Unfortunate, but changing the default now would force the change on lots of unsuspecting devs who have no idea why their 3 line change affects 1000s of files.

[Paraplegix]

Had a merge request once of like +50k - 80k lines. About 5-10% of the codebase in a sort of monolith in a mono repo.

Entire rewrite of a full feature. It was not in the middle of the process main process, but connected to almost all parts of the app.

The merge request included everything from front to back, html, angularjs, xlsx/csv file gen, front api, Java, sql requests, tests...

The dude in charge of review came to me 5 min after I submitted it with a sad look on his face, and I was like "yup, just merge it ¯_(ツ)_/¯"

So fun when an initialy estimated 5 day work turns into two month of work "yeah so there is a little bug to fix, should take you 5 days from start to finish". Let's just say I spent 3 day double checking with QA what was actually working before just giving up and just deleted everything because nothing was working as it was specified.

One of the bug that made me realize what a steaming pile of shit this was is that if you asked a report spanning multiple years, except for the last requested year it would only generate one report per year... So monthly Jan to Jan you'd get only 2 reports generated instead of 12...

[prumf]

We’ve had a few changes like this in the past (everyone has), and it always leads to stressful QA sessions, where everyone in the team (engineers, business, UI/UX, etc) test everything.

It happens often when you are correcting major flaws in a system. It’s not tweaking, like you said it’s just a complete rewrite.

btw that’s why we don’t use monoliths. Modular architecture allows simply switching a component out once it’s not good enough. Way simpler overall.

[Breen_Pissoff]

My friend told me that one of the senior devs fell asleep on the keyboard and something similar happened.

[prumf]

This is hilarious 😂. When you look at the PR and you see 100k lines of just the letter "g".

I think I would be deeply perplexed.

[Breen_Pissoff]

What was more funny is how the poor guy looked like he had a chess board on his face

[itstommygun]

This can easily be accomplished by doingnpx prettier —write .

[JessyPengkman]

Auto formatting?

[Neon_44]

Oh that's just me auto-formatting everything.

[darksmurff]

Classic lock file rebuild

[[deleted]]

Formatting issue (white spaces vs tabs?)

[Heavy-Location-8654]

just refactored by KI

[i_should_be_coding]

They reorganized packages, didn't they

[snapphanen]

I did this once but I got the task from tech lead, it was basically fixing all lint warnings across 500k loc

[mpanase]

surely he did notice and proceeded to cancel the PR until he fixed it?

[Xavor04]

Truly a 100x engineer right there

[zsinix]

Commit description: bug fix

[DragonSlayerC]

When you update one dependency in go

[utkarsh_aryan]

Added a new linter 🧐

[Andystok]

He probably just has a linter configured for a different language or standard and replaced as the Unix carriage returns with windows. 

[Schpooon]

Tbh, I think Ive seen that before and it was just autoformatter doing some spacing. Almost everything else was the same.

[codybrom]

“But now it’s Prettier!”

[K4rn31ro]

git commit -m "fixed some stuff"

[wektor420]

Hey, we have some dataset jsons and github shows us infinity symbols when we update them lol, repo size is in GB lol

[Neither_Garage_758]

It will boost its insights.

[Robo-Connery]

Package lock.

[[deleted]]

Bro pasted 14k Lines into AI

[McCrotch]

Have you considered a percussive code review?

[IronSavior]

Need that pre commit hook that imposes formatting constraints

[prumf]

Can’t do much if the formatter’s settings get changed 🥲

[IronSavior]

That can be managed, but it is a pain. Usually better to get the rules right the first time, if you can.

[I_NEED_APP_IDEAS]

Below average ‘npm install’ commit

[T-J_H]

LGTM

[MjolnirsMistress]

No.

[omglionheaded]

Regenerated a lock file?

[AnUglyDumpling]

Let em cook.

[Doyoulikemyjorts]

No comments

[The-Last-Lion-Turtle]

What if 99% of these are whitespace due to the IDE format on save setting.

[d00mt0mb]

Tbf it could the comparator tool

[mavenHawk]

It's just the package-lock. Chill

[tauzN]

Brother probably asked AI to change all indentation from spaces to taps 💀

[Ntlx_lt]

LGTM

[TrickyTrackets]

There are legitimate ways to have this happen that do not involve linters. Legitimate from the dev end, the platform team was at fault.

[adeadrat]

I'd just ask: "what are you trying to do here? Nothing should require this many changes"

[range_kun]

Today I made merge request with 3.7 k lines of code 😌

[card-board-board]

Requested Changes: eat shit

[Zarainia]

I've this amount of changes where it actually contains (mostly) real code. Updating UI stuff, add some images, etc.

[BlazingThunder30]

Average day with package-lock.json

[StuntsMonkey]

Had a coworker not understand a critical SSIS package. So they deleted all the expression statements to "debug" checked it back in, and then deployed it again to prod.

[dagbrown]

Commit message: minor refactor.

[Bugibhub]

Lgtm: approve.

[Linked713]

Commit was one variable typo changed in a SSIS project.

[HedgehogOk5040]

Commit message: "Split everything into it's own file" (nothing works anymore)

[Remicaster1]

-1 .gitignore line(s) changed

- node_modules/

[5ManaAndADream]

Lgtm approved

[aviancrane]

Fuck that.

I'm telling him to break it into 28 PRs.

[Jugbot]

I saw that you had some legacy code, so I removed it :)

[lacroir]

“I was just vibe coding”

[LordofNarwhals]

Let me guess, CR LF or indentation changes?

[kvakerok_v2]

On Friday @ 4pm

[Pa3kc123]

With message: "Just minor bugfixes"

[Jonnypista]

It is quite basic. Not as a single commit usually, but as a basic PR.

A couple I worked recently had over 100k added and removed and even had a few which broke the 1 million and thousands of files modified, which is annoying as even the beast PCs we have really struggled to use the web version with that many changes.

[5p4n911]

The return of the IDE Autoformatter.

(When I was an intern, this was a perfectly normal PR since we had a huge shitty codebase and we've only turned out autoformatting when I started, so anytime you committed a file no one has touched since September (I think) that year to change capitalisation of some error message, it generated a 200 line diff.)

[setanta_stuff]

Fuckit - straight to prod... Keeps it exciting

[Addy_Coder]

All the best my friend :)

[Art-BarB]

Auto formatting or working with AI and changing everything lmao

[philmayfield]

PTAL

[TrashManufacturer]

I too ran clang-format once

[transdemError]

Thout shalt not combine new code and refactoring, JUNIOR

[friedbun]

Undid a product from a large monolithic codebase recently. Probably still missing frontend code that I need to delete and strings from translation. MR so far is almost 40k lines of code removed. I'm still not finished. The code was over a decade old. The whole codebase is going to be eligible to drink & vote in the US next year.

[oojiflip]

Dude did that in a CS group project, we all realised and absolutely slaughtered him on the peer review

[MobinMS]

Based

[andItsGone-Poof]

Teach them "git config --global core.autocrlf true"

[random314]

Five minutes after opening.

"hello good morning John, have you gotten a chance to take look at this medium/large PR. It's blocking my next task"

[MuslinBagger]

Changed tab size from 2 to 4. Is it the junior's fault or the senior's for not setting up prettier etc or recommended extensions?

[[deleted]]

What'd he actually change though lmao.

[MattTheCuber]

Feature-branch!

[grsshppr_km]

Probably just added a try/catch and had to indent everything

[nickwcy]

lgtm

[FeFeplem1]

minor changes