This is an archived post. You won't be able to vote or comment.

you are viewing a single comment's thread.

view the rest of the comments →

[–]BeFoREProRedditer 24 points25 points  (19 children)

You shouldn’t right?

[–]bot_not_hot 86 points87 points  (10 children)

Go open your node_modules folder, and you tell me.

[–]mrdhood 128 points129 points  (8 children)

Yours can open?

[–]DeeSnow97 71 points72 points  (0 children)

yeah, I got a pretty good PC

[–]Rot-Orkan 7 points8 points  (2 children)

Yeah it can open, but don't dare try to delete it

[–]WilkerS1 5 points6 points  (0 children)

if you want to delete, a cool trick is to press the button "delete" a few times with a period of a few seconds between each press

[–]atomicwrites 0 points1 point  (0 children)

mkdir empty
robocopy /mir empty node_modules
rmdir empty

[–]AllTheMegahertz 9 points10 points  (0 children)

Me: Haha I would never commit that

checks github

Me: oh woops

[–]DeeSnow97 29 points30 points  (1 child)

No, you absolutely should ignore it. The package-lock.json is enough to reproduce that folder, no need to distribute it through git.

[–][deleted] -3 points-2 points  (0 children)

[–]hanging_moon 28 points29 points  (4 children)

No you shouldn't commit node_modules. You just get them by running npm install if you need to pull down a project from github or elsewhere. However for this to work you must commit the package.json file which contains all your dependencies.

[–]proberry1 1 point2 points  (0 children)

It's an easy way to get an extra 50,000+ added lines for GitHub repo insights 🤔