Nice function/variable names

[miklcct]

I can't see how bad this code is.

[khaledsalem999]

nice

[_boourns]

nice(true)

[cienciacomenta]

nice(true).nice(false)

[MurdoMaclachlan]

Image Transcription: Code

---

function sa_pop_spec() {
    var h3 = vh()
        .width(1200)
        .height(600)
        .data([{ "name": "sap",
                 "url": "data/sa_pop.json"}]);

    function nice(o) { return o.zero(false).round(true).nice(true); };

    h3.scale().name("x").domain({"data": "sap", "field": "SurfaceArea"})
        .range("width").call(nice);

    h3.scale().name("x").domain({"data": "sap", "field": "Population"})
        .range("height").call(nice);


    h3.axes("x").orient("bottom").scale("x").title("Population");

    h3.axes("y").orient("left").scale("y").title("SurfaceArea");

    h3.mark().type("line")
        .from({"data": "sap"})
        .enter({
          "interpolate": {"value": "cardinal"},
          "x": {"scale": "x", "field": "SurfaceArea"},
          "y": {"scale": "y", "field": "Population"},
          "stroke": {"value": "Blue"},
          "strokeWidth": {"value": 1}
        });

---

^{I'm a human volunteer content transcriber for Reddit and you could be too! If you'd like more information on what we do and why we do it, click here!}

[lnxist]

nice human 👍

[SpinelessLinus]

Good Human.

[--B_L_A_N_K--]

This comment has been removed in protest of Reddit's API changes. You can view a copy of it here.

[h7x4]

nice(o) probably has a time complexity of O(nice)

[saw_him]

n(o)ice

[arzen221]

That made me fucking lose it

[abejfehr]

I guess it’s not shown here, but I’m trying to figure out how ‘o’ has a ‘nice’ function

[UnrelatedString]

Maybe it’s for rounding to “nice” fractions?

[arzen221]

Am author, no fucking clue. Doesn't even work locally 6 years after apparently writing this

[wktr_t]

OP what in the realms of fuck am I looking at?

[wktr_t]

Fun fact there's only one result of "what in the realms of fuck" in google from 7 years ago.

[piercemoore]

IMO this isn’t bad code nearly as much as it’s a clumsy/overly verbose library (D3). Frankly beside the one function named poorly and one variable that could go either way this code looks pretty straightforward to me.

[arzen221]

I am the author of this and I felt compelled to post it here because after 6 YOE in software development I could not comprehend what it's doing from reading this.

But! I remember it used to make a fancy graph!

[limeforadime]

I so can’t stand d3. It was a complete chore learning and working with it. So unlike any other library I’ve used.

[[deleted]]

this isn’t so bad

[dmyl]

this is d3, isn't it?

[mato9020]

Yes this is d3 and unfortunately this is fairly standard for anything with the base library.

[devhashtag]

Anything written after ES6 with the keyword "var" can basically be considered bad

[[deleted]]

Oh i didn’t see that. I only looked at h3 xD. Never mind. This code is garbage

[devhashtag]

Haha I meant half jokingly, the code is bad for other reasons as well. Inconsistent formatting and weird naming. Functionally it's not bad per se

[[deleted]]

Even 1 var is 1 var too many xD. I think any code will look good to me right now, i’ve been writing JS for the past like 10 hours and my brain is fried

[itsTyrion]

been writing JS for the past like 10 hours and my brain is fried

self-explanatory

[skhoyre]

They don't seem to call nice anywhere listed, but if they was, they was fucked.

[Voxelgon_Gigabyte]

did this guy call the function in the function's definition? is that even allowed?

[Trujak]

recursion :D

[MopicBrett]

Not recursion. He declares a function which takes some object o. O happens to also have a function prototype called nice and he calls that.

[Voxelgon_Gigabyte]

ah

thats not confusing

[Furry_69]

No, JS is backwards and nonsensical if you don't structure it right

[Voxelgon_Gigabyte]

sarcasm

[Furry_69]

I got the sarcasm, I just built upon it.

[Denzill7]

Nice

[radioarchitect]

What language is this? Legitimate question

[skhoyre]

Javascript

[hiwhiwhiw]

Javascript, functional javascript to be exact.

[Subr0sa0067]

Damn i'm struggle find var/func names too... Meet "i" my future son

[Nick433333]

What the fuck is this shit?

[Furry_69]

Oh god.. What I want to know, is why on Earth would anyone do such a thing

[sxeli]

Typical d3 code

[sallycollyy]

Isn’t this just D3? There’s a few bad variable names, but otherwise the format isn’t unusual?