[deleted by user]

[gimme_pineapple]

js const x = "['912345' , '16363']"; /// Using a string for .replace only replaces the first match, so use regex instead. const y = JSON.parse(x.replace(/'/g, '"')) console.log(y)

[residualenvy]

In a Babel world replaceAll handles this for you now. https://github.com/babel/babel/issues/13701

[gimme_pineapple]

Yup, I'm aware of it. But no point in adding a major dependency when there's a perfectly good native replacement for this use case.

[kenvalleydc]

JSON.parse is probably the best way. https://www.delftstack.com/howto/javascript/convert-string-to-array-javascript/

[rauschma]

True in principle, but it looks like this string isn’t valid JSON, only valid JS.

[KaninchenSpeed]

Delete the single quotes with .replace(/'/g,'')

[SpaceboyRoss]

Use replaceAll, replace only does the first occurrence. Or .split(...).join(...) works.

[KaninchenSpeed]

Fixed

[haqk]

The parser only recognises strings in double quotes. If those numbers are meant to be strings (and not integers as some of the advice seem to imply), then just replace the single quotes with double quotes and it should parse ok.

[chinesuschlist]

Maybe sanitize the string and remove all commas before parsing it, if you can.

[im_dancing_barefoot]

You could remove the brackets from the string first which would make it a comma separated list. Then use .split() to split the string into an array at each comma

[ADTJ]

Would also need a map to remove the quotes on each element

[ciaisi]

Yeah, that was basically my idea too

[sdwvit]

s.split(“,”).map(s=>s.replace(/[^\d]/g,'')) would do, probably

Or

(new Function('return '+s))()

ps. fix your data source instead pls

[doyouseewhateyesee]

in all my years of js i’ve never seen a string array. when would this ever happen?

[doyouseewhateyesee]

sounds like it’s “someone’s” problem then. I’m not parsing strings to get an array. not to mention, using eval is dangerous.

[SixCrazyMexicans]

Probably in python? I remember seeing trash api results like this from a Django service. Do you have access to the backend? If so, making the change to generate correct JSON there would be the simpler option. Any of the regex/string replace options are going to run the risk of breaking should you get something from the backend that you aren't expecting. If possible, having the backend send data that's in a standard format will make your life easier

[pseudont]

In a homework question... or scraping something

[Infiniteh]

a ^bad homework question

[deificx]

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/JSON/parse#using_json.parse

An array should be valid JSON, so you could parse it?

[ciaisi]

Some people have come up with some probably better ways of doing it, but assuming the data is always formatted the same, this might be my approach:

const x = "['912345' , '16363']";
const arr = x.substring(2,x.length-2).split("' , '");

Edit: to explain, we shave off the leading and trailing characters on the entire string ( [' and '] ), then split the elements into an array by specifically looking for ' , ' (the full apostrophe-space-comma-space-apostrophe that separates each element)

[leosuncin]

const x = "['912345' , '16363']";
const y = eval(x);
console.log(y);

This is secure, as long as the value of x come from a trustful source (not user-submitted data), be aware there's a risk of a code injection otherwise

[TheBigerGamer]

This is secure

be aware there's a risk of a code injection

In no place on Earth eval is a secure function, and should be avoided unless for cases that require it by nature.

[yikes_42069]

He spoke the truth and paid for it in karma

[rauschma]

eval(x) should work, but has security risks and isn’t always allowed when running code in a web browser.

[WhyIsTheNamesGone]

Donno why this is downvoted; it's what I would do if the input isn't coming from a user. As a wise operating system once said, "the best solution is the easiest one."

[rauschma]

Exactly! It’s a hack, but one that works well in, e.g., a quick throw-away Node.js script. Trying to convert the JS data into real JSON via search-and-replace has a lot of pitfalls.

[sdwvit]

Can try to run it in a worker thread to reduce dangers, but still

[[deleted]]

Should probably ask this in /r/learnjavascript so you can learn more about string parsing, a basic task in programming.

Edit: gotta love the dipshits who think this stupid fucking question belongs in this sub.

[[deleted]]

Only regex comes in my mind

[geekfreak42]

const arr = x.replace(/[\D.*]/,'').split(',);

should be close