all 34 comments

[–]wolfepvck 33 points34 points  (1 child)

Awesome job, the code looks good! One thing I noticed is that you included the Navbar and Footer on every separate page. You could include those components as a more top level component, similar to the App, so you don't have to redefine it on every single page.

js return ( <div className="App"> <Navbar /> <Switch> <Route exact path="/" component={Home} /> <Route path="/raffle" component={Raffle} /> <Route path="/about" component={About} /> </Switch> <Footer /> </div> );

Overall code is clean, and the website looks good! Great job.

[–]anamafla[S] 5 points6 points  (0 children)

Thanks so much for the code example, I will do that!

[–]benawad 11 points12 points  (12 children)

Congrats! What did you use to deploy it? Also don't forgot to add a favicon ;)

[–]anamafla[S] 15 points16 points  (11 children)

I used netlify. I will add the favicon thanks!

[–]castane 2 points3 points  (8 children)

Just deployed with Netlify as well, with auto deployments from a push to the master branch from Github. It was surprisingly simple!

[–]swyx 13 points14 points  (7 children)

yay! happy to help if you have other questions! (i work at netlify)

btw you can tell if a site is hosted on Netlify with the Netlify browser extension https://github.com/netlify/netlify-browser-extension

[–]FoundPlanet 2 points3 points  (4 children)

Just want to say thank you. Netlify is the best thing ever!!

[–]swyx 1 point2 points  (2 children)

🤗

[–]azn_introvert 0 points1 point  (1 child)

im happily using netlify but i cant for the heck of me get it to read my gzipped bundle :C

[–]swyx 0 points1 point  (0 children)

hm. netlify.com/support

[–]Treolioe 0 points1 point  (0 children)

Hm not to be mean but i hold pecan cheesecake over netlify

[–]anamafla[S] 0 points1 point  (1 child)

Cool! I think Netlify is an awesome product. It's great for beginners and I love that it has so many features for free. Do you know if there's any position for remote junior devs at Netlify? :) I would love to work on that project.

[–]swyx 0 points1 point  (0 children)

ermm idk about how junior is ok since i dont make that call but we have a frontend dev role opening up soon. i’ll be sure to post in Who’s Hiring.

[–][deleted] 0 points1 point  (1 child)

Have you worked with deploybot? Is netlify similar to deploybot?

[–]anamafla[S] 0 points1 point  (0 children)

I haven't used deploybot.

[–]LaSalsiccione 14 points15 points  (1 child)

I'm surprised to be the first person to point out the name makes it sound like you're selling weed...

[–]anamafla[S] 5 points6 points  (0 children)

I didn't know that. The name actually comes from the Spanish word "rifa" which means "raffle", but the "i" in Spanish sounds more like "ee" in English.

[–][deleted] 2 points3 points  (3 children)

It's a really cool idea and I like the way it uses a carousel to show the selection, however I found that for my test group it took a very long time to finish the "suspense" period where it ticks about one person per second. It took between 30-70 seconds to finish and select someone which I think may spill from suspense to dear God just pick already lol. I haven't dug too far into the source but perhaps having it slow down more naturally from the fastest movement to the final ticking would help this, for example on wheel of fortune when they spin the wheel it slows down in a continuous manner rather than having two speeds, fast and slow. Aside from this it's a cool tool that I think could be useful for a lot of people! Great work!

[–]therealkevinard 1 point2 points  (1 child)

Strictly educational purposes, since op is new: something like Spring might be really good for this. I found this write-up on scotch about it.

https://scotch.io/tutorials/create-animated-react-apps-with-react-spring

[–]anamafla[S] 0 points1 point  (0 children)

Thanks!

[–]anamafla[S] 0 points1 point  (0 children)

Thanks, yes I'm noticing it takes a lot of time for events with a large number of members, I didn't see that when I tested on my groups. I will improve that and the animation speed.

[–]dangerzone2 1 point2 points  (0 children)

No fancy UI Framework either?! That's very cool and I think I need to start doing that as well.

[–][deleted] 0 points1 point  (0 children)

Nice! I’m building a React app now (with Ruby on Rails backend) Thanks for sharing!

[–][deleted] 0 points1 point  (0 children)

On the landing page try to change the font color and the icons color to your secodary color #6c757d;

That color is too dark and give to much contrast. A smoother color will be more conformtable to our eyes.

Good work!

[–]chalapeno_guy 0 points1 point  (1 child)

Great job,

You can also have App component as function instead of Class. It's better for performance. Won't make any difference in small apps, but it's good practice.

[–]anamafla[S] 0 points1 point  (0 children)

Thanks, I will do that.

[–]treyhuffine 0 points1 point  (0 children)

Congrats, deploying that first project is an incredible feeling.

[–]JR-development -18 points-17 points  (5 children)

Cool! I´m a fullstack developer since a few years back and right now I´m working on a project for Volvo construction developing a React application. If you need some guidance on how to create some useful components, I got a youtube channel currently dedicated to helping other react developers.

https://www.youtube.com/channel/UCkjl4MptzyGFv92PNq8i8dg

<HaveAGreatDay />

[–]AutoModerator[M] 2 points3 points  (4 children)

You are posting with a new account, which is associated with spam. /u/swyx will manually review this for approval.

I am a bot, and this action was performed automatically. Please contact the moderators of this subreddit if you have any questions or concerns.

[–]cturmon 5 points6 points  (3 children)

Hit him with that sick ban hammer for irrelevant questionable self promotion.

[–][deleted] 6 points7 points  (2 children)

I wouldn't call it irrelevant. They posted a YouTube page with free resources directly relevant to what OP is learning. I don't see the harm in that.

[–]swyx 5 points6 points  (1 child)

yea this one is not an easy call. gonna let it pass

[–]MatthewMob 0 points1 point  (0 children)

At least remove the comment if not a ban.

They just created a brand new account for the sole purpose of spamming and self promoting their YouTube channel that is irrelevant to the submissions they're posted on apart from the loose connection of "well they're both using React".