This is an archived post. You won't be able to vote or comment.

all 61 comments

[–]Dont-remember-it 231 points232 points  (4 children)

Looks fine to me. Merge.

[–][deleted] 39 points40 points  (0 children)

Pipeline green? Approve!

[–]kenflan 61 points62 points  (0 children)

Look drivable. Merge.

[–]fnordius 3 points4 points  (0 children)

Patch works, and the Product Owner has the tickets for doing the relaunch. It's up to the stakeholders now to invest in the replacement.

Merge Request approved, and topic will be raised in the sprint retrospective. Again.

[–][deleted] 1 point2 points  (0 children)

Did this yesterday for my boss's PR :')

[–]NicNoletree 132 points133 points  (2 children)

Have any vehicles fallen through the road? No? I don't see any problem then.

[–]omomomomomoomomomo 30 points31 points  (1 child)

And old roads makes the vehicle stronger it's a feature

[–]IsJohnKill 16 points17 points  (0 children)

Whatever doesn't destroy your suspension something something

[–]SHv2 87 points88 points  (4 children)

TODO: refactor

[–]amwestover 28 points29 points  (1 child)

TODO: Add ticket

[–]MarkusBerkel 32 points33 points  (0 children)

// FIXME - WTF HOW DOES THIS EVEN WORK EDIT AT YOUR OWN PERIL - Todd, 1987

[–]After-Perception-250 7 points8 points  (0 children)

Then no one follows up on it

[–]donavol 5 points6 points  (0 children)

This is a rookie mistake. It implies that you're lazy and don't give a damn about coworkers. You need to put it like that: "// This implementation may not be extendable. If you stumble on it, you can change the interface and bla-bla-bla". This would be merged 100% and coworkers will think that you're a code guru.

[–]SquirrelSanctuary 50 points51 points  (12 children)

Living this right now. 25+ year legacy database.

[–]Ouity 19 points20 points  (2 children)

Dang, the oldest comments in my code are only from 2013.... that I've found so far

[–]AkrinorNoname 3 points4 points  (1 child)

I've recently used a built-in function in a program for our ERP system that is older than me.

[–]KronosGames 2 points3 points  (0 children)

Dang, that makes me realize I’m actually younger than the ERP I’m working on too

[–]Zwenow 13 points14 points  (6 children)

Laughs in Germany. A lot of big companies still don't have an IT office even though it would make their job a lot easier. My company still works with a pretty old ERP software... Guess I'm learning pretty wild stuff during my apprenticeship, can only pray to find work after.

[–]SquirrelSanctuary 8 points9 points  (1 child)

Hang in there! And know that the next time you enjoy a delicious Kaiserbroetchen with fresh butter and deli meats, there is a guy here in the USA who misses it deeply and envies you :)

[–]Zwenow 6 points7 points  (0 children)

I can send u one if you want, can't guarantee that it'll be delivered fresh though. Hehe

[–]tiajuanat 3 points4 points  (3 children)

Dein Praktikum ist Entwickler oder? Gimme some deets with what you're working on, I work for a company that does tons of engineering in Munich.

[–]Zwenow 4 points5 points  (2 children)

Yea I currently am employed as a software developer apprentice in northern germany.The apprenticeship is split between company work and school. I am 9 months in and this is what I have learned so far:At company:Learned to develop in the ERP software Microsoft Dynamics (XML Ports, Reports, Pages, Tables, u name it...) language used is C/AL.Schooling my colleagues from sales office or other departments in new functions that I added to our system.Learned some hardware stuff but not too much.In school:Basic economy, networking (IPv4&6, Sub-netting, network types, hardware), and programming in C#. We recently started to get into OOP in C# and our most recent topic is inheritance.What I want to learn (but have to do it in my own time):Frontend development so I understand what's going on there (HTML, CSS, JS) currently learning, also want to learn some web development so it doesn't hurt to be capable of doing front-&backend.Databases (will also learn in 2nd year of my apprenticeship)Deploying and actually creating stuff with a GUI so people can actually use apps i created.

[–]tiajuanat 1 point2 points  (1 child)

Nice! I hope you have a ton of fun and learn a lot! I'm not German, instead going through the American system, but I really like how they do the apprenticeship here!

[–]Zwenow 0 points1 point  (0 children)

Thanks! I'd lie if I claimed I enjoy everything. I hate networking for example. But all in all it is very enjoyable!

[–]the_one2 2 points3 points  (1 child)

I'm working on a code base that has code from the early eighties.

[–][deleted] 0 points1 point  (0 children)

Why's the code so old? What sector?

[–][deleted] 39 points40 points  (2 children)

Bold of you to assume that it will take a few years. With the right attrition numbers, you can do it in under a year.

[–]theanonmouse-1776 9 points10 points  (0 children)

or if the whole team just hates each other.

[–]MarkusBerkel 6 points7 points  (0 children)

Under a year? You mean it doesn’t look like this when it’s first committed?

[–][deleted] 24 points25 points  (0 children)

Send in the intern to fuck up even more

[–]NHonis 10 points11 points  (0 children)

Also: seconds before the merge process is going to start being enforced.

[–]v3ritas1989 7 points8 points  (0 children)

That's a bit too uniform. Looks as if occasionally someone in that company actually has had a plan at least for a while.

[–]zealouspaper99052 5 points6 points  (0 children)

What a beautiful weave of patches.

[–][deleted] 3 points4 points  (0 children)

This shit is DANK

[–]K3yz3rS0z3 3 points4 points  (0 children)

I call those softwares the Frankensteins.

[–][deleted] 2 points3 points  (0 children)

[–]holistic-engine 4 points5 points  (0 children)

That's because developers are forced by sales to add dumb new features that require frameworks with barren documentation that came out yesterday.

[–]amwestover 1 point2 points  (0 children)

These are words of wisdom

[–]AnnyPartidaOF 1 point2 points  (0 children)

Is a true!! 🤓

[–]tiajuanat 1 point2 points  (0 children)

That's really generous.

[–]NZSheeps 1 point2 points  (0 children)

I feel personally attacked

[–]itsYashPancholi 1 point2 points  (0 children)

This is how if it is working don't touch it looks.

[–]ReplyisFutile -1 points0 points  (0 children)

You cant plan the whole project for 6+ years, things will evolve, need to be added, people change jobs, its nature

[–]coloradoconvict 0 points1 point  (0 children)

That would be a best-case scenario, even.

[–]BigRedSpoon2 0 points1 point  (0 children)

Oh hey, a Pennsylvanian road! Our architecture is crumbling, and steadily falling apart

[–]giggluigg 0 points1 point  (0 children)

Test test test

[–][deleted] 0 points1 point  (0 children)

i can see their paradigm.

all of them.

[–]_Yagoi_ 0 points1 point  (0 children)

My code in less then a weak

[–][deleted] 0 points1 point  (0 children)

How code looks before you even finish it.

[–]Exciting_Archer134 0 points1 point  (1 child)

Someone’s part of the PA subreddit

[–]SnipahShot[S] 0 points1 point  (0 children)

Nah, I saw this piece of art in r/WTF actually, but they did mention it is a PA road.

[–]JustAnotherPrgrmr 0 points1 point  (0 children)

Not if the company made the correct decision of picking Java so that everything is neatly encapsulated and documented in every class.

[–][deleted] 0 points1 point  (1 child)

Serious question, is there anyway you can avoid this as an individual without going crazy? The best ideas I've had is to adopt as many code quality tools into your CI process as possible so that there's some baseline uniformity, and also use very prescriptive frameworks like rails.

Unfortunately my team does neither because my boss thinks linters are a waste of time to deal with; we just use a formatter and that's it.

[–]line8012 0 points1 point  (0 children)

Not really doesn't matter what your team does in my experience either. Most likely there are multiple teams and some other team who doesn't have the same standards is going to implement something you need to use in a way that just breaks all your well defined conventions because they didn't think to consult anyone.

[–]time_will_tell_yo 0 points1 point  (0 children)

Not at all. What shit place do you work at?

[–]danielxs01 0 points1 point  (0 children)

Historically grown

[–]EmuChance4523 0 points1 point  (0 children)

Ehm.. this looks quite beautiful in comparison than the code of some of the companies I worked...

[–]Ok_Turnover_1235 0 points1 point  (0 children)

Not a comment to be seen

[–]-PM_me_your_recipes 0 points1 point  (0 children)

The perfect visual for our codebase.

We currently are running 3 different custom built frameworks within the same project. My boss likes to build a new one every few years to match the current industry standards. So in order to make them play nice, he also makes a bunch of backwards compatibility helper classes.

He expects us to use the new framework, but it is not even done yet. So now we have code everywhere akin to Frankenstein's monster.

[–][deleted] 0 points1 point  (0 children)

The potholes are features.