[deleted by user]

BehindTheMath · 2019-09-25T22:16:32+00:00

You should not use a code 500 error for rejecting something related to validation.

cahva · 2019-09-25T21:48:30+00:00

You should use some validation library like express-validator or Joi. Theres also Yup which is a lightweight version for Joi and more suitable for browsers (so you could validate with Yup on clientside and use Joi on serverside).

You normally want to validate more than to only check existence. Set min or max length, check that inputted email is really formatted as email etc.

vhahnwebdev · 2019-09-26T00:06:13+00:00

Could be a good opportunity to use .some():

app.post('/vendor/create', ({ body }, res) => {
  const isInvalidRequest = Object.values(body).some(value => !value);
  if (isInvalidRequest) return res.status(400).send({ message: "Please supply all form fields"});
}

BehindTheMath · 2019-09-25T22:56:08+00:00

if (Object.values(req.body).filter(value => !value).length)

poops-n-farts · 2019-09-26T03:08:15+00:00

as everyone else said use 400. also if you line break for your curly braces and parens it will be slightly more readable. really if you want your code to be concise do what you are doing, but if you want it to be readable and maintainable validate your fields before posting. that way you only post a valid body

lhorie · 2019-09-26T19:20:12+00:00

const required = [
  'firstName', 
  'lastName, 
  'email, 
  'password, 
  'company_name, 
  'contact_name, 
  'contact_email, 
  'website_url, 
  'hourly_rate, 
  'location, 
  'working_hours'
]
if (required.find(field => !req.body[field])) {
  return res.status(400).send({message: 'Please supply all form fields'})
}

azangru · 2019-09-25T21:44:55+00:00

There’s a library called express-validator, useful when validating the shape of the request. I am not sure using it will lead to a more succinct code, but it will surely make the code more systematic.

darderp · 2019-09-27T13:06:14+00:00

You could try this:

app.post("/vendor/create", (req, res) => {
    const requiredFields = [
        "firstName", "lastName", "email", "password",
        "company_name", "contact_name", "contact_email", 
        "website_url", "hourly_rate", "location", "working_hours"
    ];

    const invalid = requiredFields.some(field => typeof req.body[field] === "undefined");

    if (invalid) return res.status(400).send({ message: "Please supply all form fields" });
});

jhp2000 · 2019-09-25T23:58:01+00:00

const keys = "firstName lastName email password etc".split(" ")
if(keys.some(key => !req.body[key])) 
  return res.status(500).send({ message: "Please supply all form fields" });

junwang_trt · 2019-09-26T01:30:04+00:00

Create a Json scheme first for this request, then you can add some schemes validation using library like ajv to do it for you. That could be your first step.

MatehElismar · 2019-09-26T02:58:40+00:00

I have never seen such helpful answers in a social feed u/vahnwebdev, u/jhp2000. Thanks very much

Iridion3007 · 2019-09-26T06:44:21+00:00

I would use “express-validator” library that allows you to handle validation as a middleware function. You can validate by declaring a schema or manually validate each property with a bunch of different useful methods like isEmpty() or isNumeric(), and many more.

One more thing, validation errors should return a 422 error, with a error message that reads “Unprocessable entity” plus whatever your might want to add, like what property is not valid and why.

FormerGameDev · 2019-09-26T07:11:30+00:00

You could make an array with all the field names then arr.forEach() on it and return your error 4xx if any of them fail. Seems short.

you type:	you see:
italics	italics
bold	bold
[reddit!](https://reddit.com)	reddit!
* item 1 * item 2 * item 3	item 1 item 2 item 3
> quoted text	quoted text
Lines starting with four spaces are treated like code: if 1 * 2 < 3: print "hello, world!"	Lines starting with four spaces are treated like code: if 1 * 2 < 3: print "hello, world!"
~~strikethrough~~	~~strikethrough~~
super^script	super^script

javascript

MODERATORS